Bug #16770
closed
Commit: RUBY3_HAS_BUILTIN: fix for nonexistent builtin - large increase in MinGW & mswin compile times
Description
Inspecting logs both here and in ruby-loco, the following commit greatly increased compile time in MinGW builds:
In ruby-loco, the make/compile time jumped from 9:23 to 34:43.
Here:
after 32:22 - https://github.com/ruby/ruby/runs/569706642
before 11:11 - https://github.com/ruby/ruby/runs/569624968 [win32] Moved `MSC_VER` to verconf.mk...
Updated by MSP-Greg (Greg L) about 5 years ago
- Subject changed from Commit: RUBY3_HAS_BUILTIN: fix for nonexistent builtin - large increase in MinGW compile time to Commit: RUBY3_HAS_BUILTIN: fix for nonexistent builtin - large increase in MinGW & mswin compile times
Updated by Eregon (Benoit Daloze) about 5 years ago
Is it due to that specific commit, or rather due to https://github.com/ruby/ruby/pull/2991 ?
Updated by shyouhei (Shyouhei Urabe) about 5 years ago
- Assignee set to shyouhei (Shyouhei Urabe)
Updated by shyouhei (Shyouhei Urabe) about 5 years ago
- Related to Bug #16772: Build becomes slow with CIFS mounted srcdir added
Updated by MSP-Greg (Greg L) about 5 years ago
I apologize for the possible confusion. When I opened the issue, I woke up, and all three builds (Actions - mingw & mswin, AppVeyor - mingw) took much longer for both build & test. I mentioned the CI logs that showed when it occurred, but CI isn't done on every commit. I should have made clear that I didn't bisect the issue, I just determined a good/bad range of commits.
Regardless, as of 2020-04-10 master 878e21c6cd, all three builds have returned to normal build & test times.
Thank you.
I may be a little sensitive about master, as I try to encourage external repos/gems to test with it. Doing so allows them to know that it's very likely their code will work with new Ruby releases. It also provides a good feedback loop of info for ruby/ruby.
Ok to close.
Updated by Eregon (Benoit Daloze) about 5 years ago
- Status changed from Open to Closed
I guess 443389effc37308ce1a3c3a840082a344fc6af56 probably fixed this.