For making it possible HTMLEditor::SelectElement() to distinguish if it's called by outer class or editor itself, this patch creates HTMLEditor::SelectContentInternal().

Comment on attachment 8998801 [details] Bug 1482016 - part 1: Create HTMLEditor::SelectContentInternal() for internal use of HTMLEditor::SelectElement() Makoto Kato [:m_kato] has approved the revision.

Comment on attachment 8999498 [details] Bug 1482016 - part 0: Add automated tests for nsIHTMLEditor.selectElement() Makoto Kato [:m_kato] has approved the revision.

Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/302ce3cdb98f part 0: Add automated tests for nsIHTMLEditor.selectElement() r=m_kato

Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/ec2b796f1af2 part 1: Create HTMLEditor::SelectContentInternal() for internal use of HTMLEditor::SelectElement() r=m_kato

Backed out changeset ec2b796f1af2 (bug 1482016) for build bustages on builds/worker/workspace/build/src/editor/libeditor/HTMLTableEditor Backout: https://hg.mozilla.org/integration/autoland/rev/b9c875be605ea87103ccd549954a59543fbf48de Push with the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ec2b796f1af29470e3a96873df7fb8dcf805edb3 Failure log file: https://treeherder.mozilla.org/logviewer.html#?job_id=193800730&repo=autoland&lineNumber=20948

Wow, odd... Why did it green on tryserver??

Ah... opt only...

Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/419fd4edef4f part 1: Create HTMLEditor::SelectContentInternal() for internal use of HTMLEditor::SelectElement() r=m_kato

https://hg.mozilla.org/mozilla-central/rev/302ce3cdb98f https://hg.mozilla.org/mozilla-central/rev/419fd4edef4f

Backout by csabou@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/55313d9fd453 Backed out changeset 302ce3cdb98f for turning bug 1480702 into permafail. a=backout

Backout by csabou@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/8546719c58dc Backed out changeset 419fd4edef4f for turning Bug 1480702 into permafail. a=backout

Backed out for turning Bug 1480702 into permafail. I don't know how these two are related but looking at the below retriggers it shows clearly this is where it started. Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-searchStr=Android%204.3%20API16%2B%20debug%20Mochitests%20test-android-em-4.3-arm7-api-16%2Fdebug-mochitest-36%20M(36)&fromchange=597222dce884518ce020cd7a1552d0b571a158de&tochange=fd9dd6df3ae7acc647af581a8e0db4e6d43aa6b9&selectedJob=193959051 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=193959051&repo=autoland&lineNumber=1556 Backout links: https://hg.mozilla.org/mozilla-central/rev/55313d9fd453e37f3a34b9f9c9b714d4ccbb320d https://hg.mozilla.org/mozilla-central/rev/8546719c58dc2310bdafb81fd64a6295c59cd10e [task 2018-08-14T21:27:10.656Z] 21:27:10 INFO - 131 INFO TEST-PASS | dom/tests/mochitest/fetch/test_request.html | NestedWorker: true: Used Request cannot be passed to new Request [task 2018-08-14T21:27:10.656Z] 21:27:10 INFO - Buffered messages finished [task 2018-08-14T21:27:10.657Z] 21:27:10 INFO - 132 INFO TEST-UNEXPECTED-FAIL | dom/tests/mochitest/fetch/test_request.html | ServiceWorker: worker failed to import test_request.js; error: Failed to load worker script at test_request.js (nsresult = 0x8053000b) [task 2018-08-14T21:27:10.657Z] 21:27:10 INFO - onMessage@dom/tests/mochitest/fetch/fetch_test_framework.js:93:13 [task 2018-08-14T21:27:10.657Z] 21:27:10 INFO - 133 INFO TEST-OK | dom/tests/mochitest/fetch/test_request.html | took 34412ms

Hmm, if so, it's really odd since my patches changed HTMLEditor which is created only when a document is in designMode or has one or more elements which have contenteditable attribute. Those files do not create HTMLEditor instance: https://searchfox.org/mozilla-central/source/dom/tests/mochitest/fetch/test_request.html https://searchfox.org/mozilla-central/source/dom/tests/mochitest/fetch/fetch_test_framework.js https://searchfox.org/mozilla-central/source/dom/tests/mochitest/fetch/message_receiver.html

Oh, and according to the treehearder, adding the new automated test caused the failure???

In tryserver, I didn't see the failure... https://treeherder.mozilla.org/#/jobs?repo=try&revision=ce4b672ad880367e892e7cd9cdfceffd02434f6b https://treeherder.mozilla.org/#/jobs?repo=try&revision=5778cad3a3fcc54a76e52c480f3ab387319ee080 https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ceae21dfad91a4a98d1942f25cc9f09324afe2b

I cannot explain it either but backing out this bug turned the test green again: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=55313d9fd453e37f3a34b9f9c9b714d4ccbb320d&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=pending&filter-resultStatus=running&filter-resultStatus=success&filter-searchStr=android%204.3%20api16%20%20debug%20mochitests%20test-android-em-4.3-arm7-api-16%2Fdebug-mochitest-36%20m(36)&selectedJob=194005185 Until then it all orange.

Yeah, I'll reland them with disabling the new test only on debug Android.

Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/e6f93da48017 part 0: Add automated tests for nsIHTMLEditor.selectElement() r=m_kato

Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/c0c40b74e2b9 part 1: Create HTMLEditor::SelectContentInternal() for internal use of HTMLEditor::SelectElement() r=m_kato

https://hg.mozilla.org/mozilla-central/rev/e6f93da48017 https://hg.mozilla.org/mozilla-central/rev/c0c40b74e2b9