Closed
Bug 1484117
Opened 7 years ago
Closed 7 years ago
Split HTMLEditor::InsertTableRow() for internal use
Categories
(Core :: DOM: Editor, enhancement, P3)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
No description provided.
|
||
Updated•7 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Comment 2•7 years ago
|
||
|
|
Assignee | |
Comment 3•7 years ago
|
||
nsITableEditor::InsertTableRow() is an XPCOM method but there are some internal
users. So, HTMLEditor should implement it with a non-virtual method and
it should be used by all internal users.
|
|
Assignee | |
Comment 4•7 years ago
|
||
|
||
Updated•7 years ago
|
Attachment #9010007 -
Attachment description: Bug 1484117 - part 1: Create HTMLEditor::InsertTableRowWithTransaction() for internal use of nsITableEditor::InsertTableRow() → Bug 1484117 - part 1: Create HTMLEditor::InsertTableRowsWithTransaction() for internal use of nsITableEditor::InsertTableRow()
|
|
||
Comment 5•7 years ago
|
||
Comment on attachment 9010006 [details]
Bug 1484117 - part 0: Add automated tests for nsITableEditor.insertTableRow()
Makoto Kato [:m_kato] has approved the revision.
Attachment #9010006 -
Flags: review+
|
|
||
Comment 6•7 years ago
|
||
Comment on attachment 9010007 [details]
Bug 1484117 - part 1: Create HTMLEditor::InsertTableRowsWithTransaction() for internal use of nsITableEditor::InsertTableRow()
Makoto Kato [:m_kato] has approved the revision.
Attachment #9010007 -
Flags: review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/ede1caad7306
part 1: Create HTMLEditor::InsertTableRowsWithTransaction() for internal use of nsITableEditor::InsertTableRow() r=m_kato
https://hg.mozilla.org/integration/autoland/rev/d5e804da423c
part 0: Add automated tests for nsITableEditor.insertTableRow() r=m_kato
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ede1caad7306
https://hg.mozilla.org/mozilla-central/rev/d5e804da423c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
|
||
Updated•7 years ago
|
status-firefox63:
affected → ---
|
|
Assignee | |
Updated•7 years ago
|
Blocks: add-scriptable-editor-API-tests
You need to log in
before you can comment on or make changes to this bug.
Description
•