Add recover support for MInt64ToBigInt
Categories
(Core :: JavaScript Engine: JIT, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox131 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
Adding recover support for MInt64ToBigInt will allow to (more reliably) omit BigInt allocations when reading from BigInt64Array (and others).
|
Assignee | |
Comment 1•1 year ago
|
||
The code is based on the existing recover support for boxed values, with the
exception of INT64_CST, which is stored as two Int32Values in the constant
pool.
|
|
Assignee | |
Comment 2•1 year ago
|
||
|
|
Assignee | |
Comment 3•1 year ago
|
||
This is no longer needed now that MInt64ToBigInt is recoverable. We still need
to have this special case for MIonToWasmCall, because MIonToWasmCall's resume
point includes MInt64ToBigInt, but when lowering MIonToWasmCall, the safepoint
assumes all operands covered by the resume point have already been lowered, which
isn't the case for MIonToWasmCall, because MInt64ToBigInt is lowered after
MIonToWasmCall.
|
||
Updated•1 year ago
|
|
||
Comment 5•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b8fa5fd04ff4
https://hg.mozilla.org/mozilla-central/rev/ad036d0540b0
https://hg.mozilla.org/mozilla-central/rev/5601a4469a98
Description
•