sdefresne | 14900ee | 2015-11-27 14:43:21 | [diff] [blame] | 1 | // Copyright 2012 The Chromium Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
| 5 | // Implementation of about_flags for iOS that sets flags based on experimental |
| 6 | // settings. |
| 7 | |
| 8 | #include "ios/chrome/browser/about_flags.h" |
| 9 | |
avi | 57194367 | 2015-12-22 02:12:49 | [diff] [blame] | 10 | #include <stddef.h> |
| 11 | #include <stdint.h> |
sdefresne | 14900ee | 2015-11-27 14:43:21 | [diff] [blame] | 12 | #import <UIKit/UIKit.h> |
| 13 | |
Gregory Chatzinoff | f652372 | 2017-11-21 01:33:53 | [diff] [blame^] | 14 | #include "base/base_switches.h" |
sdefresne | 14900ee | 2015-11-27 14:43:21 | [diff] [blame] | 15 | #include "base/bind.h" |
| 16 | #include "base/command_line.h" |
| 17 | #include "base/logging.h" |
avi | 57194367 | 2015-12-22 02:12:49 | [diff] [blame] | 18 | #include "base/macros.h" |
sdefresne | 14900ee | 2015-11-27 14:43:21 | [diff] [blame] | 19 | #include "base/memory/singleton.h" |
| 20 | #include "base/strings/stringprintf.h" |
| 21 | #include "base/strings/sys_string_conversions.h" |
| 22 | #include "base/sys_info.h" |
robliao | 59eed1a | 2016-10-28 17:12:16 | [diff] [blame] | 23 | #include "base/task_scheduler/switches.h" |
sdefresne | 14900ee | 2015-11-27 14:43:21 | [diff] [blame] | 24 | #include "components/dom_distiller/core/dom_distiller_switches.h" |
Tommy Nyquist | c1d6dea1 | 2017-07-26 20:37:23 | [diff] [blame] | 25 | #include "components/feature_engagement/public/feature_constants.h" |
| 26 | #include "components/feature_engagement/public/feature_list.h" |
sdefresne | 14900ee | 2015-11-27 14:43:21 | [diff] [blame] | 27 | #include "components/flags_ui/feature_entry.h" |
| 28 | #include "components/flags_ui/feature_entry_macros.h" |
| 29 | #include "components/flags_ui/flags_storage.h" |
| 30 | #include "components/flags_ui/flags_ui_switches.h" |
noyau | 4cfb133 | 2016-10-25 17:05:42 | [diff] [blame] | 31 | #include "components/ntp_tiles/switches.h" |
Justin Donnelly | 33d712e | 2017-08-23 21:32:51 | [diff] [blame] | 32 | #include "components/omnibox/browser/omnibox_field_trial.h" |
mathp | 9b4c11d | 2017-07-06 20:24:13 | [diff] [blame] | 33 | #include "components/payments/core/features.h" |
Marc Treib | 5fc99e1f | 2017-11-08 12:19:18 | [diff] [blame] | 34 | #include "components/search_provider_logos/switches.h" |
elawrence | 816f6790e | 2017-06-16 18:19:28 | [diff] [blame] | 35 | #include "components/security_state/core/switches.h" |
David Roger | a6c8812 | 2017-10-25 13:02:46 | [diff] [blame] | 36 | #include "components/signin/core/browser/signin_switches.h" |
sdefresne | 3657978 | 2016-02-05 11:08:25 | [diff] [blame] | 37 | #include "components/strings/grit/components_strings.h" |
Marti Wong | 87d31d7 | 2017-08-25 02:44:52 | [diff] [blame] | 38 | #include "ios/chrome/browser/bookmarks/bookmark_new_generation_features.h" |
sdefresne | 14900ee | 2015-11-27 14:43:21 | [diff] [blame] | 39 | #include "ios/chrome/browser/chrome_switches.h" |
Jean-François Geyelin | 30be591 | 2017-08-25 12:05:38 | [diff] [blame] | 40 | #include "ios/chrome/browser/drag_and_drop/drag_and_drop_flag.h" |
vabr | 0215a8e | 2017-03-28 12:47:34 | [diff] [blame] | 41 | #include "ios/chrome/browser/ios_chrome_flag_descriptions.h" |
Mike Dougherty | a5e5ad5 | 2017-08-05 00:11:58 | [diff] [blame] | 42 | #include "ios/chrome/browser/ssl/captive_portal_features.h" |
Gregory Chatzinoff | 6f3a260 | 2017-10-31 06:24:35 | [diff] [blame] | 43 | #include "ios/chrome/browser/ui/activity_services/canonical_url_feature.h" |
Louis Romero | d11747a | 2017-10-20 20:10:35 | [diff] [blame] | 44 | #include "ios/chrome/browser/ui/external_search/features.h" |
Kurt Horimoto | a5a922a | 2017-11-07 00:21:09 | [diff] [blame] | 45 | #include "ios/chrome/browser/ui/fullscreen/fullscreen_features.h" |
sczs | a0c9194 | 2017-10-26 18:39:59 | [diff] [blame] | 46 | #import "ios/chrome/browser/ui/history/history_base_feature.h" |
Rohit Rao | 6a3a481d | 2017-09-25 19:31:41 | [diff] [blame] | 47 | #include "ios/chrome/browser/ui/main/main_feature_flags.h" |
sczs | 6ca1d26 | 2017-10-30 20:27:13 | [diff] [blame] | 48 | #import "ios/chrome/browser/ui/toolbar/public/toolbar_controller_base_feature.h" |
Justin Cohen | ba27610e | 2017-11-08 19:34:45 | [diff] [blame] | 49 | #import "ios/chrome/browser/ui/toolbar/toolbar_private_base_feature.h" |
sdefresne | 14900ee | 2015-11-27 14:43:21 | [diff] [blame] | 50 | #include "ios/chrome/grit/ios_strings.h" |
msarda | fc76f66 | 2017-02-24 12:46:28 | [diff] [blame] | 51 | #include "ios/public/provider/chrome/browser/chrome_browser_provider.h" |
Danyao Wang | 34da6ff | 2017-10-30 15:16:56 | [diff] [blame] | 52 | #include "ios/web/public/features.h" |
sdefresne | 14900ee | 2015-11-27 14:43:21 | [diff] [blame] | 53 | #include "ios/web/public/user_agent.h" |
| 54 | #include "ios/web/public/web_view_creation_util.h" |
| 55 | |
| 56 | #if !defined(OFFICIAL_BUILD) |
| 57 | #include "components/variations/variations_switches.h" |
vitaliii | 489217aa | 2017-01-30 14:50:22 | [diff] [blame] | 58 | #endif |
stkhapugin | c1be179 | 2016-12-13 14:30:53 | [diff] [blame] | 59 | |
| 60 | #if !defined(__has_feature) || !__has_feature(objc_arc) |
| 61 | #error "This file requires ARC support." |
| 62 | #endif |
sdefresne | 14900ee | 2015-11-27 14:43:21 | [diff] [blame] | 63 | |
elawrence | 816f6790e | 2017-06-16 18:19:28 | [diff] [blame] | 64 | using flags_ui::FeatureEntry; |
| 65 | |
sdefresne | 14900ee | 2015-11-27 14:43:21 | [diff] [blame] | 66 | namespace { |
elawrence | 816f6790e | 2017-06-16 18:19:28 | [diff] [blame] | 67 | const FeatureEntry::Choice kMarkHttpAsChoices[] = { |
| 68 | {flags_ui::kGenericExperimentChoiceDefault, "", ""}, |
elawrence | 816f6790e | 2017-06-16 18:19:28 | [diff] [blame] | 69 | {flag_descriptions::kMarkHttpAsDangerous, |
| 70 | security_state::switches::kMarkHttpAs, |
| 71 | security_state::switches::kMarkHttpAsDangerous}}; |
| 72 | |
Marc Treib | 5fc99e1f | 2017-11-08 12:19:18 | [diff] [blame] | 73 | const FeatureEntry::Choice kUseDdljsonApiChoices[] = { |
| 74 | {flags_ui::kGenericExperimentChoiceDefault, "", ""}, |
| 75 | {"(force test doodle 0)", search_provider_logos::switches::kGoogleDoodleUrl, |
| 76 | "https://www.gstatic.com/chrome/ntp/doodle_test/ddljson_ios0.json"}, |
| 77 | {"(force test doodle 1)", search_provider_logos::switches::kGoogleDoodleUrl, |
| 78 | "https://www.gstatic.com/chrome/ntp/doodle_test/ddljson_ios1.json"}, |
| 79 | {"(force test doodle 2)", search_provider_logos::switches::kGoogleDoodleUrl, |
| 80 | "https://www.gstatic.com/chrome/ntp/doodle_test/ddljson_ios2.json"}, |
| 81 | {"(force test doodle 3)", search_provider_logos::switches::kGoogleDoodleUrl, |
| 82 | "https://www.gstatic.com/chrome/ntp/doodle_test/ddljson_ios3.json"}, |
| 83 | {"(force test doodle 4)", search_provider_logos::switches::kGoogleDoodleUrl, |
| 84 | "https://www.gstatic.com/chrome/ntp/doodle_test/ddljson_ios4.json"}, |
| 85 | }; |
Marc Treib | 2752e8b | 2017-08-04 14:12:09 | [diff] [blame] | 86 | |
Cooper Knaak | 1e02656 | 2017-07-26 05:22:28 | [diff] [blame] | 87 | // To add a new entry, add to the end of kFeatureEntries. There are four |
sdefresne | 14900ee | 2015-11-27 14:43:21 | [diff] [blame] | 88 | // distinct types of entries: |
Cooper Knaak | 1e02656 | 2017-07-26 05:22:28 | [diff] [blame] | 89 | // . ENABLE_DISABLE_VALUE: entry is either enabled, disabled, or uses the |
| 90 | // default value for this feature. Use the ENABLE_DISABLE_VALUE_TYPE |
sdefresne | 14900ee | 2015-11-27 14:43:21 | [diff] [blame] | 91 | // macro for this type supplying the command line to the macro. |
| 92 | // . MULTI_VALUE: a list of choices, the first of which should correspond to a |
| 93 | // deactivated state for this lab (i.e. no command line option). To specify |
| 94 | // this type of entry use the macro MULTI_VALUE_TYPE supplying it the |
| 95 | // array of choices. |
Cooper Knaak | 1e02656 | 2017-07-26 05:22:28 | [diff] [blame] | 96 | // . FEATURE_VALUE: entry is associated with a base::Feature instance. Entry is |
| 97 | // either enabled, disabled, or uses the default value of the associated |
| 98 | // base::Feature instance. To specify this type of entry use the macro |
| 99 | // FEATURE_VALUE_TYPE supplying it the base::Feature instance. |
| 100 | // . FEATURE_WITH_PARAM_VALUES: a list of choices associated with a |
| 101 | // base::Feature instance. Choices corresponding to the default state, a |
| 102 | // universally enabled state, and a universally disabled state are |
| 103 | // automatically included. To specify this type of entry use the macro |
| 104 | // FEATURE_WITH_PARAMS_VALUE_TYPE supplying it the base::Feature instance and |
| 105 | // the array of choices. |
| 106 | // |
sdefresne | 14900ee | 2015-11-27 14:43:21 | [diff] [blame] | 107 | // See the documentation of FeatureEntry for details on the fields. |
| 108 | // |
| 109 | // When adding a new choice, add it to the end of the list. |
| 110 | const flags_ui::FeatureEntry kFeatureEntries[] = { |
vabr | 0215a8e | 2017-03-28 12:47:34 | [diff] [blame] | 111 | {"contextual-search", flag_descriptions::kContextualSearch, |
| 112 | flag_descriptions::kContextualSearchDescription, flags_ui::kOsIos, |
sdefresne | 14900ee | 2015-11-27 14:43:21 | [diff] [blame] | 113 | ENABLE_DISABLE_VALUE_TYPE(switches::kEnableContextualSearch, |
| 114 | switches::kDisableContextualSearch)}, |
vabr | 0215a8e | 2017-03-28 12:47:34 | [diff] [blame] | 115 | {"browser-task-scheduler", flag_descriptions::kBrowserTaskScheduler, |
| 116 | flag_descriptions::kBrowserTaskSchedulerDescription, flags_ui::kOsIos, |
robliao | 59eed1a | 2016-10-28 17:12:16 | [diff] [blame] | 117 | ENABLE_DISABLE_VALUE_TYPE(switches::kEnableBrowserTaskScheduler, |
| 118 | switches::kDisableBrowserTaskScheduler)}, |
elawrence | 816f6790e | 2017-06-16 18:19:28 | [diff] [blame] | 119 | {"mark-non-secure-as", flag_descriptions::kMarkHttpAsName, |
| 120 | flag_descriptions::kMarkHttpAsDescription, flags_ui::kOsIos, |
| 121 | MULTI_VALUE_TYPE(kMarkHttpAsChoices)}, |
mathp | 9b4c11d | 2017-07-06 20:24:13 | [diff] [blame] | 122 | {"web-payments", flag_descriptions::kWebPaymentsName, |
| 123 | flag_descriptions::kWebPaymentsDescription, flags_ui::kOsIos, |
| 124 | FEATURE_VALUE_TYPE(payments::features::kWebPayments)}, |
Randall Raymond | 59766ac | 2017-08-09 16:28:58 | [diff] [blame] | 125 | {"web-payments-native-apps", flag_descriptions::kWebPaymentsNativeAppsName, |
| 126 | flag_descriptions::kWebPaymentsNativeAppsDescription, flags_ui::kOsIos, |
| 127 | FEATURE_VALUE_TYPE(payments::features::kWebPaymentsNativeApps)}, |
Mike Dougherty | a5e5ad5 | 2017-08-05 00:11:58 | [diff] [blame] | 128 | {"ios-captive-portal", flag_descriptions::kCaptivePortalName, |
| 129 | flag_descriptions::kCaptivePortalDescription, flags_ui::kOsIos, |
| 130 | FEATURE_VALUE_TYPE(kCaptivePortalFeature)}, |
Cooper Knaak | 1e02656 | 2017-07-26 05:22:28 | [diff] [blame] | 131 | {"in-product-help-demo-mode-choice", |
| 132 | flag_descriptions::kInProductHelpDemoModeName, |
| 133 | flag_descriptions::kInProductHelpDemoModeDescription, flags_ui::kOsIos, |
| 134 | FEATURE_WITH_PARAMS_VALUE_TYPE( |
Tommy Nyquist | c1d6dea1 | 2017-07-26 20:37:23 | [diff] [blame] | 135 | feature_engagement::kIPHDemoMode, |
| 136 | feature_engagement::kIPHDemoModeChoiceVariations, |
Marc Treib | 2752e8b | 2017-08-04 14:12:09 | [diff] [blame] | 137 | "IPH_DemoMode")}, |
| 138 | {"use-ddljson-api", flag_descriptions::kUseDdljsonApiName, |
| 139 | flag_descriptions::kUseDdljsonApiDescription, flags_ui::kOsIos, |
Marc Treib | 5fc99e1f | 2017-11-08 12:19:18 | [diff] [blame] | 140 | MULTI_VALUE_TYPE(kUseDdljsonApiChoices)}, |
Justin Donnelly | 33d712e | 2017-08-23 21:32:51 | [diff] [blame] | 141 | {"omnibox-ui-elide-suggestion-url-after-host", |
| 142 | flag_descriptions::kOmniboxUIElideSuggestionUrlAfterHostName, |
| 143 | flag_descriptions::kOmniboxUIElideSuggestionUrlAfterHostDescription, |
| 144 | flags_ui::kOsIos, |
| 145 | FEATURE_VALUE_TYPE(omnibox::kUIExperimentElideSuggestionUrlAfterHost)}, |
| 146 | {"omnibox-ui-hide-suggestion-url-scheme", |
| 147 | flag_descriptions::kOmniboxUIHideSuggestionUrlSchemeName, |
| 148 | flag_descriptions::kOmniboxUIHideSuggestionUrlSchemeDescription, |
| 149 | flags_ui::kOsIos, |
| 150 | FEATURE_VALUE_TYPE(omnibox::kUIExperimentHideSuggestionUrlScheme)}, |
| 151 | {"omnibox-ui-hide-suggestion-url-trivial-subdomains", |
| 152 | flag_descriptions::kOmniboxUIHideSuggestionUrlTrivialSubdomainsName, |
| 153 | flag_descriptions::kOmniboxUIHideSuggestionUrlTrivialSubdomainsDescription, |
| 154 | flags_ui::kOsIos, |
| 155 | FEATURE_VALUE_TYPE( |
Marti Wong | 87d31d7 | 2017-08-25 02:44:52 | [diff] [blame] | 156 | omnibox::kUIExperimentHideSuggestionUrlTrivialSubdomains)}, |
| 157 | {"bookmark-new-generation", flag_descriptions::kBookmarkNewGenerationName, |
| 158 | flag_descriptions::kBookmarkNewGenerationDescription, flags_ui::kOsIos, |
Marti Wong | f0f4dfb | 2017-09-01 11:24:39 | [diff] [blame] | 159 | FEATURE_VALUE_TYPE(kBookmarkNewGeneration)}, |
Jean-François Geyelin | 30be591 | 2017-08-25 12:05:38 | [diff] [blame] | 160 | #if defined(__IPHONE_11_0) && (__IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_11_0) |
| 161 | {"drag_and_drop", flag_descriptions::kDragAndDropName, |
| 162 | flag_descriptions::kDragAndDropDescription, flags_ui::kOsIos, |
Rohit Rao | 6a3a481d | 2017-09-25 19:31:41 | [diff] [blame] | 163 | FEATURE_VALUE_TYPE(kDragAndDrop)}, |
Jean-François Geyelin | 30be591 | 2017-08-25 12:05:38 | [diff] [blame] | 164 | #endif |
Rohit Rao | 6a3a481d | 2017-09-25 19:31:41 | [diff] [blame] | 165 | {"tab_switcher_presents_bvc", |
| 166 | flag_descriptions::kTabSwitcherPresentsBVCName, |
| 167 | flag_descriptions::kTabSwitcherPresentsBVCDescription, flags_ui::kOsIos, |
Jean-François Geyelin | ed4cde7 | 2017-10-11 11:34:50 | [diff] [blame] | 168 | FEATURE_VALUE_TYPE(kTabSwitcherPresentsBVC)}, |
| 169 | {"safe_area_compatible_toolbar", |
| 170 | flag_descriptions::kSafeAreaCompatibleToolbarName, |
| 171 | flag_descriptions::kSafeAreaCompatibleToolbarDescription, flags_ui::kOsIos, |
Louis Romero | d11747a | 2017-10-20 20:10:35 | [diff] [blame] | 172 | FEATURE_VALUE_TYPE(kSafeAreaCompatibleToolbar)}, |
| 173 | {"external-search", flag_descriptions::kExternalSearchName, |
| 174 | flag_descriptions::kExternalSearchDescription, flags_ui::kOsIos, |
| 175 | FEATURE_VALUE_TYPE(kExternalSearch)}, |
sczs | a0c9194 | 2017-10-26 18:39:59 | [diff] [blame] | 176 | {"history-batch-updates-filter", |
| 177 | flag_descriptions::kHistoryBatchUpdatesFilterName, |
| 178 | flag_descriptions::kHistoryBatchUpdatesFilterDescription, flags_ui::kOsIos, |
| 179 | FEATURE_VALUE_TYPE(kHistoryBatchUpdatesFilter)}, |
Danyao Wang | 34da6ff | 2017-10-30 15:16:56 | [diff] [blame] | 180 | {"slim-navigation-manager", flag_descriptions::kSlimNavigationManagerName, |
| 181 | flag_descriptions::kSlimNavigationManagerDescription, flags_ui::kOsIos, |
| 182 | FEATURE_VALUE_TYPE(web::features::kSlimNavigationManager)}, |
Gregory Chatzinoff | 6f3a260 | 2017-10-31 06:24:35 | [diff] [blame] | 183 | {"ios-share-canonical-url", flag_descriptions::kShareCanonicalURLName, |
| 184 | flag_descriptions::kShareCanonicalURLDescription, flags_ui::kOsIos, |
| 185 | FEATURE_VALUE_TYPE(activity_services::kShareCanonicalURL)}, |
sczs | 9a142dc | 2017-10-31 23:34:06 | [diff] [blame] | 186 | {"property-animations-toolbar", |
| 187 | flag_descriptions::kPropertyAnimationsToolbarName, |
| 188 | flag_descriptions::kPropertyAnimationsToolbarDescription, flags_ui::kOsIos, |
Gauthier Ambard | ba34b46 | 2017-11-06 09:06:42 | [diff] [blame] | 189 | FEATURE_VALUE_TYPE(kPropertyAnimationsToolbar)}, |
Kurt Horimoto | a5a922a | 2017-11-07 00:21:09 | [diff] [blame] | 190 | {"new-fullscreen-controller", flag_descriptions::kNewFullscreenName, |
| 191 | flag_descriptions::kNewFullscreenDescription, flags_ui::kOsIos, |
Gauthier Ambard | ccc4c68 | 2017-11-17 15:36:37 | [diff] [blame] | 192 | FEATURE_VALUE_TYPE(fullscreen::features::kNewFullscreen)}, |
| 193 | {"clean-toolbar", flag_descriptions::kCleanToolbarName, |
| 194 | flag_descriptions::kCleanToolbarDescription, flags_ui::kOsIos, |
| 195 | FEATURE_VALUE_TYPE(kCleanToolbar)}}; |
sdefresne | 14900ee | 2015-11-27 14:43:21 | [diff] [blame] | 196 | |
| 197 | // Add all switches from experimental flags to |command_line|. |
| 198 | void AppendSwitchesFromExperimentalSettings(base::CommandLine* command_line) { |
| 199 | NSUserDefaults* defaults = [NSUserDefaults standardUserDefaults]; |
| 200 | |
sdefresne | 14900ee | 2015-11-27 14:43:21 | [diff] [blame] | 201 | // Web page replay flags. |
| 202 | BOOL webPageReplayEnabled = [defaults boolForKey:@"WebPageReplayEnabled"]; |
| 203 | NSString* webPageReplayProxy = |
| 204 | [defaults stringForKey:@"WebPageReplayProxyAddress"]; |
| 205 | if (webPageReplayEnabled && [webPageReplayProxy length]) { |
| 206 | command_line->AppendSwitch(switches::kIOSIgnoreCertificateErrors); |
| 207 | // 80 and 443 are the default ports from web page replay. |
| 208 | command_line->AppendSwitchASCII(switches::kIOSTestingFixedHttpPort, "80"); |
| 209 | command_line->AppendSwitchASCII(switches::kIOSTestingFixedHttpsPort, "443"); |
| 210 | command_line->AppendSwitchASCII( |
| 211 | switches::kIOSHostResolverRules, |
| 212 | "MAP * " + base::SysNSStringToUTF8(webPageReplayProxy)); |
| 213 | } |
| 214 | |
sdefresne | 14900ee | 2015-11-27 14:43:21 | [diff] [blame] | 215 | // Set the UA flag if UseMobileSafariUA is enabled. |
| 216 | if ([defaults boolForKey:@"UseMobileSafariUA"]) { |
| 217 | // Safari uses "Vesion/", followed by the OS version excluding bugfix, where |
| 218 | // Chrome puts its product token. |
avi | 57194367 | 2015-12-22 02:12:49 | [diff] [blame] | 219 | int32_t major = 0; |
| 220 | int32_t minor = 0; |
| 221 | int32_t bugfix = 0; |
sdefresne | 14900ee | 2015-11-27 14:43:21 | [diff] [blame] | 222 | base::SysInfo::OperatingSystemVersionNumbers(&major, &minor, &bugfix); |
| 223 | std::string product = base::StringPrintf("Version/%d.%d", major, minor); |
| 224 | |
| 225 | command_line->AppendSwitchASCII(switches::kUserAgent, |
| 226 | web::BuildUserAgentFromProduct(product)); |
| 227 | } |
| 228 | |
jkrcal | 7d79de5 | 2017-05-05 18:13:10 | [diff] [blame] | 229 | // Populate command line flag for fetching missing favicons for NTP tiles. |
| 230 | NSString* enableMostLikelyFaviconsFromServer = |
| 231 | [defaults stringForKey:@"EnableNtpMostLikelyFaviconsFromServer"]; |
| 232 | if ([enableMostLikelyFaviconsFromServer isEqualToString:@"Enabled"]) { |
| 233 | command_line->AppendSwitch( |
| 234 | ntp_tiles::switches::kEnableNtpMostLikelyFaviconsFromServer); |
| 235 | } else if ([enableMostLikelyFaviconsFromServer isEqualToString:@"Disabled"]) { |
| 236 | command_line->AppendSwitch( |
| 237 | ntp_tiles::switches::kDisableNtpMostLikelyFaviconsFromServer); |
| 238 | } |
| 239 | |
sdefresne | 14900ee | 2015-11-27 14:43:21 | [diff] [blame] | 240 | // Freeform commandline flags. These are added last, so that any flags added |
| 241 | // earlier in this function take precedence. |
| 242 | if ([defaults boolForKey:@"EnableFreeformCommandLineFlags"]) { |
| 243 | base::CommandLine::StringVector flags; |
| 244 | // Append an empty "program" argument. |
| 245 | flags.push_back(""); |
| 246 | |
| 247 | // The number of flags corresponds to the number of text fields in |
| 248 | // Experimental.plist. |
| 249 | const int kNumFreeformFlags = 5; |
| 250 | for (int i = 1; i <= kNumFreeformFlags; ++i) { |
| 251 | NSString* key = |
| 252 | [NSString stringWithFormat:@"FreeformCommandLineFlag%d", i]; |
| 253 | NSString* flag = [defaults stringForKey:key]; |
| 254 | if ([flag length]) { |
| 255 | flags.push_back(base::SysNSStringToUTF8(flag)); |
| 256 | } |
| 257 | } |
| 258 | |
| 259 | base::CommandLine temp_command_line(flags); |
| 260 | command_line->AppendArguments(temp_command_line, false); |
| 261 | } |
msarda | fc76f66 | 2017-02-24 12:46:28 | [diff] [blame] | 262 | |
justincohen | dacc85d | 2017-06-28 23:34:10 | [diff] [blame] | 263 | // Populate command line flag for 3rd party keyboard omnibox workaround. |
| 264 | NSString* enableThirdPartyKeyboardWorkaround = |
| 265 | [defaults stringForKey:@"EnableThirdPartyKeyboardWorkaround"]; |
| 266 | if ([enableThirdPartyKeyboardWorkaround isEqualToString:@"Enabled"]) { |
| 267 | command_line->AppendSwitch(switches::kEnableThirdPartyKeyboardWorkaround); |
| 268 | } else if ([enableThirdPartyKeyboardWorkaround isEqualToString:@"Disabled"]) { |
| 269 | command_line->AppendSwitch(switches::kDisableThirdPartyKeyboardWorkaround); |
| 270 | } |
| 271 | |
msarda | fc76f66 | 2017-02-24 12:46:28 | [diff] [blame] | 272 | ios::GetChromeBrowserProvider()->AppendSwitchesFromExperimentalSettings( |
| 273 | defaults, command_line); |
sdefresne | 14900ee | 2015-11-27 14:43:21 | [diff] [blame] | 274 | } |
| 275 | |
| 276 | bool SkipConditionalFeatureEntry(const flags_ui::FeatureEntry& entry) { |
| 277 | return false; |
| 278 | } |
| 279 | |
| 280 | class FlagsStateSingleton { |
| 281 | public: |
| 282 | FlagsStateSingleton() |
| 283 | : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {} |
| 284 | ~FlagsStateSingleton() {} |
| 285 | |
| 286 | static FlagsStateSingleton* GetInstance() { |
| 287 | return base::Singleton<FlagsStateSingleton>::get(); |
| 288 | } |
| 289 | |
| 290 | static flags_ui::FlagsState* GetFlagsState() { |
| 291 | return &GetInstance()->flags_state_; |
| 292 | } |
| 293 | |
| 294 | private: |
| 295 | flags_ui::FlagsState flags_state_; |
| 296 | |
| 297 | DISALLOW_COPY_AND_ASSIGN(FlagsStateSingleton); |
| 298 | }; |
| 299 | } // namespace |
| 300 | |
| 301 | void ConvertFlagsToSwitches(flags_ui::FlagsStorage* flags_storage, |
| 302 | base::CommandLine* command_line) { |
| 303 | FlagsStateSingleton::GetFlagsState()->ConvertFlagsToSwitches( |
sdefresne | c976390 | 2015-12-02 10:30:11 | [diff] [blame] | 304 | flags_storage, command_line, flags_ui::kAddSentinels, |
Gregory Chatzinoff | f652372 | 2017-11-21 01:33:53 | [diff] [blame^] | 305 | switches::kEnableFeatures, switches::kDisableFeatures); |
sdefresne | 14900ee | 2015-11-27 14:43:21 | [diff] [blame] | 306 | AppendSwitchesFromExperimentalSettings(command_line); |
| 307 | } |
| 308 | |
jkrcal | bf07337 | 2016-07-29 07:21:31 | [diff] [blame] | 309 | std::vector<std::string> RegisterAllFeatureVariationParameters( |
| 310 | flags_ui::FlagsStorage* flags_storage, |
| 311 | base::FeatureList* feature_list) { |
| 312 | return FlagsStateSingleton::GetFlagsState() |
| 313 | ->RegisterAllFeatureVariationParameters(flags_storage, feature_list); |
| 314 | } |
| 315 | |
sdefresne | 14900ee | 2015-11-27 14:43:21 | [diff] [blame] | 316 | void GetFlagFeatureEntries(flags_ui::FlagsStorage* flags_storage, |
| 317 | flags_ui::FlagAccess access, |
| 318 | base::ListValue* supported_entries, |
| 319 | base::ListValue* unsupported_entries) { |
| 320 | FlagsStateSingleton::GetFlagsState()->GetFlagFeatureEntries( |
| 321 | flags_storage, access, supported_entries, unsupported_entries, |
| 322 | base::Bind(&SkipConditionalFeatureEntry)); |
| 323 | } |
| 324 | |
| 325 | void SetFeatureEntryEnabled(flags_ui::FlagsStorage* flags_storage, |
| 326 | const std::string& internal_name, |
| 327 | bool enable) { |
| 328 | FlagsStateSingleton::GetFlagsState()->SetFeatureEntryEnabled( |
| 329 | flags_storage, internal_name, enable); |
| 330 | } |
| 331 | |
| 332 | void ResetAllFlags(flags_ui::FlagsStorage* flags_storage) { |
| 333 | FlagsStateSingleton::GetFlagsState()->ResetAllFlags(flags_storage); |
| 334 | } |
| 335 | |
| 336 | namespace testing { |
| 337 | |
| 338 | const flags_ui::FeatureEntry* GetFeatureEntries(size_t* count) { |
| 339 | *count = arraysize(kFeatureEntries); |
| 340 | return kFeatureEntries; |
| 341 | } |
| 342 | |
| 343 | } // namespace testing |