Break out isFramePending into its own feature
Ensure that when shipping isInputPending, we don't ship isFramePending as collateral.
(cherry picked from commit d008dc582ee0de97dc18924f9d298d128ad7b8ae)
Bug: 910421
Change-Id: Iddfc0ba927a9b61a90e99da18e12bb7513c93b27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443213
Commit-Queue: Andrew Comminos <[email protected]>
Commit-Queue: Philip Rogers <[email protected]>
Reviewed-by: Philip Rogers <[email protected]>
Auto-Submit: Andrew Comminos <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#812966}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466164
Reviewed-by: Andrew Comminos <[email protected]>
Cr-Commit-Position: refs/branch-heads/4280@{#267}
Cr-Branched-From: ea420fb963f9658c9969b6513c56b8f47efa1a2a-refs/heads/master@{#812852}
diff --git a/third_party/blink/renderer/core/frame/scheduling.idl b/third_party/blink/renderer/core/frame/scheduling.idl
index 6754e84..2ddbffed 100644
--- a/third_party/blink/renderer/core/frame/scheduling.idl
+++ b/third_party/blink/renderer/core/frame/scheduling.idl
@@ -7,6 +7,6 @@
Exposed=Window,
RuntimeEnabled=ExperimentalIsInputPending
] interface Scheduling {
- [RuntimeEnabled=ExperimentalIsInputPending] boolean isFramePending();
+ [RuntimeEnabled=ExperimentalIsFramePending] boolean isFramePending();
[CallWith=ScriptState, MeasureAs=SchedulingIsInputPending, RuntimeEnabled=ExperimentalIsInputPending] boolean isInputPending(optional IsInputPendingOptions options = {});
};
diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5 b/third_party/blink/renderer/platform/runtime_enabled_features.json5
index 114d44f..308d2e8 100644
--- a/third_party/blink/renderer/platform/runtime_enabled_features.json5
+++ b/third_party/blink/renderer/platform/runtime_enabled_features.json5
@@ -751,10 +751,14 @@
name: "ExperimentalContentSecurityPolicyFeatures",
status: "experimental",
},
- // Enables navigator.scheduling.isInputPending and
- // navigator.scheduling.isFramePending, allowing long-running JS to
- // be able to yield itself when user input is queued (crbug.com/910421) or a
- // display update is scheduled.
+ // Enables navigator.scheduling.isFramePending, allowing long-running JS to
+ // be able to yield itself when a display update is scheduled.
+ {
+ name: "ExperimentalIsFramePending",
+ status: "experimental"
+ },
+ // Enables navigator.scheduling.isInputPending, allowing long-running JS to
+ // be able to yield itself when user input is queued (crbug.com/910421).
{
name: "ExperimentalIsInputPending",
origin_trial_feature_name: "ExperimentalIsInputPending",
diff --git a/third_party/blink/web_tests/http/tests/origin_trials/webexposed/isinputpending-origin-trial-interfaces.html b/third_party/blink/web_tests/http/tests/origin_trials/webexposed/isinputpending-origin-trial-interfaces.html
index fc5497f..f864b9b0 100644
--- a/third_party/blink/web_tests/http/tests/origin_trials/webexposed/isinputpending-origin-trial-interfaces.html
+++ b/third_party/blink/web_tests/http/tests/origin_trials/webexposed/isinputpending-origin-trial-interfaces.html
@@ -15,8 +15,8 @@
OriginTrialsHelper.check_properties_exist(this,
{
'Navigator': ['scheduling'],
- 'Scheduling': ['isFramePending', 'isInputPending'],
+ 'Scheduling': ['isInputPending'],
},
);
-}, "isFramePending/isInputPending related interfaces in Origin-Trial enabled document.");
+}, "isInputPending related interfaces in Origin-Trial enabled document.");
</script>
