| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 1 | // Copyright 2016 The Chromium Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
| 5 | #include "components/ntp_snippets/content_suggestions_service.h" |
| 6 | |
| 7 | #include <algorithm> |
| 8 | #include <iterator> |
| vitaliii | 4594115 | 2016-09-05 08:58:13 | [diff] [blame] | 9 | #include <set> |
| jkrcal | e13510e | 2016-09-08 17:56:20 | [diff] [blame] | 10 | #include <utility> |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 11 | |
| 12 | #include "base/bind.h" |
| pke | 1da9060 | 2016-08-05 14:20:27 | [diff] [blame] | 13 | #include "base/location.h" |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 14 | #include "base/strings/string_number_conversions.h" |
| pke | 1da9060 | 2016-08-05 14:20:27 | [diff] [blame] | 15 | #include "base/threading/thread_task_runner_handle.h" |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 16 | #include "ui/gfx/image/image.h" |
| 17 | |
| 18 | namespace ntp_snippets { |
| 19 | |
| vitaliii | 4594115 | 2016-09-05 08:58:13 | [diff] [blame] | 20 | ContentSuggestionsService::ContentSuggestionsService( |
| 21 | State state, |
| jkrcal | e13510e | 2016-09-08 17:56:20 | [diff] [blame] | 22 | history::HistoryService* history_service, |
| 23 | PrefService* pref_service) |
| 24 | : state_(state), |
| 25 | history_service_observer_(this), |
| 26 | user_classifier_(pref_service) { |
| vitaliii | 4594115 | 2016-09-05 08:58:13 | [diff] [blame] | 27 | // Can be null in tests. |
| 28 | if (history_service) |
| 29 | history_service_observer_.Add(history_service); |
| 30 | } |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 31 | |
| 32 | ContentSuggestionsService::~ContentSuggestionsService() {} |
| 33 | |
| 34 | void ContentSuggestionsService::Shutdown() { |
| pke | 5728f08 | 2016-08-03 17:27:35 | [diff] [blame] | 35 | ntp_snippets_service_ = nullptr; |
| 36 | id_category_map_.clear(); |
| 37 | suggestions_by_category_.clear(); |
| 38 | providers_by_category_.clear(); |
| 39 | categories_.clear(); |
| 40 | providers_.clear(); |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 41 | state_ = State::DISABLED; |
| 42 | FOR_EACH_OBSERVER(Observer, observers_, ContentSuggestionsServiceShutdown()); |
| 43 | } |
| 44 | |
| pke | 9c5095ac | 2016-08-01 13:53:12 | [diff] [blame] | 45 | CategoryStatus ContentSuggestionsService::GetCategoryStatus( |
| 46 | Category category) const { |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 47 | if (state_ == State::DISABLED) { |
| pke | 9c5095ac | 2016-08-01 13:53:12 | [diff] [blame] | 48 | return CategoryStatus::ALL_SUGGESTIONS_EXPLICITLY_DISABLED; |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 49 | } |
| 50 | |
| pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 51 | auto iterator = providers_by_category_.find(category); |
| 52 | if (iterator == providers_by_category_.end()) |
| pke | 9c5095ac | 2016-08-01 13:53:12 | [diff] [blame] | 53 | return CategoryStatus::NOT_PROVIDED; |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 54 | |
| 55 | return iterator->second->GetCategoryStatus(category); |
| 56 | } |
| 57 | |
| pke | bd2f650a | 2016-08-09 14:53:45 | [diff] [blame] | 58 | base::Optional<CategoryInfo> ContentSuggestionsService::GetCategoryInfo( |
| 59 | Category category) const { |
| 60 | auto iterator = providers_by_category_.find(category); |
| 61 | if (iterator == providers_by_category_.end()) |
| 62 | return base::Optional<CategoryInfo>(); |
| 63 | return iterator->second->GetCategoryInfo(category); |
| 64 | } |
| 65 | |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 66 | const std::vector<ContentSuggestion>& |
| pke | 9c5095ac | 2016-08-01 13:53:12 | [diff] [blame] | 67 | ContentSuggestionsService::GetSuggestionsForCategory(Category category) const { |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 68 | auto iterator = suggestions_by_category_.find(category); |
| 69 | if (iterator == suggestions_by_category_.end()) |
| 70 | return no_suggestions_; |
| 71 | return iterator->second; |
| 72 | } |
| 73 | |
| 74 | void ContentSuggestionsService::FetchSuggestionImage( |
| 75 | const std::string& suggestion_id, |
| 76 | const ImageFetchedCallback& callback) { |
| 77 | if (!id_category_map_.count(suggestion_id)) { |
| 78 | LOG(WARNING) << "Requested image for unknown suggestion " << suggestion_id; |
| pke | 1da9060 | 2016-08-05 14:20:27 | [diff] [blame] | 79 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
| pke | f29505d | 2016-08-26 14:46:34 | [diff] [blame] | 80 | FROM_HERE, base::Bind(callback, gfx::Image())); |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 81 | return; |
| 82 | } |
| pke | 9c5095ac | 2016-08-01 13:53:12 | [diff] [blame] | 83 | Category category = id_category_map_.at(suggestion_id); |
| pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 84 | if (!providers_by_category_.count(category)) { |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 85 | LOG(WARNING) << "Requested image for suggestion " << suggestion_id |
| pke | 31b0794 | 2016-08-01 11:35:02 | [diff] [blame] | 86 | << " for unavailable category " << category; |
| pke | 1da9060 | 2016-08-05 14:20:27 | [diff] [blame] | 87 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
| pke | f29505d | 2016-08-26 14:46:34 | [diff] [blame] | 88 | FROM_HERE, base::Bind(callback, gfx::Image())); |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 89 | return; |
| 90 | } |
| pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 91 | providers_by_category_[category]->FetchSuggestionImage(suggestion_id, |
| 92 | callback); |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 93 | } |
| 94 | |
| vitaliii | 685fdfaa | 2016-08-31 11:25:46 | [diff] [blame] | 95 | void ContentSuggestionsService::ClearHistory( |
| 96 | base::Time begin, |
| 97 | base::Time end, |
| 98 | const base::Callback<bool(const GURL& url)>& filter) { |
| 99 | for (const auto& provider : providers_) { |
| 100 | provider->ClearHistory(begin, end, filter); |
| 101 | } |
| 102 | } |
| 103 | |
| treib | 7d1d7a5 | 2016-08-24 14:04:55 | [diff] [blame] | 104 | void ContentSuggestionsService::ClearAllCachedSuggestions() { |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 105 | suggestions_by_category_.clear(); |
| 106 | id_category_map_.clear(); |
| pke | 151b550 | 2016-08-09 12:15:13 | [diff] [blame] | 107 | for (const auto& category_provider_pair : providers_by_category_) { |
| treib | 7d1d7a5 | 2016-08-24 14:04:55 | [diff] [blame] | 108 | category_provider_pair.second->ClearCachedSuggestions( |
| pke | 151b550 | 2016-08-09 12:15:13 | [diff] [blame] | 109 | category_provider_pair.first); |
| pke | 222d8a5 | 2016-08-10 12:37:52 | [diff] [blame] | 110 | FOR_EACH_OBSERVER(Observer, observers_, |
| 111 | OnNewSuggestions(category_provider_pair.first)); |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 112 | } |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 113 | } |
| 114 | |
| treib | 7d1d7a5 | 2016-08-24 14:04:55 | [diff] [blame] | 115 | void ContentSuggestionsService::ClearCachedSuggestions( |
| pke | 151b550 | 2016-08-09 12:15:13 | [diff] [blame] | 116 | Category category) { |
| 117 | for (const ContentSuggestion& suggestion : |
| 118 | suggestions_by_category_[category]) { |
| 119 | id_category_map_.erase(suggestion.id()); |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 120 | } |
| pke | 151b550 | 2016-08-09 12:15:13 | [diff] [blame] | 121 | suggestions_by_category_[category].clear(); |
| 122 | auto iterator = providers_by_category_.find(category); |
| 123 | if (iterator != providers_by_category_.end()) |
| treib | 7d1d7a5 | 2016-08-24 14:04:55 | [diff] [blame] | 124 | iterator->second->ClearCachedSuggestions(category); |
| pke | 151b550 | 2016-08-09 12:15:13 | [diff] [blame] | 125 | } |
| 126 | |
| pke | de0dd9f | 2016-08-23 09:18:11 | [diff] [blame] | 127 | void ContentSuggestionsService::GetDismissedSuggestionsForDebugging( |
| 128 | Category category, |
| 129 | const DismissedSuggestionsCallback& callback) { |
| pke | 151b550 | 2016-08-09 12:15:13 | [diff] [blame] | 130 | auto iterator = providers_by_category_.find(category); |
| pke | de0dd9f | 2016-08-23 09:18:11 | [diff] [blame] | 131 | if (iterator != providers_by_category_.end()) |
| 132 | iterator->second->GetDismissedSuggestionsForDebugging(category, callback); |
| 133 | else |
| 134 | callback.Run(std::vector<ContentSuggestion>()); |
| pke | 151b550 | 2016-08-09 12:15:13 | [diff] [blame] | 135 | } |
| 136 | |
| 137 | void ContentSuggestionsService::ClearDismissedSuggestionsForDebugging( |
| 138 | Category category) { |
| 139 | auto iterator = providers_by_category_.find(category); |
| 140 | if (iterator != providers_by_category_.end()) |
| 141 | iterator->second->ClearDismissedSuggestionsForDebugging(category); |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 142 | } |
| 143 | |
| pke | 2646c95b | 2016-07-25 12:18:44 | [diff] [blame] | 144 | void ContentSuggestionsService::DismissSuggestion( |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 145 | const std::string& suggestion_id) { |
| 146 | if (!id_category_map_.count(suggestion_id)) { |
| pke | 2646c95b | 2016-07-25 12:18:44 | [diff] [blame] | 147 | LOG(WARNING) << "Dismissed unknown suggestion " << suggestion_id; |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 148 | return; |
| 149 | } |
| pke | 9c5095ac | 2016-08-01 13:53:12 | [diff] [blame] | 150 | Category category = id_category_map_.at(suggestion_id); |
| pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 151 | if (!providers_by_category_.count(category)) { |
| pke | 2646c95b | 2016-07-25 12:18:44 | [diff] [blame] | 152 | LOG(WARNING) << "Dismissed suggestion " << suggestion_id |
| pke | 31b0794 | 2016-08-01 11:35:02 | [diff] [blame] | 153 | << " for unavailable category " << category; |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 154 | return; |
| 155 | } |
| pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 156 | providers_by_category_[category]->DismissSuggestion(suggestion_id); |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 157 | |
| 158 | // Remove the suggestion locally. |
| pke | 2a48f85 | 2016-08-18 13:33:52 | [diff] [blame] | 159 | bool removed = RemoveSuggestionByID(category, suggestion_id); |
| 160 | DCHECK(removed) << "The dismissed suggestion " << suggestion_id |
| 161 | << " has already been removed. Providers must not call" |
| 162 | << " OnNewSuggestions in response to DismissSuggestion."; |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 163 | } |
| 164 | |
| dgn | 212feea3b | 2016-09-16 15:08:20 | [diff] [blame^] | 165 | void ContentSuggestionsService::DismissCategory(Category category) { |
| 166 | auto providers_it = providers_by_category_.find(category); |
| 167 | if (providers_it == providers_by_category_.end()) |
| 168 | return; |
| 169 | |
| 170 | providers_by_category_.erase(providers_it); |
| 171 | categories_.erase( |
| 172 | std::find(categories_.begin(), categories_.end(), category)); |
| 173 | } |
| 174 | |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 175 | void ContentSuggestionsService::AddObserver(Observer* observer) { |
| 176 | observers_.AddObserver(observer); |
| 177 | } |
| 178 | |
| 179 | void ContentSuggestionsService::RemoveObserver(Observer* observer) { |
| 180 | observers_.RemoveObserver(observer); |
| 181 | } |
| 182 | |
| 183 | void ContentSuggestionsService::RegisterProvider( |
| pke | 5728f08 | 2016-08-03 17:27:35 | [diff] [blame] | 184 | std::unique_ptr<ContentSuggestionsProvider> provider) { |
| 185 | DCHECK(state_ == State::ENABLED); |
| pke | 5728f08 | 2016-08-03 17:27:35 | [diff] [blame] | 186 | providers_.push_back(std::move(provider)); |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 187 | } |
| 188 | |
| 189 | //////////////////////////////////////////////////////////////////////////////// |
| 190 | // Private methods |
| 191 | |
| 192 | void ContentSuggestionsService::OnNewSuggestions( |
| pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 193 | ContentSuggestionsProvider* provider, |
| 194 | Category category, |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 195 | std::vector<ContentSuggestion> new_suggestions) { |
| pke | 3b2e363 | 2016-08-12 12:52:53 | [diff] [blame] | 196 | if (RegisterCategoryIfRequired(provider, category)) |
| pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 197 | NotifyCategoryStatusChanged(category); |
| pke | 3b2e363 | 2016-08-12 12:52:53 | [diff] [blame] | 198 | |
| 199 | if (!IsCategoryStatusAvailable(provider->GetCategoryStatus(category))) |
| 200 | return; |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 201 | |
| 202 | for (const ContentSuggestion& suggestion : |
| pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 203 | suggestions_by_category_[category]) { |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 204 | id_category_map_.erase(suggestion.id()); |
| 205 | } |
| 206 | |
| pke | 3b2e363 | 2016-08-12 12:52:53 | [diff] [blame] | 207 | for (const ContentSuggestion& suggestion : new_suggestions) |
| pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 208 | id_category_map_.insert(std::make_pair(suggestion.id(), category)); |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 209 | |
| pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 210 | suggestions_by_category_[category] = std::move(new_suggestions); |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 211 | |
| treib | 063e6a6 | 2016-08-25 11:34:29 | [diff] [blame] | 212 | // The positioning of the bookmarks category depends on whether it's empty. |
| 213 | // TODO(treib): Remove this temporary hack, crbug.com/640568. |
| 214 | if (category.IsKnownCategory(KnownCategories::BOOKMARKS)) |
| 215 | SortCategories(); |
| 216 | |
| pke | 222d8a5 | 2016-08-10 12:37:52 | [diff] [blame] | 217 | FOR_EACH_OBSERVER(Observer, observers_, OnNewSuggestions(category)); |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 218 | } |
| 219 | |
| 220 | void ContentSuggestionsService::OnCategoryStatusChanged( |
| pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 221 | ContentSuggestionsProvider* provider, |
| 222 | Category category, |
| pke | 9c5095ac | 2016-08-01 13:53:12 | [diff] [blame] | 223 | CategoryStatus new_status) { |
| 224 | if (!IsCategoryStatusAvailable(new_status)) { |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 225 | for (const ContentSuggestion& suggestion : |
| pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 226 | suggestions_by_category_[category]) { |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 227 | id_category_map_.erase(suggestion.id()); |
| 228 | } |
| pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 229 | suggestions_by_category_.erase(category); |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 230 | } |
| pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 231 | if (new_status == CategoryStatus::NOT_PROVIDED) { |
| dgn | 212feea3b | 2016-09-16 15:08:20 | [diff] [blame^] | 232 | DCHECK(providers_by_category_.find(category) != |
| 233 | providers_by_category_.end()); |
| 234 | DCHECK_EQ(provider, providers_by_category_.find(category)->second); |
| 235 | DismissCategory(category); |
| pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 236 | } else { |
| 237 | RegisterCategoryIfRequired(provider, category); |
| 238 | DCHECK_EQ(new_status, provider->GetCategoryStatus(category)); |
| 239 | } |
| 240 | NotifyCategoryStatusChanged(category); |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 241 | } |
| 242 | |
| pke | 2a48f85 | 2016-08-18 13:33:52 | [diff] [blame] | 243 | void ContentSuggestionsService::OnSuggestionInvalidated( |
| 244 | ContentSuggestionsProvider* provider, |
| 245 | Category category, |
| 246 | const std::string& suggestion_id) { |
| 247 | RemoveSuggestionByID(category, suggestion_id); |
| 248 | FOR_EACH_OBSERVER(Observer, observers_, |
| 249 | OnSuggestionInvalidated(category, suggestion_id)); |
| 250 | } |
| 251 | |
| vitaliii | 4594115 | 2016-09-05 08:58:13 | [diff] [blame] | 252 | // history::HistoryServiceObserver implementation. |
| 253 | void ContentSuggestionsService::OnURLsDeleted( |
| 254 | history::HistoryService* history_service, |
| 255 | bool all_history, |
| 256 | bool expired, |
| 257 | const history::URLRows& deleted_rows, |
| 258 | const std::set<GURL>& favicon_urls) { |
| 259 | // We don't care about expired entries. |
| 260 | if (expired) |
| 261 | return; |
| 262 | |
| 263 | // Redirect to ClearHistory(). |
| 264 | if (all_history) { |
| 265 | base::Time begin = base::Time(); |
| 266 | base::Time end = base::Time::Max(); |
| 267 | base::Callback<bool(const GURL& url)> filter = |
| 268 | base::Bind([](const GURL& url) { return true; }); |
| 269 | ClearHistory(begin, end, filter); |
| 270 | } else { |
| 271 | if (deleted_rows.empty()) |
| 272 | return; |
| 273 | |
| 274 | base::Time begin = deleted_rows[0].last_visit(); |
| 275 | base::Time end = deleted_rows[0].last_visit(); |
| 276 | std::set<GURL> deleted_urls; |
| 277 | for (const history::URLRow& row : deleted_rows) { |
| 278 | if (row.last_visit() < begin) |
| 279 | begin = row.last_visit(); |
| 280 | if (row.last_visit() > end) |
| 281 | end = row.last_visit(); |
| 282 | deleted_urls.insert(row.url()); |
| 283 | } |
| 284 | base::Callback<bool(const GURL& url)> filter = base::Bind( |
| 285 | [](const std::set<GURL>& set, const GURL& url) { |
| 286 | return set.count(url) != 0; |
| 287 | }, |
| 288 | deleted_urls); |
| 289 | ClearHistory(begin, end, filter); |
| 290 | } |
| 291 | } |
| 292 | |
| 293 | void ContentSuggestionsService::HistoryServiceBeingDeleted( |
| 294 | history::HistoryService* history_service) { |
| 295 | history_service_observer_.RemoveAll(); |
| 296 | } |
| 297 | |
| pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 298 | bool ContentSuggestionsService::RegisterCategoryIfRequired( |
| 299 | ContentSuggestionsProvider* provider, |
| 300 | Category category) { |
| 301 | auto it = providers_by_category_.find(category); |
| 302 | if (it != providers_by_category_.end()) { |
| 303 | DCHECK_EQ(it->second, provider); |
| 304 | return false; |
| 305 | } |
| 306 | |
| 307 | providers_by_category_[category] = provider; |
| 308 | categories_.push_back(category); |
| treib | 063e6a6 | 2016-08-25 11:34:29 | [diff] [blame] | 309 | SortCategories(); |
| pke | 4d3a4d6 | 2016-08-02 09:06:21 | [diff] [blame] | 310 | if (IsCategoryStatusAvailable(provider->GetCategoryStatus(category))) { |
| 311 | suggestions_by_category_.insert( |
| 312 | std::make_pair(category, std::vector<ContentSuggestion>())); |
| 313 | } |
| 314 | return true; |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 315 | } |
| 316 | |
| pke | 2a48f85 | 2016-08-18 13:33:52 | [diff] [blame] | 317 | bool ContentSuggestionsService::RemoveSuggestionByID( |
| 318 | Category category, |
| 319 | const std::string& suggestion_id) { |
| 320 | id_category_map_.erase(suggestion_id); |
| 321 | std::vector<ContentSuggestion>* suggestions = |
| 322 | &suggestions_by_category_[category]; |
| 323 | auto position = |
| 324 | std::find_if(suggestions->begin(), suggestions->end(), |
| 325 | [&suggestion_id](const ContentSuggestion& suggestion) { |
| 326 | return suggestion_id == suggestion.id(); |
| 327 | }); |
| 328 | if (position == suggestions->end()) |
| 329 | return false; |
| 330 | suggestions->erase(position); |
| treib | 063e6a6 | 2016-08-25 11:34:29 | [diff] [blame] | 331 | |
| 332 | // The positioning of the bookmarks category depends on whether it's empty. |
| 333 | // TODO(treib): Remove this temporary hack, crbug.com/640568. |
| 334 | if (category.IsKnownCategory(KnownCategories::BOOKMARKS)) |
| 335 | SortCategories(); |
| 336 | |
| pke | 2a48f85 | 2016-08-18 13:33:52 | [diff] [blame] | 337 | return true; |
| 338 | } |
| 339 | |
| pke | 9c5095ac | 2016-08-01 13:53:12 | [diff] [blame] | 340 | void ContentSuggestionsService::NotifyCategoryStatusChanged(Category category) { |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 341 | FOR_EACH_OBSERVER( |
| 342 | Observer, observers_, |
| 343 | OnCategoryStatusChanged(category, GetCategoryStatus(category))); |
| 344 | } |
| 345 | |
| treib | 063e6a6 | 2016-08-25 11:34:29 | [diff] [blame] | 346 | void ContentSuggestionsService::SortCategories() { |
| 347 | auto it = suggestions_by_category_.find( |
| 348 | category_factory_.FromKnownCategory(KnownCategories::BOOKMARKS)); |
| 349 | bool bookmarks_empty = |
| 350 | (it == suggestions_by_category_.end() || it->second.empty()); |
| 351 | std::sort( |
| 352 | categories_.begin(), categories_.end(), |
| 353 | [this, bookmarks_empty](const Category& left, const Category& right) { |
| 354 | // If the bookmarks section is empty, put it at the end. |
| 355 | // TODO(treib): This is a temporary hack, see crbug.com/640568. |
| 356 | if (bookmarks_empty) { |
| 357 | if (left.IsKnownCategory(KnownCategories::BOOKMARKS)) |
| 358 | return false; |
| 359 | if (right.IsKnownCategory(KnownCategories::BOOKMARKS)) |
| 360 | return true; |
| 361 | } |
| 362 | return category_factory_.CompareCategories(left, right); |
| 363 | }); |
| 364 | } |
| 365 | |
| pke | 6dbb90af | 2016-07-08 14:00:46 | [diff] [blame] | 366 | } // namespace ntp_snippets |