Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 1 | # Dynamic Feature Modules (DFMs) |
| 2 | |
| 3 | [Android App bundles and Dynamic Feature Modules (DFMs)](https://developer.android.com/guide/app-bundle) |
| 4 | is a Play Store feature that allows delivering pieces of an app when they are |
| 5 | needed rather than at install time. We use DFMs to modularize Chrome and make |
| 6 | Chrome's install size smaller. |
| 7 | |
| 8 | [TOC] |
| 9 | |
| 10 | |
| 11 | ## Limitations |
| 12 | |
Tibor Goldschwendt | 68c5f72 | 2019-08-01 15:10:15 | [diff] [blame] | 13 | DFMs have the following limitations: |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 14 | |
| 15 | * **WebView:** We don't support DFMs for WebView. If your feature is used by |
Tibor Goldschwendt | 68c5f72 | 2019-08-01 15:10:15 | [diff] [blame] | 16 | WebView you cannot put it into a DFM. |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 17 | * **Android K:** DFMs are based on split APKs, a feature introduced in Android |
| 18 | L. Therefore, we don't support DFMs on Android K. As a workaround |
Tibor Goldschwendt | 68c5f72 | 2019-08-01 15:10:15 | [diff] [blame] | 19 | you can add your feature to the Android K APK build. See below for details. |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 20 | |
| 21 | ## Getting started |
| 22 | |
| 23 | This guide walks you through the steps to create a DFM called _Foo_ and add it |
Tibor Goldschwendt | aef8e39 | 2019-07-19 16:39:10 | [diff] [blame] | 24 | to the Chrome bundles. |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 25 | |
| 26 | *** note |
| 27 | **Note:** To make your own module you'll essentially have to replace every |
| 28 | instance of `foo`/`Foo`/`FOO` with `your_feature_name`/`YourFeatureName`/ |
| 29 | `YOUR_FEATURE_NAME`. |
| 30 | *** |
| 31 | |
| 32 | |
| 33 | ### Create DFM target |
| 34 | |
| 35 | DFMs are APKs. They have a manifest and can contain Java and native code as well |
| 36 | as resources. This section walks you through creating the module target in our |
| 37 | build system. |
| 38 | |
Tibor Goldschwendt | 68c5f72 | 2019-08-01 15:10:15 | [diff] [blame] | 39 | First, create the file |
| 40 | `//chrome/android/features/foo/internal/java/AndroidManifest.xml` and add: |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 41 | |
| 42 | ```xml |
Tibor Goldschwendt | 68c5f72 | 2019-08-01 15:10:15 | [diff] [blame] | 43 | <?xml version="1.0" encoding="utf-8"?> |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 44 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 45 | xmlns:dist="http://schemas.android.com/apk/distribution" |
Tibor Goldschwendt | 5172118f | 2019-06-24 21:57:47 | [diff] [blame] | 46 | featureSplit="foo"> |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 47 | |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 48 | <!-- dist:onDemand="true" makes this a separately installed module. |
| 49 | dist:onDemand="false" would always install the module alongside the |
| 50 | rest of Chrome. --> |
| 51 | <dist:module |
| 52 | dist:onDemand="true" |
| 53 | dist:title="@string/foo_module_title"> |
Ben Mason | e571ea5a | 2019-09-06 18:29:37 | [diff] [blame] | 54 | <!-- This will fuse the module into the base APK if a system image |
| 55 | APK is built from this bundle. --> |
| 56 | <dist:fusing dist:include="true" /> |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 57 | </dist:module> |
| 58 | |
Samuel Huang | 39c7db63 | 2019-05-15 14:57:18 | [diff] [blame] | 59 | <!-- Remove android:hasCode="false" when adding Java code. --> |
| 60 | <application android:hasCode="false" /> |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 61 | </manifest> |
| 62 | ``` |
| 63 | |
Tibor Goldschwendt | aef8e39 | 2019-07-19 16:39:10 | [diff] [blame] | 64 | Next, create a descriptor configuring the Foo module. To do this, create |
| 65 | `//chrome/android/features/foo/foo_module.gni` and add the following: |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 66 | |
| 67 | ```gn |
Tibor Goldschwendt | aef8e39 | 2019-07-19 16:39:10 | [diff] [blame] | 68 | foo_module_desc = { |
| 69 | name = "foo" |
Tibor Goldschwendt | 68c5f72 | 2019-08-01 15:10:15 | [diff] [blame] | 70 | android_manifest = |
| 71 | "//chrome/android/features/foo/internal/java/AndroidManifest.xml" |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 72 | } |
| 73 | ``` |
| 74 | |
Tibor Goldschwendt | aef8e39 | 2019-07-19 16:39:10 | [diff] [blame] | 75 | Then, add the module descriptor to the appropriate descriptor list in |
| 76 | //chrome/android/modules/chrome_feature_modules.gni, e.g. the Chrome Modern |
| 77 | list: |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 78 | |
| 79 | ```gn |
Tibor Goldschwendt | aef8e39 | 2019-07-19 16:39:10 | [diff] [blame] | 80 | import("//chrome/android/features/foo/foo_module.gni") |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 81 | ... |
Tibor Goldschwendt | aef8e39 | 2019-07-19 16:39:10 | [diff] [blame] | 82 | chrome_modern_module_descs += [ foo_module_desc ] |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 83 | ``` |
| 84 | |
| 85 | The next step is to add Foo to the list of feature modules for UMA recording. |
| 86 | For this, add `foo` to the `AndroidFeatureModuleName` in |
| 87 | `//tools/metrics/histograms/histograms.xml`: |
| 88 | |
| 89 | ```xml |
| 90 | <histogram_suffixes name="AndroidFeatureModuleName" ...> |
| 91 | ... |
| 92 | <suffix name="foo" label="Super Duper Foo Module" /> |
| 93 | ... |
| 94 | </histogram_suffixes> |
| 95 | ``` |
| 96 | |
| 97 | <!--- TODO(tiborg): Add info about install UI. --> |
| 98 | Lastly, give your module a title that Chrome and Play can use for the install |
| 99 | UI. To do this, add a string to |
| 100 | `//chrome/android/java/strings/android_chrome_strings.grd`: |
| 101 | |
| 102 | ```xml |
| 103 | ... |
| 104 | <message name="IDS_FOO_MODULE_TITLE" |
| 105 | desc="Text shown when the Foo module is referenced in install start, success, |
| 106 | failure UI (e.g. in IDS_MODULE_INSTALL_START_TEXT, which will expand to |
| 107 | 'Installing Foo for Chrome…')."> |
| 108 | Foo |
| 109 | </message> |
| 110 | ... |
| 111 | ``` |
| 112 | |
Samuel Huang | 7f2b5375 | 2019-05-23 15:10:05 | [diff] [blame] | 113 | *** note |
| 114 | **Note:** This is for module title only. Other strings specific to the module |
| 115 | should go in the module, not here (in the base module). |
| 116 | *** |
| 117 | |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 118 | Congrats! You added the DFM Foo to Monochrome. That is a big step but not very |
| 119 | useful so far. In the next sections you'll learn how to add code and resources |
| 120 | to it. |
| 121 | |
| 122 | |
| 123 | ### Building and installing modules |
| 124 | |
| 125 | Before we are going to jump into adding content to Foo, let's take a look on how |
| 126 | to build and deploy the Monochrome bundle with the Foo DFM. The remainder of |
| 127 | this guide assumes the environment variable `OUTDIR` is set to a properly |
| 128 | configured GN build directory (e.g. `out/Debug`). |
| 129 | |
| 130 | To build and install the Monochrome bundle to your connected device, run: |
| 131 | |
| 132 | ```shell |
| 133 | $ autoninja -C $OUTDIR monochrome_public_bundle |
| 134 | $ $OUTDIR/bin/monochrome_public_bundle install -m base -m foo |
| 135 | ``` |
| 136 | |
| 137 | This will install Foo alongside the rest of Chrome. The rest of Chrome is called |
| 138 | _base_ module in the bundle world. The Base module will always be put on the |
| 139 | device when initially installing Chrome. |
| 140 | |
| 141 | *** note |
| 142 | **Note:** You have to specify `-m base` here to make it explicit which modules |
| 143 | will be installed. If you only specify `-m foo` the command will fail. It is |
| 144 | also possible to specify no modules. In that case, the script will install the |
| 145 | set of modules that the Play Store would install when first installing Chrome. |
| 146 | That may be different than just specifying `-m base` if we have non-on-demand |
| 147 | modules. |
| 148 | *** |
| 149 | |
| 150 | You can then check that the install worked with: |
| 151 | |
| 152 | ```shell |
| 153 | $ adb shell dumpsys package org.chromium.chrome | grep splits |
| 154 | > splits=[base, config.en, foo] |
| 155 | ``` |
| 156 | |
| 157 | Then try installing the Monochrome bundle without your module and print the |
| 158 | installed modules: |
| 159 | |
| 160 | ```shell |
| 161 | $ $OUTDIR/bin/monochrome_public_bundle install -m base |
| 162 | $ adb shell dumpsys package org.chromium.chrome | grep splits |
| 163 | > splits=[base, config.en] |
| 164 | ``` |
| 165 | |
| 166 | |
| 167 | ### Adding java code |
| 168 | |
| 169 | To make Foo useful, let's add some Java code to it. This section will walk you |
| 170 | through the required steps. |
| 171 | |
Tibor Goldschwendt | 573cf302 | 2019-05-10 17:23:30 | [diff] [blame] | 172 | First, define a module interface for Foo. This is accomplished by adding the |
| 173 | `@ModuleInterface` annotation to the Foo interface. This annotation |
| 174 | automatically creates a `FooModule` class that can be used later to install and |
| 175 | access the module. To do this, add the following in the new file |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 176 | `//chrome/android/features/foo/public/java/src/org/chromium/chrome/features/foo/Foo.java`: |
| 177 | |
| 178 | ```java |
| 179 | package org.chromium.chrome.features.foo; |
| 180 | |
Fred Mello | 2623e05 | 2019-10-02 20:18:04 | [diff] [blame^] | 181 | import org.chromium.components.module_installer.builder.ModuleInterface; |
Tibor Goldschwendt | 573cf302 | 2019-05-10 17:23:30 | [diff] [blame] | 182 | |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 183 | /** Interface to call into Foo feature. */ |
Tibor Goldschwendt | 573cf302 | 2019-05-10 17:23:30 | [diff] [blame] | 184 | @ModuleInterface(module = "foo", impl = "org.chromium.chrome.features.FooImpl") |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 185 | public interface Foo { |
| 186 | /** Magical function. */ |
| 187 | void bar(); |
| 188 | } |
| 189 | ``` |
| 190 | |
| 191 | *** note |
| 192 | **Note:** To reflect the separation from "Chrome browser" code, features should |
| 193 | be defined in their own package name, distinct from the chrome package - i.e. |
| 194 | `org.chromium.chrome.features.<feature-name>`. |
| 195 | *** |
| 196 | |
| 197 | Next, define an implementation that goes into the module in the new file |
Tibor Goldschwendt | 68c5f72 | 2019-08-01 15:10:15 | [diff] [blame] | 198 | `//chrome/android/features/foo/internal/java/src/org/chromium/chrome/features/foo/FooImpl.java`: |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 199 | |
| 200 | ```java |
| 201 | package org.chromium.chrome.features.foo; |
| 202 | |
| 203 | import org.chromium.base.Log; |
Tibor Goldschwendt | 573cf302 | 2019-05-10 17:23:30 | [diff] [blame] | 204 | import org.chromium.base.annotations.UsedByReflection; |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 205 | |
Tibor Goldschwendt | 573cf302 | 2019-05-10 17:23:30 | [diff] [blame] | 206 | @UsedByReflection("FooModule") |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 207 | public class FooImpl implements Foo { |
| 208 | @Override |
| 209 | public void bar() { |
| 210 | Log.i("FOO", "bar in module"); |
| 211 | } |
| 212 | } |
| 213 | ``` |
| 214 | |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 215 | You can then use this provider to access the module if it is installed. To test |
| 216 | that, instantiate Foo and call `bar()` somewhere in Chrome: |
| 217 | |
| 218 | ```java |
Tibor Goldschwendt | 573cf302 | 2019-05-10 17:23:30 | [diff] [blame] | 219 | if (FooModule.isInstalled()) { |
| 220 | FooModule.getImpl().bar(); |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 221 | } else { |
| 222 | Log.i("FOO", "module not installed"); |
| 223 | } |
| 224 | ``` |
| 225 | |
Tibor Goldschwendt | 573cf302 | 2019-05-10 17:23:30 | [diff] [blame] | 226 | The interface has to be available regardless of whether the Foo DFM is present. |
| 227 | Therefore, put those classes into the base module. For this create a list of |
| 228 | those Java files in |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 229 | `//chrome/android/features/foo/public/foo_public_java_sources.gni`: |
| 230 | |
| 231 | ```gn |
| 232 | foo_public_java_sources = [ |
| 233 | "//chrome/android/features/foo/public/java/src/org/chromium/chrome/features/foo/Foo.java", |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 234 | ] |
| 235 | ``` |
| 236 | |
| 237 | Then add this list to `chrome_java in //chrome/android/BUILD.gn`: |
| 238 | |
| 239 | ```gn |
| 240 | ... |
Tibor Goldschwendt | 68c5f72 | 2019-08-01 15:10:15 | [diff] [blame] | 241 | import("//chrome/android/features/foo/public/foo_public_java_sources.gni") |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 242 | ... |
| 243 | android_library("chrome_java") { |
| 244 | ... |
| 245 | java_files += foo_public_java_sources |
| 246 | } |
| 247 | ... |
| 248 | ``` |
| 249 | |
| 250 | The actual implementation, however, should go into the Foo DFM. For this |
Tibor Goldschwendt | 68c5f72 | 2019-08-01 15:10:15 | [diff] [blame] | 251 | purpose, create a new file `//chrome/android/features/foo/internal/BUILD.gn` and |
| 252 | make a library with the module Java code in it: |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 253 | |
| 254 | ```gn |
| 255 | import("//build/config/android/rules.gni") |
| 256 | |
| 257 | android_library("java") { |
| 258 | # Define like ordinary Java Android library. |
| 259 | java_files = [ |
| 260 | "java/src/org/chromium/chrome/features/foo/FooImpl.java", |
| 261 | # Add other Java classes that should go into the Foo DFM here. |
| 262 | ] |
| 263 | # Put other Chrome libs into the classpath so that you can call into the rest |
| 264 | # of Chrome from the Foo DFM. |
Fred Mello | b32b302 | 2019-06-21 18:10:11 | [diff] [blame] | 265 | deps = [ |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 266 | "//base:base_java", |
| 267 | "//chrome/android:chrome_java", |
| 268 | # etc. |
| 269 | # Also, you'll need to depend on any //third_party or //components code you |
| 270 | # are using in the module code. |
| 271 | ] |
| 272 | } |
| 273 | ``` |
| 274 | |
Tibor Goldschwendt | aef8e39 | 2019-07-19 16:39:10 | [diff] [blame] | 275 | Then, add this new library as a dependency of the Foo module descriptor in |
| 276 | `//chrome/android/features/foo/foo_module.gni`: |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 277 | |
| 278 | ```gn |
Tibor Goldschwendt | aef8e39 | 2019-07-19 16:39:10 | [diff] [blame] | 279 | foo_module_desc = { |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 280 | ... |
Tibor Goldschwendt | aef8e39 | 2019-07-19 16:39:10 | [diff] [blame] | 281 | java_deps = [ |
Tibor Goldschwendt | 68c5f72 | 2019-08-01 15:10:15 | [diff] [blame] | 282 | "//chrome/android/features/foo/internal:java", |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 283 | ] |
| 284 | } |
| 285 | ``` |
| 286 | |
| 287 | Finally, tell Android that your module is now containing code. Do that by |
Samuel Huang | 39c7db63 | 2019-05-15 14:57:18 | [diff] [blame] | 288 | removing the `android:hasCode="false"` attribute from the `<application>` tag in |
Tibor Goldschwendt | 68c5f72 | 2019-08-01 15:10:15 | [diff] [blame] | 289 | `//chrome/android/features/foo/internal/java/AndroidManifest.xml`. You should be |
| 290 | left with an empty tag like so: |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 291 | |
| 292 | ```xml |
| 293 | ... |
| 294 | <application /> |
| 295 | ... |
| 296 | ``` |
| 297 | |
| 298 | Rebuild and install `monochrome_public_bundle`. Start Chrome and run through a |
| 299 | flow that tries to executes `bar()`. Depending on whether you installed your |
| 300 | module (`-m foo`) "`bar in module`" or "`module not installed`" is printed to |
| 301 | logcat. Yay! |
| 302 | |
Christopher Grant | 8fea5a1 | 2019-07-31 19:12:31 | [diff] [blame] | 303 | ### Adding third-party native code |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 304 | |
Christopher Grant | 8fea5a1 | 2019-07-31 19:12:31 | [diff] [blame] | 305 | You can add a third-party native library (or any standalone library that doesn't |
| 306 | depend on Chrome code) by adding it as a loadable module to the module descriptor in |
| 307 | `//chrome/android/features/foo/foo_module.gni`: |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 308 | |
| 309 | ```gn |
Tibor Goldschwendt | aef8e39 | 2019-07-19 16:39:10 | [diff] [blame] | 310 | foo_module_desc = { |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 311 | ... |
Tibor Goldschwendt | aef8e39 | 2019-07-19 16:39:10 | [diff] [blame] | 312 | loadable_modules_32_bit = [ "//path/to/32/bit/lib.so" ] |
| 313 | loadable_modules_64_bit = [ "//path/to/64/bit/lib.so" ] |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 314 | } |
| 315 | ``` |
| 316 | |
Christopher Grant | 8fea5a1 | 2019-07-31 19:12:31 | [diff] [blame] | 317 | ### Adding Chrome native code |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 318 | |
Christopher Grant | 8fea5a1 | 2019-07-31 19:12:31 | [diff] [blame] | 319 | Chrome native code may be placed in a DFM. |
| 320 | |
| 321 | A linker-assisted partitioning system automates the placement of code into |
| 322 | either the main Chrome library or feature-specific .so libraries. Feature code |
| 323 | may continue to make use of core Chrome code (eg. base::) without modification, |
| 324 | but Chrome must call feature code through a virtual interface. |
| 325 | |
| 326 | Partitioning is explained in [Android Native |
| 327 | Libraries](android_native_libraries.md#partitioned-libraries). |
| 328 | |
| 329 | #### Creating an interface to feature code |
| 330 | |
| 331 | One way of creating an interface to a feature library is through an interface |
| 332 | definition. Feature Foo could define the following in |
| 333 | `//chrome/android/features/foo/public/foo_interface.h`: |
| 334 | |
| 335 | ```c++ |
| 336 | class FooInterface { |
| 337 | public: |
| 338 | virtual ~FooInterface() = default; |
| 339 | |
| 340 | virtual void ProcessInput(const std::string& input) = 0; |
| 341 | } |
| 342 | ``` |
| 343 | |
| 344 | Alongside the interface definition, also in |
| 345 | `//chrome/android/features/foo/public/foo_interface.h`, it's helpful to define a |
| 346 | factory function type that can be used to create a Foo instance: |
| 347 | |
| 348 | ```c++ |
| 349 | typedef FooInterface* CreateFooFunction(bool arg1, bool arg2); |
| 350 | ``` |
| 351 | |
| 352 | <!--- TODO(cjgrant): Add a full, pastable Foo implementation. --> |
| 353 | The feature library implements class Foo, hiding its implementation within the |
| 354 | library. The library may then expose a single entrypoint, a Foo factory |
| 355 | function. Here, C naming is (optionally) used so that the entrypoint symbol |
| 356 | isn't mangled. In `//chrome/android/features/foo/internal/foo.cc`: |
| 357 | |
| 358 | ```c++ |
| 359 | extern "C" { |
| 360 | // This symbol is retrieved from the Foo feature module library via dlsym(), |
| 361 | // where it's bare address is type-cast to its actual type and executed. |
| 362 | // The forward declaration here ensures that CreateFoo()'s signature is correct. |
| 363 | CreateFooFunction CreateFoo; |
| 364 | |
| 365 | __attribute__((visibility("default"))) FooInterface* CreateFoo( |
| 366 | bool arg1, bool arg2) { |
| 367 | return new Foo(arg1, arg2); |
| 368 | } |
| 369 | } // extern "C" |
| 370 | ``` |
| 371 | |
| 372 | Ideally, the interface to the feature will avoid feature-specific types. If a |
| 373 | feature defines complex data types, and uses them in its own interface, then its |
| 374 | likely the main library will utilize the code backing these types. That code, |
| 375 | and anything it references, will in turn be pulled back into the main library. |
| 376 | |
| 377 | Therefore, designing the feature inferface to use C types, C++ standard types, |
| 378 | or classes that aren't expected to move out of Chrome's main library is ideal. |
| 379 | If feature-specific classes are needed, they simply need to avoid referencing |
| 380 | feature library internals. |
| 381 | |
| 382 | *** note |
| 383 | **Note:** To help enforce separation between the feature interface and |
| 384 | implementation, the interface class is best placed in its own GN target, on |
| 385 | which the feature and main library code both depend. |
| 386 | *** |
| 387 | |
| 388 | #### Marking feature entrypoints |
| 389 | |
| 390 | Foo's feature module descriptor needs to pull in the appropriate native GN code |
| 391 | dependencies, and also indicate the name of the file that lists the entrypoint |
| 392 | symbols. In `//chrome/android/features/foo/foo_module.gni`: |
| 393 | |
| 394 | ```gn |
| 395 | foo_module_desc = { |
| 396 | ... |
| 397 | native_deps = [ "//chrome/android/features/foo/internal:foo" ] |
| 398 | native_entrypoints = "//chrome/android/features/foo/internal/module_entrypoints.lst" |
| 399 | } |
| 400 | ``` |
| 401 | |
| 402 | The module entrypoint file is a text file listing symbols. In this example, |
| 403 | `//chrome/android/features/foo/internal/module_entrypoints.lst` has only a |
| 404 | single factory function exposed: |
| 405 | |
| 406 | ```shell |
| 407 | # This file lists entrypoints exported from the Foo native feature library. |
| 408 | |
| 409 | CreateFoo |
| 410 | ``` |
| 411 | |
| 412 | These symbols will be pulled into a version script for the linker, indicating |
| 413 | that they should be exported in the dynamic symbol table of the feature library. |
| 414 | |
| 415 | *** note |
| 416 | **Note:** If C++ symbol names are chosen as entrypoints, the full mangled names |
| 417 | must be listed. |
| 418 | *** |
| 419 | |
| 420 | Additionally, it's necessary to map entrypoints to a particular partition. To |
| 421 | follow compiler/linker convention, this is done at the compiler stage. A cflag |
| 422 | is applied to source file(s) that may supply entrypoints (it's okay to apply the |
| 423 | flag to all feature source - the attribute is utilized only on modules that |
| 424 | export symbols). In `//chrome/android/features/foo/internal/BUILD.gn`: |
| 425 | |
| 426 | ```gn |
| 427 | static_library("foo") { |
| 428 | sources = [ |
| 429 | ... |
| 430 | ] |
| 431 | |
| 432 | # Mark symbols in this target as belonging to the Foo library partition. Only |
| 433 | # exported symbols (entrypoints) are affected, and only if this build supports |
| 434 | # native modules. |
| 435 | if (use_native_modules) { |
| 436 | cflags = [ "-fsymbol-partition=libfoo.so" ] |
| 437 | } |
| 438 | } |
| 439 | ``` |
| 440 | |
| 441 | Feature code is free to use any existing Chrome code (eg. logging, base::, |
| 442 | skia::, cc::, etc), as well as other feature targets. From a GN build config |
| 443 | perspective, the dependencies are defined as they normally would. The |
| 444 | partitioning operation works independently of GN's dependency tree. |
| 445 | |
| 446 | ```gn |
| 447 | static_library("foo") { |
| 448 | ... |
| 449 | |
| 450 | # It's fine to depend on base:: and other Chrome code. |
| 451 | deps = [ |
| 452 | "//base", |
| 453 | "//cc/animation", |
| 454 | ... |
| 455 | ] |
| 456 | |
| 457 | # Also fine to depend on other feature sub-targets. |
| 458 | deps += [ |
| 459 | ":some_other_foo_target" |
| 460 | ] |
| 461 | |
| 462 | # And fine to depend on the interface. |
| 463 | deps += [ |
| 464 | ":foo_interface" |
| 465 | ] |
| 466 | } |
| 467 | ``` |
| 468 | |
| 469 | #### Opening the feature library |
| 470 | |
| 471 | Now, code in the main library can open the feature library and create an |
| 472 | instance of feature Foo. Note that in this example, no care is taken to scope |
| 473 | the lifetime of the opened library. Depending on the feature, it may be |
| 474 | preferable to open and close the library as a feature is used. |
| 475 | `//chrome/android/features/foo/factory/foo_factory.cc` may contain this: |
| 476 | |
| 477 | ```c++ |
| 478 | std::unique_ptr<FooInterface> FooFactory(bool arg1, bool arg2) { |
| 479 | // Open the feature library, using the partition library helper to map it into |
| 480 | // the correct memory location. Specifying partition name *foo* will open |
| 481 | // libfoo.so. |
| 482 | void* foo_library_handle = |
| 483 | base::android::BundleUtils::DlOpenModuleLibraryPartition("foo"); |
| 484 | } |
| 485 | DCHECK(foo_library_handle != nullptr) << "Could not open foo library:" |
| 486 | << dlerror(); |
| 487 | |
| 488 | // Pull the Foo factory function out of the library. The function name isn't |
| 489 | // mangled because it was extern "C". |
| 490 | CreateFooFunction* create_foo = reinterpret_cast<CreateFooFunction*>( |
| 491 | dlsym(foo_library_handle, "CreateFoo")); |
| 492 | DCHECK(create_foo != nullptr); |
| 493 | |
| 494 | // Make and return a Foo! |
| 495 | return base::WrapUnique(create_foo(arg1, arg2)); |
| 496 | } |
| 497 | |
| 498 | ``` |
| 499 | |
| 500 | *** note |
| 501 | **Note:** Component builds do not support partitioned libraries (code splitting |
| 502 | happens across component boundaries instead). As such, an alternate, simplified |
| 503 | feature factory implementation must be supplied (either by linking in a |
| 504 | different factory source file, or using #defines in the factory) that simply |
| 505 | instantiates a Foo object directly. |
| 506 | *** |
| 507 | |
| 508 | Finally, the main library is free to utilize Foo: |
| 509 | |
| 510 | ```c++ |
| 511 | auto foo = FooFactory::Create(arg1, arg2); |
| 512 | foo->ProcessInput(const std::string& input); |
| 513 | ``` |
| 514 | |
Eric Stevenson | 8c9ab26b | 2019-08-30 15:44:40 | [diff] [blame] | 515 | #### JNI |
| 516 | |
| 517 | Read the `jni_generator` [docs](../base/android/jni_generator/README.md) before |
| 518 | reading this section. |
| 519 | |
| 520 | There are some subtleties to how JNI registration works with DFMs: |
| 521 | |
| 522 | * Generated wrapper `ClassNameJni` classes are packaged into the DFM's dex file |
| 523 | * The class containing the actual native definitions, `GEN_JNI.java`, is always |
| 524 | stored in the base module |
| 525 | * If the DFM is only included in bundles that use |
| 526 | [implicit JNI registration](android_native_libraries.md#JNI-Native-Methods-Resolution) |
| 527 | (i.e. Monochrome and newer), then no extra consideration is necessary |
| 528 | * Otherwise, the DFM will need to provide a `generate_jni_registration` target |
| 529 | that will generate all of the native registration functions |
| 530 | |
| 531 | |
Christopher Grant | 8fea5a1 | 2019-07-31 19:12:31 | [diff] [blame] | 532 | ### Adding Android resources |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 533 | |
| 534 | In this section we will add the required build targets to add Android resources |
| 535 | to the Foo DFM. |
| 536 | |
Tibor Goldschwendt | 68c5f72 | 2019-08-01 15:10:15 | [diff] [blame] | 537 | First, add a resources target to |
| 538 | `//chrome/android/features/foo/internal/BUILD.gn` and add it as a dependency on |
| 539 | Foo's `java` target in the same file: |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 540 | |
| 541 | ```gn |
| 542 | ... |
| 543 | android_resources("java_resources") { |
| 544 | # Define like ordinary Android resources target. |
| 545 | ... |
| 546 | custom_package = "org.chromium.chrome.features.foo" |
| 547 | } |
| 548 | ... |
| 549 | android_library("java") { |
| 550 | ... |
| 551 | deps = [ |
| 552 | ":java_resources", |
| 553 | ] |
| 554 | } |
| 555 | ``` |
| 556 | |
| 557 | To add strings follow steps |
| 558 | [here](http://dev.chromium.org/developers/design-documents/ui-localization) to |
| 559 | add new Java GRD file. Then create |
Tibor Goldschwendt | 68c5f72 | 2019-08-01 15:10:15 | [diff] [blame] | 560 | `//chrome/android/features/foo/internal/java/strings/android_foo_strings.grd` as |
| 561 | follows: |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 562 | |
| 563 | ```xml |
| 564 | <?xml version="1.0" encoding="UTF-8"?> |
| 565 | <grit |
| 566 | current_release="1" |
| 567 | latest_public_release="0" |
| 568 | output_all_resource_defines="false"> |
| 569 | <outputs> |
| 570 | <output |
| 571 | filename="values-am/android_foo_strings.xml" |
| 572 | lang="am" |
| 573 | type="android" /> |
| 574 | <!-- List output file for all other supported languages. See |
| 575 | //chrome/android/java/strings/android_chrome_strings.grd for the full |
| 576 | list. --> |
| 577 | ... |
| 578 | </outputs> |
| 579 | <translations> |
| 580 | <file lang="am" path="vr_translations/android_foo_strings_am.xtb" /> |
| 581 | <!-- Here, too, list XTB files for all other supported languages. --> |
| 582 | ... |
| 583 | </translations> |
| 584 | <release allow_pseudo="false" seq="1"> |
| 585 | <messages fallback_to_english="true"> |
| 586 | <message name="IDS_BAR_IMPL_TEXT" desc="Magical string."> |
| 587 | impl |
| 588 | </message> |
| 589 | </messages> |
| 590 | </release> |
| 591 | </grit> |
| 592 | ``` |
| 593 | |
| 594 | Then, create a new GRD target and add it as a dependency on `java_resources` in |
Tibor Goldschwendt | 68c5f72 | 2019-08-01 15:10:15 | [diff] [blame] | 595 | `//chrome/android/features/foo/internal/BUILD.gn`: |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 596 | |
| 597 | ```gn |
| 598 | ... |
| 599 | java_strings_grd("java_strings_grd") { |
| 600 | defines = chrome_grit_defines |
| 601 | grd_file = "java/strings/android_foo_strings.grd" |
| 602 | outputs = [ |
| 603 | "values-am/android_foo_strings.xml", |
| 604 | # Here, too, list output files for other supported languages. |
| 605 | ... |
| 606 | ] |
| 607 | } |
| 608 | ... |
| 609 | android_resources("java_resources") { |
| 610 | ... |
| 611 | deps = [":java_strings_grd"] |
| 612 | custom_package = "org.chromium.chrome.features.foo" |
| 613 | } |
| 614 | ... |
| 615 | ``` |
| 616 | |
| 617 | You can then access Foo's resources using the |
| 618 | `org.chromium.chrome.features.foo.R` class. To do this change |
Tibor Goldschwendt | 68c5f72 | 2019-08-01 15:10:15 | [diff] [blame] | 619 | `//chrome/android/features/foo/internal/java/src/org/chromium/chrome/features/foo/FooImpl.java` |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 620 | to: |
| 621 | |
| 622 | ```java |
| 623 | package org.chromium.chrome.features.foo; |
| 624 | |
| 625 | import org.chromium.base.ContextUtils; |
| 626 | import org.chromium.base.Log; |
Tibor Goldschwendt | 573cf302 | 2019-05-10 17:23:30 | [diff] [blame] | 627 | import org.chromium.base.annotations.UsedByReflection; |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 628 | import org.chromium.chrome.features.foo.R; |
| 629 | |
Tibor Goldschwendt | 573cf302 | 2019-05-10 17:23:30 | [diff] [blame] | 630 | @UsedByReflection("FooModule") |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 631 | public class FooImpl implements Foo { |
| 632 | @Override |
| 633 | public void bar() { |
| 634 | Log.i("FOO", ContextUtils.getApplicationContext().getString( |
| 635 | R.string.bar_impl_text)); |
| 636 | } |
| 637 | } |
| 638 | ``` |
| 639 | |
| 640 | *** note |
| 641 | **Warning:** While your module is emulated (see [below](#on-demand-install)) |
| 642 | your resources are only available through |
| 643 | `ContextUtils.getApplicationContext()`. Not through activities, etc. We |
| 644 | therefore recommend that you only access DFM resources this way. See |
| 645 | [crbug/949729](https://bugs.chromium.org/p/chromium/issues/detail?id=949729) |
| 646 | for progress on making this more robust. |
| 647 | *** |
| 648 | |
| 649 | |
| 650 | ### Module install |
| 651 | |
| 652 | So far, we have installed the Foo DFM as a true split (`-m foo` option on the |
| 653 | install script). In production, however, we have to explicitly install the Foo |
Tibor Goldschwendt | 68c5f72 | 2019-08-01 15:10:15 | [diff] [blame] | 654 | DFM for users to get it. There are three install options: _on-demand_, |
| 655 | _deferred_ and _conditional_. |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 656 | |
| 657 | |
| 658 | #### On-demand install |
| 659 | |
| 660 | On-demand requesting a module will try to download and install the |
| 661 | module as soon as possible regardless of whether the user is on a metered |
| 662 | connection or whether they have turned updates off in the Play Store app. |
| 663 | |
Tibor Goldschwendt | 573cf302 | 2019-05-10 17:23:30 | [diff] [blame] | 664 | You can use the autogenerated module class to on-demand install the module like |
| 665 | so: |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 666 | |
| 667 | ```java |
Tibor Goldschwendt | 573cf302 | 2019-05-10 17:23:30 | [diff] [blame] | 668 | FooModule.install((success) -> { |
| 669 | if (success) { |
| 670 | FooModule.getImpl().bar(); |
| 671 | } |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 672 | }); |
| 673 | ``` |
| 674 | |
| 675 | **Optionally**, you can show UI telling the user about the install flow. For |
Tibor Goldschwendt | 573cf302 | 2019-05-10 17:23:30 | [diff] [blame] | 676 | this, add a function like the one below. Note, it is possible |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 677 | to only show either one of the install, failure and success UI or any |
| 678 | combination of the three. |
| 679 | |
| 680 | ```java |
| 681 | public static void installModuleWithUi( |
| 682 | Tab tab, OnModuleInstallFinishedListener onFinishedListener) { |
| 683 | ModuleInstallUi ui = |
| 684 | new ModuleInstallUi( |
| 685 | tab, |
| 686 | R.string.foo_module_title, |
| 687 | new ModuleInstallUi.FailureUiListener() { |
| 688 | @Override |
Samuel Huang | febcccd | 2019-08-21 20:48:47 | [diff] [blame] | 689 | public void onFailureUiResponse(retry) { |
| 690 | if (retry) { |
| 691 | installModuleWithUi(tab, onFinishedListener); |
| 692 | } else { |
| 693 | onFinishedListener.onFinished(false); |
| 694 | } |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 695 | } |
| 696 | }); |
| 697 | // At the time of writing, shows toast informing user about install start. |
| 698 | ui.showInstallStartUi(); |
Tibor Goldschwendt | 573cf302 | 2019-05-10 17:23:30 | [diff] [blame] | 699 | FooModule.install( |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 700 | (success) -> { |
| 701 | if (!success) { |
| 702 | // At the time of writing, shows infobar allowing user |
| 703 | // to retry install. |
| 704 | ui.showInstallFailureUi(); |
| 705 | return; |
| 706 | } |
| 707 | // At the time of writing, shows toast informing user about |
| 708 | // install success. |
| 709 | ui.showInstallSuccessUi(); |
| 710 | onFinishedListener.onFinished(true); |
| 711 | }); |
| 712 | } |
| 713 | ``` |
| 714 | |
| 715 | To test on-demand install, "fake-install" the DFM. It's fake because |
| 716 | the DFM is not installed as a true split. Instead it will be emulated by Chrome. |
| 717 | Fake-install and launch Chrome with the following command: |
| 718 | |
| 719 | ```shell |
| 720 | $ $OUTDIR/bin/monochrome_public_bundle install -m base -f foo |
Samuel Huang | 39c7db63 | 2019-05-15 14:57:18 | [diff] [blame] | 721 | $ $OUTDIR/bin/monochrome_public_bundle launch --args="--fake-feature-module-install" |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 722 | ``` |
| 723 | |
| 724 | When running the install code, the Foo DFM module will be emulated. |
| 725 | This will be the case in production right after installing the module. Emulation |
| 726 | will last until Play Store has a chance to install your module as a true split. |
| 727 | This usually takes about a day. |
| 728 | |
| 729 | *** note |
| 730 | **Warning:** There are subtle differences between emulating a module and |
| 731 | installing it as a true split. We therefore recommend that you always test both |
| 732 | install methods. |
| 733 | *** |
| 734 | |
| 735 | |
| 736 | #### Deferred install |
| 737 | |
| 738 | Deferred install means that the DFM is installed in the background when the |
| 739 | device is on an unmetered connection and charging. The DFM will only be |
| 740 | available after Chrome restarts. When deferred installing a module it will |
| 741 | not be faked installed. |
| 742 | |
| 743 | To defer install Foo do the following: |
| 744 | |
| 745 | ```java |
Tibor Goldschwendt | 573cf302 | 2019-05-10 17:23:30 | [diff] [blame] | 746 | FooModule.installDeferred(); |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 747 | ``` |
| 748 | |
Tibor Goldschwendt | 68c5f72 | 2019-08-01 15:10:15 | [diff] [blame] | 749 | #### Conditional install |
| 750 | |
| 751 | Conditional install means the DFM will be installed automatically upon first |
| 752 | installing or updating Chrome if the device supports a particular feature. |
| 753 | Conditional install is configured in the module's manifest. To install your |
| 754 | module on all Daydream-ready devices for instance, your |
| 755 | `//chrome/android/features/foo/internal/java/AndroidManifest.xml` should look |
| 756 | like this: |
| 757 | |
| 758 | ```xml |
| 759 | <?xml version="1.0" encoding="utf-8"?> |
| 760 | <manifest xmlns:android="http://schemas.android.com/apk/res/android" |
| 761 | xmlns:dist="http://schemas.android.com/apk/distribution" |
| 762 | featureSplit="foo"> |
| 763 | |
| 764 | <dist:module |
| 765 | dist:instant="false" |
| 766 | dist:title="@string/foo_module_title"> |
Ben Mason | e571ea5a | 2019-09-06 18:29:37 | [diff] [blame] | 767 | <dist:fusing dist:include="true" /> |
Tibor Goldschwendt | 68c5f72 | 2019-08-01 15:10:15 | [diff] [blame] | 768 | <dist:delivery> |
| 769 | <dist:install-time> |
| 770 | <dist:conditions> |
| 771 | <dist:device-feature |
| 772 | dist:name="android.hardware.vr.high_performance" /> |
| 773 | </dist:conditions> |
| 774 | </dist:install-time> |
| 775 | <!-- Allows on-demand or deferred install on non-Daydream-ready |
| 776 | devices. --> |
| 777 | <dist:on-demand /> |
| 778 | </dist:delivery> |
| 779 | </dist:module> |
| 780 | |
| 781 | <application /> |
| 782 | </manifest> |
| 783 | ``` |
| 784 | |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 785 | |
| 786 | ### Integration test APK and Android K support |
| 787 | |
| 788 | On Android K we still ship an APK. To make the Foo feature available on Android |
| 789 | K add its code to the APK build. For this, add the `java` target to |
| 790 | the `chrome_public_common_apk_or_module_tmpl` in |
| 791 | `//chrome/android/chrome_public_apk_tmpl.gni` like so: |
| 792 | |
| 793 | ```gn |
| 794 | template("chrome_public_common_apk_or_module_tmpl") { |
| 795 | ... |
| 796 | target(_target_type, target_name) { |
| 797 | ... |
| 798 | if (_target_type != "android_app_bundle_module") { |
| 799 | deps += [ |
Tibor Goldschwendt | 68c5f72 | 2019-08-01 15:10:15 | [diff] [blame] | 800 | "//chrome/android/features/foo/internal:java", |
Tibor Goldschwendt | 19364ba | 2019-04-10 15:59:55 | [diff] [blame] | 801 | ] |
| 802 | } |
| 803 | } |
| 804 | } |
| 805 | ``` |
| 806 | |
| 807 | This will also add Foo's Java to the integration test APK. You may also have to |
| 808 | add `java` as a dependency of `chrome_test_java` if you want to call into Foo |
| 809 | from test code. |