blob: 07c7f24d37b3c9bc8fd419c3c457c16f1c93bb49 [file] [log] [blame]
[email protected]cb155a82011-11-29 17:25:341#!/usr/bin/env python
[email protected]08079092012-01-05 18:24:382# Copyright (c) 2012 The Chromium Authors. All rights reserved.
[email protected]377bf4a2011-05-19 20:17:113# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
[email protected]50e5a3d2010-08-26 00:23:265
6"""Given a filename as an argument, sort the #include/#imports in that file.
7
8Shows a diff and prompts for confirmation before doing the deed.
[email protected]10ab0ed52011-11-01 11:46:529Works great with tools/git/for-all-touched-files.py.
[email protected]50e5a3d2010-08-26 00:23:2610"""
11
12import optparse
13import os
14import sys
[email protected]50e5a3d2010-08-26 00:23:2615
[email protected]cb155a82011-11-29 17:25:3416
[email protected]50e5a3d2010-08-26 00:23:2617def YesNo(prompt):
18 """Prompts with a yes/no question, returns True if yes."""
19 print prompt,
20 sys.stdout.flush()
21 # http://code.activestate.com/recipes/134892/
[email protected]4a2a50cb2013-06-04 06:27:3822 if sys.platform == 'win32':
23 import msvcrt
24 ch = msvcrt.getch()
25 else:
26 import termios
27 import tty
28 fd = sys.stdin.fileno()
29 old_settings = termios.tcgetattr(fd)
30 ch = 'n'
31 try:
32 tty.setraw(sys.stdin.fileno())
33 ch = sys.stdin.read(1)
34 finally:
35 termios.tcsetattr(fd, termios.TCSADRAIN, old_settings)
[email protected]50e5a3d2010-08-26 00:23:2636 print ch
37 return ch in ('Y', 'y')
38
39
40def IncludeCompareKey(line):
41 """Sorting comparator key used for comparing two #include lines.
[email protected]5650b4a42014-04-09 00:52:1542 Returns the filename without the #include/#import/import prefix.
[email protected]50e5a3d2010-08-26 00:23:2643 """
[email protected]5650b4a42014-04-09 00:52:1544 for prefix in ('#include ', '#import ', 'import '):
[email protected]50e5a3d2010-08-26 00:23:2645 if line.startswith(prefix):
[email protected]d5c49322011-05-19 20:08:5746 line = line[len(prefix):]
47 break
[email protected]51e3da52011-05-20 01:53:0648
49 # The win32 api has all sorts of implicit include order dependencies :-/
50 # Give a few headers special sort keys that make sure they appear before all
51 # other headers.
52 if line.startswith('<windows.h>'): # Must be before e.g. shellapi.h
53 return '0'
[email protected]d5d71052013-02-25 21:01:3554 if line.startswith('<atlbase.h>'): # Must be before atlapp.h.
55 return '1' + line
[email protected]51e3da52011-05-20 01:53:0656 if line.startswith('<unknwn.h>'): # Must be before e.g. intshcut.h
[email protected]d5d71052013-02-25 21:01:3557 return '1' + line
[email protected]51e3da52011-05-20 01:53:0658
[email protected]08079092012-01-05 18:24:3859 # C++ system headers should come after C system headers.
60 if line.startswith('<'):
61 if line.find('.h>') != -1:
[email protected]2661bb92013-03-13 21:24:4062 return '2' + line.lower()
[email protected]08079092012-01-05 18:24:3863 else:
[email protected]2661bb92013-03-13 21:24:4064 return '3' + line.lower()
[email protected]08079092012-01-05 18:24:3865
66 return '4' + line
[email protected]50e5a3d2010-08-26 00:23:2667
68
69def IsInclude(line):
[email protected]5650b4a42014-04-09 00:52:1570 """Returns True if the line is an #include/#import/import line."""
71 return any([line.startswith('#include '), line.startswith('#import '),
72 line.startswith('import ')])
[email protected]50e5a3d2010-08-26 00:23:2673
74
75def SortHeader(infile, outfile):
76 """Sorts the headers in infile, writing the sorted file to outfile."""
77 for line in infile:
78 if IsInclude(line):
79 headerblock = []
80 while IsInclude(line):
[email protected]1590a8e2013-06-18 14:25:5881 infile_ended_on_include_line = False
[email protected]50e5a3d2010-08-26 00:23:2682 headerblock.append(line)
[email protected]1590a8e2013-06-18 14:25:5883 # Ensure we don't die due to trying to read beyond the end of the file.
84 try:
85 line = infile.next()
86 except StopIteration:
87 infile_ended_on_include_line = True
88 break
[email protected]50e5a3d2010-08-26 00:23:2689 for header in sorted(headerblock, key=IncludeCompareKey):
90 outfile.write(header)
[email protected]1590a8e2013-06-18 14:25:5891 if infile_ended_on_include_line:
92 # We already wrote the last line above; exit to ensure it isn't written
93 # again.
94 return
[email protected]50e5a3d2010-08-26 00:23:2695 # Intentionally fall through, to write the line that caused
96 # the above while loop to exit.
97 outfile.write(line)
98
99
[email protected]1590a8e2013-06-18 14:25:58100def FixFileWithConfirmFunction(filename, confirm_function,
101 perform_safety_checks):
[email protected]18367222012-11-22 11:28:57102 """Creates a fixed version of the file, invokes |confirm_function|
103 to decide whether to use the new file, and cleans up.
104
105 |confirm_function| takes two parameters, the original filename and
106 the fixed-up filename, and returns True to use the fixed-up file,
107 false to not use it.
[email protected]1590a8e2013-06-18 14:25:58108
109 If |perform_safety_checks| is True, then the function checks whether it is
110 unsafe to reorder headers in this file and skips the reorder with a warning
111 message in that case.
[email protected]10ab0ed52011-11-01 11:46:52112 """
[email protected]1590a8e2013-06-18 14:25:58113 if perform_safety_checks and IsUnsafeToReorderHeaders(filename):
114 print ('Not reordering headers in %s as the script thinks that the '
115 'order of headers in this file is semantically significant.'
116 % (filename))
117 return
[email protected]10ab0ed52011-11-01 11:46:52118 fixfilename = filename + '.new'
[email protected]4a2a50cb2013-06-04 06:27:38119 infile = open(filename, 'rb')
120 outfile = open(fixfilename, 'wb')
[email protected]10ab0ed52011-11-01 11:46:52121 SortHeader(infile, outfile)
122 infile.close()
123 outfile.close() # Important so the below diff gets the updated contents.
124
125 try:
[email protected]18367222012-11-22 11:28:57126 if confirm_function(filename, fixfilename):
[email protected]4a2a50cb2013-06-04 06:27:38127 if sys.platform == 'win32':
128 os.unlink(filename)
[email protected]10ab0ed52011-11-01 11:46:52129 os.rename(fixfilename, filename)
130 finally:
131 try:
132 os.remove(fixfilename)
133 except OSError:
134 # If the file isn't there, we don't care.
135 pass
136
137
[email protected]1590a8e2013-06-18 14:25:58138def DiffAndConfirm(filename, should_confirm, perform_safety_checks):
[email protected]18367222012-11-22 11:28:57139 """Shows a diff of what the tool would change the file named
140 filename to. Shows a confirmation prompt if should_confirm is true.
141 Saves the resulting file if should_confirm is false or the user
142 answers Y to the confirmation prompt.
143 """
144 def ConfirmFunction(filename, fixfilename):
145 diff = os.system('diff -u %s %s' % (filename, fixfilename))
[email protected]4a2a50cb2013-06-04 06:27:38146 if sys.platform != 'win32':
147 diff >>= 8
148 if diff == 0: # Check exit code.
[email protected]18367222012-11-22 11:28:57149 print '%s: no change' % filename
150 return False
151
152 return (not should_confirm or YesNo('Use new file (y/N)?'))
153
[email protected]1590a8e2013-06-18 14:25:58154 FixFileWithConfirmFunction(filename, ConfirmFunction, perform_safety_checks)
[email protected]18367222012-11-22 11:28:57155
[email protected]1590a8e2013-06-18 14:25:58156def IsUnsafeToReorderHeaders(filename):
157 # *_message_generator.cc is almost certainly a file that generates IPC
158 # definitions. Changes in include order in these files can result in them not
159 # building correctly.
160 if filename.find("message_generator.cc") != -1:
161 return True
162 return False
[email protected]18367222012-11-22 11:28:57163
[email protected]50e5a3d2010-08-26 00:23:26164def main():
165 parser = optparse.OptionParser(usage='%prog filename1 filename2 ...')
[email protected]10ab0ed52011-11-01 11:46:52166 parser.add_option('-f', '--force', action='store_false', default=True,
167 dest='should_confirm',
168 help='Turn off confirmation prompt.')
[email protected]1590a8e2013-06-18 14:25:58169 parser.add_option('--no_safety_checks',
170 action='store_false', default=True,
171 dest='perform_safety_checks',
172 help='Do not perform the safety checks via which this '
173 'script refuses to operate on files for which it thinks '
174 'the include ordering is semantically significant.')
[email protected]10ab0ed52011-11-01 11:46:52175 opts, filenames = parser.parse_args()
[email protected]50e5a3d2010-08-26 00:23:26176
[email protected]10ab0ed52011-11-01 11:46:52177 if len(filenames) < 1:
[email protected]50e5a3d2010-08-26 00:23:26178 parser.print_help()
[email protected]cb155a82011-11-29 17:25:34179 return 1
[email protected]50e5a3d2010-08-26 00:23:26180
[email protected]10ab0ed52011-11-01 11:46:52181 for filename in filenames:
[email protected]1590a8e2013-06-18 14:25:58182 DiffAndConfirm(filename, opts.should_confirm, opts.perform_safety_checks)
[email protected]50e5a3d2010-08-26 00:23:26183
184
185if __name__ == '__main__':
[email protected]cb155a82011-11-29 17:25:34186 sys.exit(main())