Avi Drissman | 8ba1bad | 2022-09-13 19:22:36 | [diff] [blame^] | 1 | // Copyright 2017 The Chromium Authors |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
| 5 | #include "components/metrics/field_trials_provider.h" |
| 6 | |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 7 | #include "base/metrics/field_trial.h" |
Kevin McNee | 5e754b1 | 2021-08-18 21:59:30 | [diff] [blame] | 8 | #include "base/threading/platform_thread.h" |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 9 | #include "components/variations/active_field_trials.h" |
| 10 | #include "components/variations/synthetic_trial_registry.h" |
Luc Nguyen | 69147e0 | 2022-01-24 20:32:10 | [diff] [blame] | 11 | #include "components/variations/synthetic_trials.h" |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 12 | #include "testing/gtest/include/gtest/gtest.h" |
Steven Holte | f9d5ed6 | 2017-10-21 02:02:30 | [diff] [blame] | 13 | #include "third_party/metrics_proto/system_profile.pb.h" |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 14 | |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 15 | using ActiveGroup = base::FieldTrial::ActiveGroup; |
| 16 | |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 17 | namespace variations { |
| 18 | |
| 19 | namespace { |
| 20 | |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 21 | constexpr const char* kSuffix = "UKM"; |
| 22 | |
| 23 | const ActiveGroup kFieldTrials[] = {{"Trial1", "Group1"}, |
| 24 | {"Trial2", "Group2"}, |
| 25 | {"Trial3", "Group3"}}; |
| 26 | const ActiveGroup kSyntheticFieldTrials[] = {{"Synthetic1", "SyntheticGroup1"}, |
| 27 | {"Synthetic2", "SyntheticGroup2"}}; |
| 28 | |
| 29 | ActiveGroupId ToActiveGroupId(ActiveGroup active_group, |
| 30 | std::string suffix = ""); |
| 31 | |
| 32 | const ActiveGroupId kFieldTrialIds[] = {ToActiveGroupId(kFieldTrials[0]), |
| 33 | ToActiveGroupId(kFieldTrials[1]), |
| 34 | ToActiveGroupId(kFieldTrials[2])}; |
Luc Nguyen | 75a8bb2ee | 2022-05-04 20:53:55 | [diff] [blame] | 35 | const ActiveGroupId kAllTrialIds[] = { |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 36 | ToActiveGroupId(kFieldTrials[0]), ToActiveGroupId(kFieldTrials[1]), |
| 37 | ToActiveGroupId(kFieldTrials[2]), ToActiveGroupId(kSyntheticFieldTrials[0]), |
| 38 | ToActiveGroupId(kSyntheticFieldTrials[1])}; |
| 39 | const ActiveGroupId kAllTrialIdsWithSuffixes[] = { |
| 40 | ToActiveGroupId(kFieldTrials[0], kSuffix), |
| 41 | ToActiveGroupId(kFieldTrials[1], kSuffix), |
| 42 | ToActiveGroupId(kFieldTrials[2], kSuffix), |
| 43 | ToActiveGroupId(kSyntheticFieldTrials[0], kSuffix), |
| 44 | ToActiveGroupId(kSyntheticFieldTrials[1], kSuffix)}; |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 45 | |
Caitlin Fischer | d0cd0b9 | 2020-06-03 12:10:48 | [diff] [blame] | 46 | // Check that the field trials in |system_profile| correspond to |expected|. |
Xi Han | 095f3934 | 2019-08-08 20:00:54 | [diff] [blame] | 47 | void CheckFieldTrialsInSystemProfile( |
Caitlin Fischer | d0cd0b9 | 2020-06-03 12:10:48 | [diff] [blame] | 48 | const metrics::SystemProfileProto& system_profile, |
| 49 | const ActiveGroupId* expected) { |
| 50 | for (int i = 0; i < system_profile.field_trial_size(); ++i) { |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 51 | const metrics::SystemProfileProto::FieldTrial& field_trial = |
| 52 | system_profile.field_trial(i); |
Caitlin Fischer | d0cd0b9 | 2020-06-03 12:10:48 | [diff] [blame] | 53 | EXPECT_EQ(expected[i].name, field_trial.name_id()); |
| 54 | EXPECT_EQ(expected[i].group, field_trial.group_id()); |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 55 | } |
| 56 | } |
| 57 | |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 58 | ActiveGroupId ToActiveGroupId(ActiveGroup active_group, std::string suffix) { |
| 59 | return MakeActiveGroupId(active_group.trial_name + suffix, |
| 60 | active_group.group_name + suffix); |
| 61 | } |
| 62 | |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 63 | } // namespace |
| 64 | |
| 65 | class FieldTrialsProviderTest : public ::testing::Test { |
| 66 | public: |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 67 | FieldTrialsProviderTest() = default; |
| 68 | ~FieldTrialsProviderTest() override = default; |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 69 | |
| 70 | protected: |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 71 | void SetUp() override { |
| 72 | // Register the field trials. |
| 73 | for (const ActiveGroup& trial : kFieldTrials) { |
| 74 | base::FieldTrial* field_trial = base::FieldTrialList::CreateFieldTrial( |
| 75 | trial.trial_name, trial.group_name); |
Steven Holte | f155160 | 2022-09-03 06:38:38 | [diff] [blame] | 76 | // Call Activate() to finalize and mark the field trial as active. |
| 77 | field_trial->Activate(); |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 78 | } |
| 79 | } |
| 80 | |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 81 | // Register trials which should get recorded. |
| 82 | void RegisterExpectedSyntheticTrials() { |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 83 | for (const ActiveGroup& trial : kSyntheticFieldTrials) { |
| 84 | registry_.RegisterSyntheticFieldTrial(SyntheticTrialGroup( |
| 85 | trial.trial_name, trial.group_name, |
| 86 | /*annotation_mode=*/ |
| 87 | variations::SyntheticTrialAnnotationMode::kNextLog)); |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 88 | } |
| 89 | } |
| 90 | // Register trial which shouldn't get recorded. |
| 91 | void RegisterExtraSyntheticTrial() { |
Luc Nguyen | 69147e0 | 2022-01-24 20:32:10 | [diff] [blame] | 92 | registry_.RegisterSyntheticFieldTrial(SyntheticTrialGroup( |
Luc Nguyen | 75a8bb2ee | 2022-05-04 20:53:55 | [diff] [blame] | 93 | "ExtraSynthetic", "ExtraGroup", |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 94 | /*annotation_mode=*/ |
Luc Nguyen | 75a8bb2ee | 2022-05-04 20:53:55 | [diff] [blame] | 95 | variations::SyntheticTrialAnnotationMode::kNextLog)); |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 96 | } |
| 97 | |
| 98 | // Waits until base::TimeTicks::Now() no longer equals |value|. This should |
| 99 | // take between 1-15ms per the documented resolution of base::TimeTicks. |
| 100 | void WaitUntilTimeChanges(const base::TimeTicks& value) { |
| 101 | while (base::TimeTicks::Now() == value) { |
Peter Kasting | e5a38ed | 2021-10-02 03:06:35 | [diff] [blame] | 102 | base::PlatformThread::Sleep(base::Milliseconds(1)); |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 103 | } |
| 104 | } |
| 105 | |
| 106 | SyntheticTrialRegistry registry_; |
| 107 | }; |
| 108 | |
| 109 | TEST_F(FieldTrialsProviderTest, ProvideSyntheticTrials) { |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 110 | FieldTrialsProvider provider(®istry_, base::StringPiece()); |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 111 | |
| 112 | RegisterExpectedSyntheticTrials(); |
| 113 | // Make sure these trials are older than the log. |
| 114 | WaitUntilTimeChanges(base::TimeTicks::Now()); |
| 115 | |
Alexei Svitkine | 70c9502 | 2019-08-21 18:13:24 | [diff] [blame] | 116 | // Get the current time and wait for it to change. |
| 117 | base::TimeTicks log_creation_time = base::TimeTicks::Now(); |
| 118 | |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 119 | // Make sure that the log is older than the trials that should be excluded. |
Alexei Svitkine | 70c9502 | 2019-08-21 18:13:24 | [diff] [blame] | 120 | WaitUntilTimeChanges(log_creation_time); |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 121 | |
| 122 | RegisterExtraSyntheticTrial(); |
| 123 | |
| 124 | metrics::SystemProfileProto proto; |
Alexei Svitkine | 70c9502 | 2019-08-21 18:13:24 | [diff] [blame] | 125 | provider.ProvideSystemProfileMetricsWithLogCreationTime(log_creation_time, |
| 126 | &proto); |
Xi Han | 095f3934 | 2019-08-08 20:00:54 | [diff] [blame] | 127 | |
Daniel Cheng | 7b7aaecc | 2022-02-26 17:57:25 | [diff] [blame] | 128 | EXPECT_EQ(std::size(kAllTrialIds), |
Xi Han | 095f3934 | 2019-08-08 20:00:54 | [diff] [blame] | 129 | static_cast<size_t>(proto.field_trial_size())); |
Caitlin Fischer | d0cd0b9 | 2020-06-03 12:10:48 | [diff] [blame] | 130 | CheckFieldTrialsInSystemProfile(proto, kAllTrialIds); |
Xi Han | 095f3934 | 2019-08-08 20:00:54 | [diff] [blame] | 131 | } |
| 132 | |
| 133 | TEST_F(FieldTrialsProviderTest, NoSyntheticTrials) { |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 134 | FieldTrialsProvider provider(nullptr, base::StringPiece()); |
Xi Han | 095f3934 | 2019-08-08 20:00:54 | [diff] [blame] | 135 | |
| 136 | metrics::SystemProfileProto proto; |
Alexei Svitkine | 70c9502 | 2019-08-21 18:13:24 | [diff] [blame] | 137 | provider.ProvideSystemProfileMetricsWithLogCreationTime(base::TimeTicks(), |
| 138 | &proto); |
Xi Han | 095f3934 | 2019-08-08 20:00:54 | [diff] [blame] | 139 | |
Daniel Cheng | 7b7aaecc | 2022-02-26 17:57:25 | [diff] [blame] | 140 | EXPECT_EQ(std::size(kFieldTrialIds), |
Xi Han | 095f3934 | 2019-08-08 20:00:54 | [diff] [blame] | 141 | static_cast<size_t>(proto.field_trial_size())); |
Caitlin Fischer | d0cd0b9 | 2020-06-03 12:10:48 | [diff] [blame] | 142 | CheckFieldTrialsInSystemProfile(proto, kFieldTrialIds); |
| 143 | } |
| 144 | |
| 145 | TEST_F(FieldTrialsProviderTest, ProvideCurrentSessionData) { |
| 146 | metrics::ChromeUserMetricsExtension uma_log; |
| 147 | uma_log.system_profile(); |
| 148 | |
| 149 | // {1, 1} should not be in the resulting proto as ProvideCurrentSessionData() |
| 150 | // clears existing trials and sets the trials to be those determined by |
| 151 | // GetSyntheticFieldTrialsOlderThan() and GetFieldTrialIds(). |
| 152 | metrics::SystemProfileProto::FieldTrial* trial = |
| 153 | uma_log.mutable_system_profile()->add_field_trial(); |
| 154 | trial->set_name_id(1); |
| 155 | trial->set_group_id(1); |
| 156 | |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 157 | FieldTrialsProvider provider(®istry_, base::StringPiece()); |
Caitlin Fischer | d0cd0b9 | 2020-06-03 12:10:48 | [diff] [blame] | 158 | RegisterExpectedSyntheticTrials(); |
| 159 | WaitUntilTimeChanges(base::TimeTicks::Now()); |
| 160 | provider.SetLogCreationTimeForTesting(base::TimeTicks::Now()); |
| 161 | |
| 162 | provider.ProvideCurrentSessionData(&uma_log); |
| 163 | |
Daniel Cheng | 7b7aaecc | 2022-02-26 17:57:25 | [diff] [blame] | 164 | EXPECT_EQ(std::size(kAllTrialIds), |
Caitlin Fischer | d0cd0b9 | 2020-06-03 12:10:48 | [diff] [blame] | 165 | static_cast<size_t>(uma_log.system_profile().field_trial_size())); |
| 166 | CheckFieldTrialsInSystemProfile(uma_log.system_profile(), kAllTrialIds); |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 167 | } |
| 168 | |
Luc Nguyen | d28c202 | 2022-05-12 18:58:57 | [diff] [blame] | 169 | TEST_F(FieldTrialsProviderTest, GetAndWriteFieldTrialsWithSuffixes) { |
| 170 | metrics::ChromeUserMetricsExtension uma_log; |
| 171 | uma_log.system_profile(); |
| 172 | |
| 173 | FieldTrialsProvider provider(®istry_, kSuffix); |
| 174 | RegisterExpectedSyntheticTrials(); |
| 175 | WaitUntilTimeChanges(base::TimeTicks::Now()); |
| 176 | provider.SetLogCreationTimeForTesting(base::TimeTicks::Now()); |
| 177 | |
| 178 | provider.ProvideCurrentSessionData(&uma_log); |
| 179 | |
| 180 | EXPECT_EQ(std::size(kAllTrialIdsWithSuffixes), |
| 181 | static_cast<size_t>(uma_log.system_profile().field_trial_size())); |
| 182 | CheckFieldTrialsInSystemProfile(uma_log.system_profile(), |
| 183 | kAllTrialIdsWithSuffixes); |
| 184 | } |
| 185 | |
Steven Holte | 5c6dd63 | 2017-07-19 23:25:49 | [diff] [blame] | 186 | } // namespace variations |