| [email protected] | fd911dd | 2012-01-27 01:57:10 | [diff] [blame] | 1 | // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| license.bot | bf09a50 | 2008-08-24 00:55:55 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| initial.commit | 09911bf | 2008-07-26 23:55:29 | [diff] [blame] | 4 | |
| [email protected] | d353541f | 2012-05-03 22:45:41 | [diff] [blame] | 5 | #include "content/renderer/render_process_impl.h" |
| 6 | |
| [email protected] | 037fce0 | 2009-01-22 01:42:15 | [diff] [blame] | 7 | #include "build/build_config.h" |
| 8 | |
| [email protected] | 037fce0 | 2009-01-22 01:42:15 | [diff] [blame] | 9 | #if defined(OS_WIN) |
| initial.commit | 09911bf | 2008-07-26 23:55:29 | [diff] [blame] | 10 | #include <windows.h> |
| initial.commit | 09911bf | 2008-07-26 23:55:29 | [diff] [blame] | 11 | #include <mlang.h> |
| Gabriel Charette | eadf5886 | 2019-08-29 05:20:27 | [diff] [blame] | 12 | #include <objidl.h> |
| [email protected] | 037fce0 | 2009-01-22 01:42:15 | [diff] [blame] | 13 | #endif |
| initial.commit | 09911bf | 2008-07-26 23:55:29 | [diff] [blame] | 14 | |
| fdoray | d2233a7 | 2016-12-13 17:18:21 | [diff] [blame] | 15 | #include <stddef.h> |
| 16 | |
| fdoray | 743f8d6d | 2017-02-09 15:24:23 | [diff] [blame] | 17 | #include <algorithm> |
| fdoray | 31cc6f8 | 2017-02-10 23:31:10 | [diff] [blame] | 18 | #include <utility> |
| fdoray | d2233a7 | 2016-12-13 17:18:21 | [diff] [blame] | 19 | |
| Eric Holk | 1384f6d | 2018-01-05 00:49:36 | [diff] [blame] | 20 | #include "base/base_switches.h" |
| fdoray | d2233a7 | 2016-12-13 17:18:21 | [diff] [blame] | 21 | #include "base/bind.h" |
| initial.commit | 09911bf | 2008-07-26 23:55:29 | [diff] [blame] | 22 | #include "base/command_line.h" |
| [email protected] | 037fce0 | 2009-01-22 01:42:15 | [diff] [blame] | 23 | #include "base/compiler_specific.h" |
| georgesak | 80353b5 | 2017-01-10 21:18:51 | [diff] [blame] | 24 | #include "base/debug/crash_logging.h" |
| Eric Holk | dc499db | 2017-07-17 17:57:35 | [diff] [blame] | 25 | #include "base/debug/stack_trace.h" |
| ishell | 75fddc1 | 2016-04-12 14:03:14 | [diff] [blame] | 26 | #include "base/feature_list.h" |
| fdoray | 31cc6f8 | 2017-02-10 23:31:10 | [diff] [blame] | 27 | #include "base/memory/ptr_util.h" |
| Ross McIlroy | 900375b | 2019-05-16 20:17:42 | [diff] [blame] | 28 | #include "base/strings/string_split.h" |
| Sebastien Marchand | 75a7cdf | 2018-11-13 23:47:03 | [diff] [blame] | 29 | #include "base/system/sys_info.h" |
| Gabriel Charette | 52fa3ae | 2019-04-15 21:44:37 | [diff] [blame] | 30 | #include "base/task/thread_pool/initialization_util.h" |
| Gabriel Charette | eadf5886 | 2019-08-29 05:20:27 | [diff] [blame] | 31 | #include "base/task/thread_pool/thread_pool_instance.h" |
| fdoray | d2233a7 | 2016-12-13 17:18:21 | [diff] [blame] | 32 | #include "base/time/time.h" |
| Gabriel Charette | 52fa3ae | 2019-04-15 21:44:37 | [diff] [blame] | 33 | #include "content/common/thread_pool_util.h" |
| sammc | 7f6c6a0 | 2017-01-30 00:53:51 | [diff] [blame] | 34 | #include "content/public/common/bindings_policy.h" |
| fdoray | d2233a7 | 2016-12-13 17:18:21 | [diff] [blame] | 35 | #include "content/public/common/content_client.h" |
| bradnelson | c79f5a6f | 2016-10-10 18:31:14 | [diff] [blame] | 36 | #include "content/public/common/content_features.h" |
| [email protected] | c08950d2 | 2011-10-13 22:20:29 | [diff] [blame] | 37 | #include "content/public/common/content_switches.h" |
| [email protected] | d344114c | 2011-10-01 01:24:34 | [diff] [blame] | 38 | #include "content/public/renderer/content_renderer_client.h" |
| Eric Holk | 1384f6d | 2018-01-05 00:49:36 | [diff] [blame] | 39 | #include "services/service_manager/embedder/switches.h" |
| Camillo Bruni | a19d7fc | 2020-03-17 07:53:35 | [diff] [blame] | 40 | #include "third_party/blink/public/common/features.h" |
| Blink Reformat | a30d423 | 2018-04-07 15:31:06 | [diff] [blame] | 41 | #include "third_party/blink/public/web/web_frame.h" |
| [email protected] | 067f519 | 2014-01-29 05:22:09 | [diff] [blame] | 42 | #include "v8/include/v8.h" |
| initial.commit | 09911bf | 2008-07-26 23:55:29 | [diff] [blame] | 43 | |
| georgesak | 80353b5 | 2017-01-10 21:18:51 | [diff] [blame] | 44 | #if defined(OS_WIN) |
| 45 | #include "base/win/win_util.h" |
| 46 | #endif |
| Andreas Haas | 54c0c02 | 2019-06-14 17:33:53 | [diff] [blame] | 47 | #if defined(OS_LINUX) && defined(ARCH_CPU_X86_64) |
| 48 | #include "v8/include/v8-wasm-trap-handler-posix.h" |
| 49 | #endif |
| ishell | 75fddc1 | 2016-04-12 14:03:14 | [diff] [blame] | 50 | namespace { |
| 51 | |
| ishell | 75fddc1 | 2016-04-12 14:03:14 | [diff] [blame] | 52 | void SetV8FlagIfFeature(const base::Feature& feature, const char* v8_flag) { |
| 53 | if (base::FeatureList::IsEnabled(feature)) { |
| 54 | v8::V8::SetFlagsFromString(v8_flag, strlen(v8_flag)); |
| 55 | } |
| 56 | } |
| 57 | |
| bradnelson | 2730e351 | 2017-01-21 20:32:21 | [diff] [blame] | 58 | void SetV8FlagIfNotFeature(const base::Feature& feature, const char* v8_flag) { |
| 59 | if (!base::FeatureList::IsEnabled(feature)) { |
| 60 | v8::V8::SetFlagsFromString(v8_flag, strlen(v8_flag)); |
| 61 | } |
| 62 | } |
| 63 | |
| ishell | 75fddc1 | 2016-04-12 14:03:14 | [diff] [blame] | 64 | void SetV8FlagIfHasSwitch(const char* switch_name, const char* v8_flag) { |
| 65 | if (base::CommandLine::ForCurrentProcess()->HasSwitch(switch_name)) { |
| 66 | v8::V8::SetFlagsFromString(v8_flag, strlen(v8_flag)); |
| 67 | } |
| 68 | } |
| 69 | |
| Gabriel Charette | 43fd370 | 2019-05-29 16:36:51 | [diff] [blame] | 70 | std::unique_ptr<base::ThreadPoolInstance::InitParams> |
| 71 | GetThreadPoolInitParams() { |
| Etienne Pierre-doray | ce56296 | 2019-02-08 18:50:48 | [diff] [blame] | 72 | constexpr int kMaxNumThreadsInForegroundPoolLowerBound = 3; |
| Gabriel Charette | 43fd370 | 2019-05-29 16:36:51 | [diff] [blame] | 73 | return std::make_unique<base::ThreadPoolInstance::InitParams>( |
| Francois Doray | 7f77731 | 2019-05-16 12:26:31 | [diff] [blame] | 74 | std::max(kMaxNumThreadsInForegroundPoolLowerBound, |
| 75 | content::GetMinForegroundThreadsInRendererThreadPool())); |
| fdoray | d2233a7 | 2016-12-13 17:18:21 | [diff] [blame] | 76 | } |
| 77 | |
| Tomas Popela | afffa97 | 2018-11-13 20:42:05 | [diff] [blame] | 78 | #if defined(DCHECK_IS_CONFIGURABLE) |
| Sigurdur Asgeirsson | 379c51e4 | 2017-09-21 12:52:45 | [diff] [blame] | 79 | void V8DcheckCallbackHandler(const char* file, int line, const char* message) { |
| 80 | // TODO(siggi): Set a crash key or a breadcrumb so the fact that we hit a |
| 81 | // V8 DCHECK gets out in the crash report. |
| 82 | ::logging::LogMessage(file, line, logging::LOG_DCHECK).stream() << message; |
| 83 | } |
| Tomas Popela | afffa97 | 2018-11-13 20:42:05 | [diff] [blame] | 84 | #endif // defined(DCHECK_IS_CONFIGURABLE) |
| Sigurdur Asgeirsson | 379c51e4 | 2017-09-21 12:52:45 | [diff] [blame] | 85 | |
| ishell | 75fddc1 | 2016-04-12 14:03:14 | [diff] [blame] | 86 | } // namespace |
| 87 | |
| [email protected] | eb39819 | 2012-10-22 20:16:19 | [diff] [blame] | 88 | namespace content { |
| 89 | |
| Francois Doray | 7f77731 | 2019-05-16 12:26:31 | [diff] [blame] | 90 | RenderProcessImpl::RenderProcessImpl() |
| Nasko Oskov | d0dfddf | 2020-04-20 16:53:02 | [diff] [blame^] | 91 | : RenderProcess("Renderer", GetThreadPoolInitParams()) { |
| Tomas Popela | afffa97 | 2018-11-13 20:42:05 | [diff] [blame] | 92 | #if defined(DCHECK_IS_CONFIGURABLE) |
| Wez | a6ca5b9 | 2018-03-23 19:03:07 | [diff] [blame] | 93 | // Some official builds ship with DCHECKs compiled in. Failing DCHECKs then |
| 94 | // are either fatal or simply log the error, based on a feature flag. |
| Sigurdur Asgeirsson | 379c51e4 | 2017-09-21 12:52:45 | [diff] [blame] | 95 | // Make sure V8 follows suit by setting a Dcheck handler that forwards to |
| 96 | // the Chrome base logging implementation. |
| 97 | v8::V8::SetDcheckErrorHandler(&V8DcheckCallbackHandler); |
| 98 | |
| Wez | a6ca5b9 | 2018-03-23 19:03:07 | [diff] [blame] | 99 | if (!base::FeatureList::IsEnabled(base::kDCheckIsFatalFeature)) { |
| Sigurdur Asgeirsson | 379c51e4 | 2017-09-21 12:52:45 | [diff] [blame] | 100 | // These V8 flags default on in this build configuration. This triggers |
| 101 | // additional verification and code generation, which both slows down V8, |
| 102 | // and can lead to fatal CHECKs. Turn these flags down to get something |
| 103 | // closer to V8s normal performance and behavior. |
| 104 | constexpr char kDisabledFlags[] = |
| 105 | "--noturbo_verify " |
| Sigurdur Asgeirsson | 379c51e4 | 2017-09-21 12:52:45 | [diff] [blame] | 106 | "--noturbo_verify_allocation " |
| 107 | "--nodebug_code"; |
| 108 | |
| 109 | v8::V8::SetFlagsFromString(kDisabledFlags, sizeof(kDisabledFlags)); |
| 110 | } |
| Tomas Popela | afffa97 | 2018-11-13 20:42:05 | [diff] [blame] | 111 | #endif // defined(DCHECK_IS_CONFIGURABLE) |
| Sigurdur Asgeirsson | 379c51e4 | 2017-09-21 12:52:45 | [diff] [blame] | 112 | |
| [email protected] | 35b4f0c | 2014-06-26 16:55:27 | [diff] [blame] | 113 | if (base::SysInfo::IsLowEndDevice()) { |
| [email protected] | 067f519 | 2014-01-29 05:22:09 | [diff] [blame] | 114 | std::string optimize_flag("--optimize-for-size"); |
| Clemens Hammacher | c4a139a | 2019-04-25 13:55:09 | [diff] [blame] | 115 | v8::V8::SetFlagsFromString(optimize_flag.c_str(), optimize_flag.size()); |
| [email protected] | 067f519 | 2014-01-29 05:22:09 | [diff] [blame] | 116 | } |
| [email protected] | 987422f | 2013-10-01 10:33:31 | [diff] [blame] | 117 | |
| ishell | 75fddc1 | 2016-04-12 14:03:14 | [diff] [blame] | 118 | SetV8FlagIfHasSwitch(switches::kDisableJavaScriptHarmonyShipping, |
| 119 | "--noharmony-shipping"); |
| 120 | SetV8FlagIfHasSwitch(switches::kJavaScriptHarmony, "--harmony"); |
| Andreas Haas | b400d91 | 2019-08-28 18:54:10 | [diff] [blame] | 121 | SetV8FlagIfHasSwitch(switches::kEnableExperimentalWebAssemblyFeatures, |
| 122 | "--wasm-staging"); |
| Kouhei Ueno | 14d350d | 2018-10-01 02:36:27 | [diff] [blame] | 123 | |
| 124 | constexpr char kModuleFlags[] = |
| 125 | "--harmony-dynamic-import --harmony-import-meta"; |
| 126 | v8::V8::SetFlagsFromString(kModuleFlags, sizeof(kModuleFlags)); |
| 127 | |
| Michael Hablich | 896d5266 | 2017-10-23 15:59:57 | [diff] [blame] | 128 | SetV8FlagIfFeature(features::kV8VmFuture, "--future"); |
| 129 | SetV8FlagIfNotFeature(features::kV8VmFuture, "--no-future"); |
| Clemens Hammacher | 0c8a15a | 2018-04-27 13:45:32 | [diff] [blame] | 130 | |
| Clemens Backes | 963eb37be | 2020-01-10 11:56:49 | [diff] [blame] | 131 | SetV8FlagIfFeature(features::kWebAssemblyBaseline, "--liftoff"); |
| 132 | SetV8FlagIfNotFeature(features::kWebAssemblyBaseline, "--no-liftoff"); |
| Clemens Hammacher | 0c8a15a | 2018-04-27 13:45:32 | [diff] [blame] | 133 | |
| Clemens Backes | 50e0ecd | 2020-01-20 10:43:24 | [diff] [blame] | 134 | SetV8FlagIfFeature(features::kWebAssemblyLazyCompilation, |
| 135 | "--wasm-lazy-compilation"); |
| 136 | SetV8FlagIfNotFeature(features::kWebAssemblyLazyCompilation, |
| 137 | "--no-wasm-lazy-compilation"); |
| 138 | |
| Deepti Gandluri | 11734cc4 | 2019-05-02 18:00:20 | [diff] [blame] | 139 | SetV8FlagIfFeature(features::kWebAssemblySimd, "--experimental-wasm-simd"); |
| 140 | SetV8FlagIfNotFeature(features::kWebAssemblySimd, |
| 141 | "--no-experimental-wasm-simd"); |
| 142 | |
| Camillo Bruni | a19d7fc | 2020-03-17 07:53:35 | [diff] [blame] | 143 | SetV8FlagIfFeature(blink::features::kTopLevelAwait, |
| 144 | "--harmony-top-level-await"); |
| 145 | |
| Ben Smith | 24c1e5c | 2018-06-20 01:09:02 | [diff] [blame] | 146 | if (base::FeatureList::IsEnabled(features::kWebAssemblyThreads)) { |
| 147 | constexpr char kFlags[] = |
| 148 | "--harmony-sharedarraybuffer " |
| Ben Smith | 24c1e5c | 2018-06-20 01:09:02 | [diff] [blame] | 149 | "--experimental-wasm-threads"; |
| 150 | |
| 151 | v8::V8::SetFlagsFromString(kFlags, sizeof(kFlags)); |
| 152 | } else { |
| Ben Smith | 24c1e5c | 2018-06-20 01:09:02 | [diff] [blame] | 153 | SetV8FlagIfFeature(features::kSharedArrayBuffer, |
| 154 | "--harmony-sharedarraybuffer"); |
| 155 | SetV8FlagIfNotFeature(features::kSharedArrayBuffer, |
| 156 | "--no-harmony-sharedarraybuffer"); |
| 157 | } |
| Michael Hablich | 896d5266 | 2017-10-23 15:59:57 | [diff] [blame] | 158 | |
| Clemens Backes | 963eb37be | 2020-01-10 11:56:49 | [diff] [blame] | 159 | SetV8FlagIfFeature(features::kWebAssemblyTiering, "--wasm-tier-up"); |
| 160 | SetV8FlagIfNotFeature(features::kWebAssemblyTiering, "--no-wasm-tier-up"); |
| 161 | |
| Eric Holk | b4f6013 | 2017-08-18 19:37:41 | [diff] [blame] | 162 | SetV8FlagIfNotFeature(features::kWebAssemblyTrapHandler, |
| 163 | "--no-wasm-trap-handler"); |
| Lei Zhang | 2d3ead60 | 2018-07-10 01:15:50 | [diff] [blame] | 164 | #if defined(OS_LINUX) && defined(ARCH_CPU_X86_64) |
| Eric Holk | dc499db | 2017-07-17 17:57:35 | [diff] [blame] | 165 | if (base::FeatureList::IsEnabled(features::kWebAssemblyTrapHandler)) { |
| Eric Holk | 1384f6d | 2018-01-05 00:49:36 | [diff] [blame] | 166 | base::CommandLine* command_line = base::CommandLine::ForCurrentProcess(); |
| 167 | if (!command_line->HasSwitch( |
| 168 | service_manager::switches::kDisableInProcessStackTraces)) { |
| Andreas Haas | ef19d59 | 2019-04-30 18:16:51 | [diff] [blame] | 169 | // Only enable WebAssembly trap handler if we can set the callback. |
| 170 | if (base::debug::SetStackDumpFirstChanceCallback( |
| Andreas Haas | 54c0c02 | 2019-06-14 17:33:53 | [diff] [blame] | 171 | v8::TryHandleWebAssemblyTrapPosix)) { |
| Andreas Haas | ef19d59 | 2019-04-30 18:16:51 | [diff] [blame] | 172 | // We registered the WebAssembly trap handler callback with the stack |
| 173 | // dump signal handler successfully. We can tell V8 that it can enable |
| 174 | // WebAssembly trap handler without using the V8 signal handler. |
| 175 | v8::V8::EnableWebAssemblyTrapHandler(/*use_v8_signal_handler=*/false); |
| 176 | } |
| Eric Holk | 1384f6d | 2018-01-05 00:49:36 | [diff] [blame] | 177 | } else if (!command_line->HasSwitch(switches::kEnableCrashReporter) && |
| 178 | !command_line->HasSwitch( |
| 179 | switches::kEnableCrashReporterForTesting)) { |
| 180 | // If we are using WebAssembly trap handling but both Breakpad and |
| 181 | // in-process stack traces are disabled then there will be no signal |
| 182 | // handler. In this case, we fall back on V8's default handler |
| 183 | // (https://crbug.com/798150). |
| Andreas Haas | ef19d59 | 2019-04-30 18:16:51 | [diff] [blame] | 184 | v8::V8::EnableWebAssemblyTrapHandler(/*use_v8_signal_handler=*/true); |
| Eric Holk | 1384f6d | 2018-01-05 00:49:36 | [diff] [blame] | 185 | } |
| Eric Holk | dc499db | 2017-07-17 17:57:35 | [diff] [blame] | 186 | } |
| 187 | #endif |
| Andreas Haas | 5ed0f50 | 2018-11-06 09:05:06 | [diff] [blame] | 188 | #if defined(OS_WIN) && defined(ARCH_CPU_X86_64) |
| 189 | if (base::FeatureList::IsEnabled(features::kWebAssemblyTrapHandler)) { |
| 190 | // On Windows we use the default trap handler provided by V8. |
| 191 | bool use_v8_trap_handler = true; |
| 192 | v8::V8::EnableWebAssemblyTrapHandler(use_v8_trap_handler); |
| 193 | } |
| 194 | #endif |
| Andreas Haas | 3bd4532 | 2018-11-21 07:45:42 | [diff] [blame] | 195 | #if defined(OS_MACOSX) && defined(ARCH_CPU_X86_64) |
| 196 | if (base::FeatureList::IsEnabled(features::kWebAssemblyTrapHandler)) { |
| 197 | // On macOS, Crashpad uses exception ports to handle signals in a different |
| 198 | // process. As we cannot just pass a callback to this other process, we ask |
| 199 | // V8 to install its own signal handler to deal with WebAssembly traps. |
| 200 | bool use_v8_signal_handler = true; |
| 201 | v8::V8::EnableWebAssemblyTrapHandler(use_v8_signal_handler); |
| 202 | } |
| 203 | #endif // defined(OS_MACOSX) && defined(ARCH_CPU_X86_64) |
| Eric Holk | dc499db | 2017-07-17 17:57:35 | [diff] [blame] | 204 | |
| avi | 83883c8 | 2014-12-23 00:08:49 | [diff] [blame] | 205 | const base::CommandLine& command_line = |
| 206 | *base::CommandLine::ForCurrentProcess(); |
| ishell | 75fddc1 | 2016-04-12 14:03:14 | [diff] [blame] | 207 | |
| Ross McIlroy | 3ba9207 | 2018-08-01 00:43:30 | [diff] [blame] | 208 | if (command_line.HasSwitch(switches::kNoV8UntrustedCodeMitigations)) { |
| 209 | const char* disable_mitigations = "--no-untrusted-code-mitigations"; |
| 210 | v8::V8::SetFlagsFromString(disable_mitigations, |
| 211 | strlen(disable_mitigations)); |
| 212 | } |
| 213 | |
| [email protected] | 396c3a46 | 2010-03-03 05:03:22 | [diff] [blame] | 214 | if (command_line.HasSwitch(switches::kJavaScriptFlags)) { |
| Ross McIlroy | 900375b | 2019-05-16 20:17:42 | [diff] [blame] | 215 | std::string js_flags = |
| 216 | command_line.GetSwitchValueASCII(switches::kJavaScriptFlags); |
| 217 | std::vector<base::StringPiece> flag_list = base::SplitStringPiece( |
| 218 | js_flags, ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_NONEMPTY); |
| 219 | for (const auto& flag : flag_list) { |
| 220 | v8::V8::SetFlagsFromString(flag.as_string().c_str(), flag.size()); |
| 221 | } |
| [email protected] | 396c3a46 | 2010-03-03 05:03:22 | [diff] [blame] | 222 | } |
| [email protected] | e68e62fa | 2009-02-20 02:00:04 | [diff] [blame] | 223 | } |
| 224 | |
| [email protected] | 396c3a46 | 2010-03-03 05:03:22 | [diff] [blame] | 225 | RenderProcessImpl::~RenderProcessImpl() { |
| [email protected] | 396c3a46 | 2010-03-03 05:03:22 | [diff] [blame] | 226 | #ifndef NDEBUG |
| Blink Reformat | 1c4d759e | 2017-04-09 16:34:54 | [diff] [blame] | 227 | int count = blink::WebFrame::InstanceCount(); |
| [email protected] | 6bd867b | 2013-07-24 22:10:20 | [diff] [blame] | 228 | if (count) |
| 229 | DLOG(ERROR) << "WebFrame LEAKED " << count << " TIMES"; |
| [email protected] | 396c3a46 | 2010-03-03 05:03:22 | [diff] [blame] | 230 | #endif |
| [email protected] | e68e62fa | 2009-02-20 02:00:04 | [diff] [blame] | 231 | |
| [email protected] | 396c3a46 | 2010-03-03 05:03:22 | [diff] [blame] | 232 | GetShutDownEvent()->Signal(); |
| [email protected] | 396c3a46 | 2010-03-03 05:03:22 | [diff] [blame] | 233 | } |
| [email protected] | e68e62fa | 2009-02-20 02:00:04 | [diff] [blame] | 234 | |
| fdoray | 31cc6f8 | 2017-02-10 23:31:10 | [diff] [blame] | 235 | std::unique_ptr<RenderProcess> RenderProcessImpl::Create() { |
| Francois Doray | 7f77731 | 2019-05-16 12:26:31 | [diff] [blame] | 236 | return base::WrapUnique(new RenderProcessImpl()); |
| fdoray | 31cc6f8 | 2017-02-10 23:31:10 | [diff] [blame] | 237 | } |
| 238 | |
| Arthur Sonzogni | c4f8dee | 2018-09-05 08:51:33 | [diff] [blame] | 239 | void RenderProcessImpl::AddRefProcess() { |
| 240 | NOTREACHED(); |
| 241 | } |
| 242 | |
| 243 | void RenderProcessImpl::ReleaseProcess() { |
| 244 | NOTREACHED(); |
| 245 | } |
| 246 | |
| [email protected] | eb39819 | 2012-10-22 20:16:19 | [diff] [blame] | 247 | } // namespace content |