Clean up some warnings produced by Qt Creator's clang/clazy code checkers

- Remove unused variables
- Remove assignments that do not have any effect
- Fix mixing const/non-const iterators
- Fix for loops, use const ref and/or qAsConst()

Change-Id: I4b52f11030493c440026b194f18ec0151a3ea710
Reviewed-by: Cristian Maureira-Fredes <[email protected]>

1 files changed, 2 insertions, 3 deletions

diff --git a/sources/pyside6/libpyside/feature_select.cpp b/sources/pyside6/libpyside/feature_select.cpp
index b87751271..060c0d2ec 100644
--- a/sources/pyside6/libpyside/feature_select.cpp
+++ b/sources/pyside6/libpyside/feature_select.cpp
@@ -584,9 +584,8 @@ static PyObject *modifyStaticToClassMethod(PyTypeObject *type, PyObject *sm)
     new_func->ml_meth = func->m_ml->ml_meth;
     new_func->ml_flags = (func->m_ml->ml_flags & ~METH_STATIC) | METH_CLASS;
     new_func->ml_doc = func->m_ml->ml_doc;
-    auto cfunc = PyCFunction_NewEx(new_func, nullptr, nullptr);
-    cfunc = PyDescr_NewClassMethod(type, new_func);
-    return cfunc;
+    PyCFunction_NewEx(new_func, nullptr, nullptr);
+    return PyDescr_NewClassMethod(type, new_func);
 }
 
 static PyObject *createProperty(PyTypeObject *type, PyObject *getter, PyObject *setter)