diff options
author | Jarek Kobus <[email protected]> | 2022-12-07 14:38:23 +0100 |
---|---|---|
committer | Jarek Kobus <[email protected]> | 2022-12-07 16:30:13 +0000 |
commit | 0d74be319af9425d6fba12a2f06cd3bc1c6ef28f (patch) | |
tree | 593d2c221aa39a879ee80e8ed3a13e4995eb325d | |
parent | 9afcf870a1f6f4d498621dc3fb0c5bb94e03d773 (diff) |
Android: Pass context object to lambda connections
Remove some unneeded lambda () brackets.
Change-Id: Id00e2bc736683bb844cc7ba936ac9d21aa204416
Reviewed-by: Alessandro Portale <[email protected]>
-rw-r--r-- | src/plugins/android/androidbuildapkstep.cpp | 4 | ||||
-rw-r--r-- | src/plugins/android/androiddevice.cpp | 6 | ||||
-rw-r--r-- | src/plugins/android/androidplugin.cpp | 10 | ||||
-rw-r--r-- | src/plugins/android/androidsdkmanager.cpp | 2 | ||||
-rw-r--r-- | src/plugins/android/androidsdkmodel.cpp | 4 | ||||
-rw-r--r-- | src/plugins/android/androidservicewidget.cpp | 6 | ||||
-rw-r--r-- | src/plugins/android/androidsettingswidget.cpp | 2 |
7 files changed, 17 insertions, 17 deletions
diff --git a/src/plugins/android/androidbuildapkstep.cpp b/src/plugins/android/androidbuildapkstep.cpp index 3a184487a19..39cb6723659 100644 --- a/src/plugins/android/androidbuildapkstep.cpp +++ b/src/plugins/android/androidbuildapkstep.cpp @@ -1021,11 +1021,11 @@ PasswordInputDialog::PasswordInputDialog(PasswordInputDialog::Context context, mainLayout->addWidget(warningLabel); mainLayout->addWidget(buttonBox); - connect(inputEdit, &QLineEdit::textChanged,[this](const QString &text) { + connect(inputEdit, &QLineEdit::textChanged, this, [this](const QString &text) { buttonBox->button(QDialogButtonBox::Ok)->setEnabled(!text.isEmpty()); }); - connect(buttonBox, &QDialogButtonBox::accepted, [this] { + connect(buttonBox, &QDialogButtonBox::accepted, this, [this] { if (verifyCallback(inputEdit->text())) { accept(); // Dialog accepted. } else { diff --git a/src/plugins/android/androiddevice.cpp b/src/plugins/android/androiddevice.cpp index 0526c8e691f..e1a1db1ed7f 100644 --- a/src/plugins/android/androiddevice.cpp +++ b/src/plugins/android/androiddevice.cpp @@ -455,7 +455,7 @@ void AndroidDeviceManager::startAvd(const ProjectExplorer::IDevice::Ptr &device, const AndroidDevice *androidDev = static_cast<const AndroidDevice *>(device.data()); const QString name = androidDev->avdName(); qCDebug(androidDeviceLog, "Starting Android AVD id \"%s\".", qPrintable(name)); - runAsync([this, name, device]() { + runAsync([this, name, device] { const QString serialNumber = m_avdManager.startAvd(name); // Mark the AVD as ReadyToUse once we know it's started if (!serialNumber.isEmpty()) { @@ -480,7 +480,7 @@ void AndroidDeviceManager::eraseAvd(const IDevice::Ptr &device, QWidget *parent) return; qCDebug(androidDeviceLog) << QString("Erasing Android AVD \"%1\" from the system.").arg(name); - m_removeAvdFutureWatcher.setFuture(runAsync([this, name, device]() { + m_removeAvdFutureWatcher.setFuture(runAsync([this, name, device] { QPair<IDevice::ConstPtr, bool> pair; pair.first = device; pair.second = false; @@ -512,7 +512,7 @@ void AndroidDeviceManager::setupWifiForDevice(const IDevice::Ptr &device, QWidge return; } - QTimer::singleShot(2000, parent, [adbSelector, parent]() { + QTimer::singleShot(2000, parent, [adbSelector, parent] { // Get device IP address QStringList args = adbSelector; args.append({"shell", "ip", "route"}); diff --git a/src/plugins/android/androidplugin.cpp b/src/plugins/android/androidplugin.cpp index 62050fd2dea..45ef092f4ad 100644 --- a/src/plugins/android/androidplugin.cpp +++ b/src/plugins/android/androidplugin.cpp @@ -131,10 +131,10 @@ bool AndroidPlugin::initialize(const QStringList &arguments, QString *errorMessa connect(KitManager::instance(), &KitManager::kitsLoaded, this, &AndroidPlugin::kitsRestored); - LanguageClient::LanguageClientSettings::registerClientType({Android::Constants::JLS_SETTINGS_ID, - Tr::tr("Java Language Server"), - []() { return new JLSSettings; }}); - + LanguageClient::LanguageClientSettings::registerClientType( + {Android::Constants::JLS_SETTINGS_ID, + Tr::tr("Java Language Server"), + [] { return new JLSSettings; }}); return true; } @@ -153,7 +153,7 @@ void AndroidPlugin::kitsRestored() AndroidConfigurations::registerNewToolChains(); AndroidConfigurations::updateAutomaticKitList(); connect(QtSupport::QtVersionManager::instance(), &QtSupport::QtVersionManager::qtVersionsChanged, - AndroidConfigurations::instance(), []() { + AndroidConfigurations::instance(), [] { AndroidConfigurations::registerNewToolChains(); AndroidConfigurations::updateAutomaticKitList(); }); diff --git a/src/plugins/android/androidsdkmanager.cpp b/src/plugins/android/androidsdkmanager.cpp index af5b789f026..72a6951921f 100644 --- a/src/plugins/android/androidsdkmanager.cpp +++ b/src/plugins/android/androidsdkmanager.cpp @@ -451,7 +451,7 @@ void SdkManagerOutputParser::parsePackageListing(const QString &output) bool collectingPackageData = false; MarkerTag currentPackageMarker = MarkerTag::None; - auto processCurrentPackage = [&]() { + auto processCurrentPackage = [&] { if (collectingPackageData) { collectingPackageData = false; parsePackageData(currentPackageMarker, packageData); diff --git a/src/plugins/android/androidsdkmodel.cpp b/src/plugins/android/androidsdkmodel.cpp index 30701c893a0..44a7b65183a 100644 --- a/src/plugins/android/androidsdkmodel.cpp +++ b/src/plugins/android/androidsdkmodel.cpp @@ -29,11 +29,11 @@ AndroidSdkModel::AndroidSdkModel(const AndroidConfig &config, AndroidSdkManager m_sdkManager(sdkManager) { QTC_CHECK(m_sdkManager); - connect(m_sdkManager, &AndroidSdkManager::packageReloadBegin, [this] { + connect(m_sdkManager, &AndroidSdkManager::packageReloadBegin, this, [this] { clearContainers(); beginResetModel(); }); - connect(m_sdkManager, &AndroidSdkManager::packageReloadFinished, [this] { + connect(m_sdkManager, &AndroidSdkManager::packageReloadFinished, this, [this] { refreshData(); endResetModel(); }); diff --git a/src/plugins/android/androidservicewidget.cpp b/src/plugins/android/androidservicewidget.cpp index 5e6c685bdcb..4fa7030723c 100644 --- a/src/plugins/android/androidservicewidget.cpp +++ b/src/plugins/android/androidservicewidget.cpp @@ -331,14 +331,14 @@ AndroidServiceWidget::AndroidServiceWidget(QWidget *parent) : QWidget(parent), connect(m_removeButton, &QAbstractButton::clicked, this, &AndroidServiceWidget::removeService); connect(m_tableView->selectionModel(), &QItemSelectionModel::selectionChanged, - [this](const QItemSelection &selected, const QItemSelection &/*deselected*/) { + this, [this](const QItemSelection &selected) { if (!selected.isEmpty()) m_removeButton->setEnabled(true); }); connect(m_model.data(), &AndroidServiceWidget::AndroidServiceModel::validDataChanged, - [this] { emit servicesModified(); }); + this, [this] { emit servicesModified(); }); connect(m_model.data(), &AndroidServiceWidget::AndroidServiceModel::invalidDataChanged, - [this] { emit servicesInvalid(); }); + this, [this] { emit servicesInvalid(); }); } AndroidServiceWidget::~AndroidServiceWidget() diff --git a/src/plugins/android/androidsettingswidget.cpp b/src/plugins/android/androidsettingswidget.cpp index 401e801aea9..93f2d94cf2a 100644 --- a/src/plugins/android/androidsettingswidget.cpp +++ b/src/plugins/android/androidsettingswidget.cpp @@ -381,7 +381,7 @@ AndroidSettingsWidget::AndroidSettingsWidget() this, &AndroidSettingsWidget::onSdkPathChanged); connect(m_ndkListWidget, &QListWidget::currentTextChanged, - [this, removeCustomNdkButton](const QString &ndk) { + this, [this, removeCustomNdkButton](const QString &ndk) { updateUI(); removeCustomNdkButton->setEnabled(m_androidConfig.getCustomNdkList().contains(ndk)); }); |