diff options
author | Christian Kandeler <[email protected]> | 2023-10-11 13:33:52 +0200 |
---|---|---|
committer | Christian Kandeler <[email protected]> | 2023-10-12 10:35:02 +0000 |
commit | 25b747b00c0874edf1a13f2bcf5ff22836313326 (patch) | |
tree | 9256844d64e8d06f884834d7817101920f2d34f7 | |
parent | 413fda678fc3c13b00f5f26c3867a62160f5abad (diff) |
QmakeProjectManager: Compress project tree once from the root nodev12.0.0-beta1
We must not compress a half-built tree, as the relevant conditions might
change later. For example, after setting up the headers node, we might
have a tree src -> headers -> header.h, and compression will lead to
src/headers -> header.h. Now after adding the sources node, we might
have an additional main.cpp under src, which means src and headers
should not have been merged.
Fixes: QTCREATORBUG-29733
Change-Id: I1419a87a0671f43ad65cbe3d108c36cfeba17781
Reviewed-by: hjk <[email protected]>
-rw-r--r-- | src/plugins/qmakeprojectmanager/qmakenodetreebuilder.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/plugins/qmakeprojectmanager/qmakenodetreebuilder.cpp b/src/plugins/qmakeprojectmanager/qmakenodetreebuilder.cpp index 914c15cf155..01bae3472fd 100644 --- a/src/plugins/qmakeprojectmanager/qmakenodetreebuilder.cpp +++ b/src/plugins/qmakeprojectmanager/qmakenodetreebuilder.cpp @@ -195,7 +195,6 @@ static void createTree(QmakeBuildSystem *buildSystem, fileNode->setEnabled(fn.second == FileOrigin::ExactParse); vfolder->addNestedNode(std::move(fileNode)); } - vfolder->forEachFolderNode([](FolderNode *fn) { fn->compress(); }); } node->addNode(std::move(vfolder)); } @@ -265,6 +264,7 @@ std::unique_ptr<QmakeProFileNode> QmakeNodeTreeBuilder::buildTree(QmakeBuildSyst buildSystem->rootProFile()); root->setIcon(iconForProfile(buildSystem->rootProFile())); createTree(buildSystem, buildSystem->rootProFile(), root.get(), toExclude); + root->compress(); return root; } |