ProjectExplorer: Fix kit duplication in target setup pagev4.9.0

Do not add a modified kit to the UI if it was already present.

Fixes: QTCREATORBUG-21240
Change-Id: Ib4887902402734ce95bde21c26ec9188ee9e55da
Reviewed-by: Christian Stenger <[email protected]>

1 files changed, 5 insertions, 0 deletions

diff --git a/src/plugins/projectexplorer/targetsetuppage.cpp b/src/plugins/projectexplorer/targetsetuppage.cpp
index aea75ad9932..501e0efc39a 100644
--- a/src/plugins/projectexplorer/targetsetuppage.cpp
+++ b/src/plugins/projectexplorer/targetsetuppage.cpp
@@ -382,6 +382,11 @@ void TargetSetupPage::handleKitUpdate(Kit *k)
         m_importer->makePersistent(k);
 
     bool acceptable = !m_requiredPredicate || m_requiredPredicate(k);
+    const bool wasAcceptable = Utils::contains(m_widgets, [k](const TargetSetupWidget *w) {
+        return w->kit() == k;
+    });
+    if (acceptable == wasAcceptable)
+        return;
 
     if (!acceptable)
         removeWidget(k);