diff options
author | Jarek Kobus <[email protected]> | 2025-09-17 16:40:00 +0200 |
---|---|---|
committer | Jarek Kobus <[email protected]> | 2025-09-18 14:07:26 +0000 |
commit | 7cbb271d4e7740460402c42c7ac018830ef94a19 (patch) | |
tree | 057301ee056d39d4a209a16951b334513831c79a | |
parent | c43c62c19335f749c80c4635a688506ac6c660d0 (diff) |
ClangTools: Disconnect signals explicitlyv18.0.0-beta1
Otherwise Qt issues warnings about disconnecting from
destroyed signal.
Change-Id: If729c39b523d7b147ba65edae43439749d21a019
Reviewed-by: Christian Kandeler <[email protected]>
-rw-r--r-- | src/plugins/clangtools/runsettingswidget.cpp | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/plugins/clangtools/runsettingswidget.cpp b/src/plugins/clangtools/runsettingswidget.cpp index 81a8b7c644a..51e903d25b6 100644 --- a/src/plugins/clangtools/runsettingswidget.cpp +++ b/src/plugins/clangtools/runsettingswidget.cpp @@ -90,7 +90,8 @@ static ClangDiagnosticConfigsWidget *createEditWidget(const ClangDiagnosticConfi void RunSettingsWidget::fromSettings(const RunSettings &s) { - disconnect(m_diagnosticWidget, 0, 0, 0); + disconnect(m_diagnosticWidget, &ClangDiagnosticConfigsSelectionWidget::changed, + this, &RunSettingsWidget::changed); m_diagnosticWidget->refresh(diagnosticConfigsModel(), s.diagnosticConfigId(), createEditWidget); @@ -100,7 +101,7 @@ void RunSettingsWidget::fromSettings(const RunSettings &s) m_preferConfigFile->setChecked(s.preferConfigFile()); connect(m_preferConfigFile, &QCheckBox::toggled, this, &RunSettingsWidget::changed); - disconnect(m_buildBeforeAnalysis, 0, 0, 0); + disconnect(m_buildBeforeAnalysis, &QCheckBox::toggled, this, nullptr); m_buildBeforeAnalysis->setToolTip(hintAboutBuildBeforeAnalysis()); m_buildBeforeAnalysis->setCheckState(s.buildBeforeAnalysis() ? Qt::Checked : Qt::Unchecked); connect(m_buildBeforeAnalysis, &QCheckBox::toggled, this, [this](bool checked) { @@ -109,7 +110,7 @@ void RunSettingsWidget::fromSettings(const RunSettings &s) emit changed(); }); - disconnect(m_parallelJobsSpinBox, 0, 0, 0); + disconnect(m_parallelJobsSpinBox, &QSpinBox::valueChanged, this, &RunSettingsWidget::changed); m_parallelJobsSpinBox->setValue(s.parallelJobs()); m_parallelJobsSpinBox->setMinimum(1); m_parallelJobsSpinBox->setMaximum(QThread::idealThreadCount()); |