Check that the id property is a plain lowercase identifier.

1 files changed, 26 insertions, 0 deletions

diff --git a/src/libs/qmljs/qmljscheck.cpp b/src/libs/qmljs/qmljscheck.cpp
index 7322d1f8f39..8269f92c893 100644
--- a/src/libs/qmljs/qmljscheck.cpp
+++ b/src/libs/qmljs/qmljscheck.cpp
@@ -144,6 +144,32 @@ void Check::errorOnWrongRhs(const SourceLocation &loc, const Value *lhsValue)
 
 bool Check::visit(UiScriptBinding *ast)
 {
+    // special case for id property
+    if (ast->qualifiedId->name->asString() == QLatin1String("id") && ! ast->qualifiedId->next) {
+        if (! ast->statement)
+            return false;
+
+        const SourceLocation loc = locationFromRange(ast->statement->firstSourceLocation(),
+                                                     ast->statement->lastSourceLocation());
+
+        ExpressionStatement *expStmt = cast<ExpressionStatement *>(ast->statement);
+        if (!expStmt) {
+            error(loc, QCoreApplication::translate("QmlJS::Check", "expected id"));
+            return false;
+        }
+
+        IdentifierExpression *idExp = cast<IdentifierExpression *>(expStmt->expression);
+        if (! idExp) {
+            error(loc, QCoreApplication::translate("QmlJS::Check", "expected id"));
+            return false;
+        }
+
+        if (! idExp->name->asString()[0].isLower()) {
+            error(loc, QCoreApplication::translate("QmlJS::Check", "ids must be lower case"));
+            return false;
+        }
+    }
+
     const Value *lhsValue = checkScopeObjectMember(ast->qualifiedId);
     if (lhsValue) {
         // ### Fix the evaluator to accept statements!