diff options
author | Fawzi Mohamed <[email protected]> | 2012-12-19 19:04:36 +0100 |
---|---|---|
committer | Fawzi Mohamed <[email protected]> | 2013-01-29 17:56:59 +0100 |
commit | 18fa486531a0cb274d67279e04f0b18ff6ee82e3 (patch) | |
tree | 753ab71ef145950882d194ba618fbd5f4d737c40 /src/libs/utils/consoleprocess.cpp | |
parent | 7db3b660b64d5d6fa35b067e148d6807a089b209 (diff) |
consoleprocess: support Terminal.app on mac
Distinguishes the process that starts the terminal from the stub
process, as on mac to support Terminal.app they are different.
Handle the stub not through the process that starts the terminal,
but through the local socket (on *nix).
Replace the blocking wait(...) in the main thread, with a nonblocking
wait in the signal handler when receiving a SIGCHLD, to leave the
main thread able to handle communication with creator.
This change allows the use of terminal emulator commands
that share a single instance or that fork.
So this is also the real fix for QTCREATORBUG-1633 on linux.
If creator crashes the stub and the debugged program live on.
This was done on purpose, it could be changed if considered better.
Task-number: QTCREATORBUG-6371
Task-number: QTCREATORBUG-1633
Change-Id: I4d4fb3a67b1987f4e46e2c603dcefe8c15152ad2
Reviewed-by: Oswald Buddenhagen <[email protected]>
Diffstat (limited to 'src/libs/utils/consoleprocess.cpp')
-rw-r--r-- | src/libs/utils/consoleprocess.cpp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/libs/utils/consoleprocess.cpp b/src/libs/utils/consoleprocess.cpp index 964ae45eb2f..e6ee4c6f8a8 100644 --- a/src/libs/utils/consoleprocess.cpp +++ b/src/libs/utils/consoleprocess.cpp @@ -29,6 +29,8 @@ #include "consoleprocess_p.h" +#include <utils/hostosinfo.h> + #include <QSettings> namespace Utils { |