Terminal: Use QtcProcess to start terminal window

Previously DesktopDevice::openTerminal used custom code to open a
terminal window. This patch changes it to use QtcProcess with
TerminalMode::On.

This also removes the need for "openTerminal.py" on macOS.

Change-Id: Iec978bdd19487ff8e59dcd88c35c2d01b0681022
Reviewed-by: Cristian Adam <[email protected]>

1 files changed, 2 insertions, 2 deletions

diff --git a/src/libs/utils/terminalinterface.cpp b/src/libs/utils/terminalinterface.cpp
index 7ec7c755fd3..58d48cb910a 100644
--- a/src/libs/utils/terminalinterface.cpp
+++ b/src/libs/utils/terminalinterface.cpp
@@ -304,8 +304,6 @@ void TerminalInterface::start()
         return;
     }
 
-    m_setup.m_environment.unset(QLatin1String("TERM"));
-
     Environment finalEnv = m_setup.m_environment;
 
     if (HostOsInfo::isWindowsHost()) {
@@ -319,6 +317,8 @@ void TerminalInterface::start()
             if (!systemRoot.isEmpty())
                 finalEnv.set("SystemRoot", systemRoot);
         }
+    } else if (HostOsInfo::isMacHost()) {
+        finalEnv.set("TERM", "xterm-256color");
     }
 
     if (finalEnv.hasChanges()) {