aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/android/androidplugin.cpp
diff options
context:
space:
mode:
authorhjk <[email protected]>2023-01-05 10:34:21 +0100
committerhjk <[email protected]>2023-01-23 11:18:03 +0000
commit978639b995cd5041698fba01bd0e9f4acbe2a628 (patch)
tree83980b85874a6489b751fc891d07afd801f35d98 /src/plugins/android/androidplugin.cpp
parent9c57ed6bd28c4ec55fcd68cf49c17603b06c9b39 (diff)
Android: Use specific classes for run worker factories
Slimmer file interfaces. Change-Id: I2cf846c04000eb29fe53219db9a97088b6b9a1aa Reviewed-by: Alessandro Portale <[email protected]> Reviewed-by: Qt CI Bot <[email protected]>
Diffstat (limited to 'src/plugins/android/androidplugin.cpp')
-rw-r--r--src/plugins/android/androidplugin.cpp36
1 files changed, 8 insertions, 28 deletions
diff --git a/src/plugins/android/androidplugin.cpp b/src/plugins/android/androidplugin.cpp
index 070a62a1baa..717238b1fc6 100644
--- a/src/plugins/android/androidplugin.cpp
+++ b/src/plugins/android/androidplugin.cpp
@@ -1,6 +1,8 @@
// Copyright (C) 2016 BogDan Vatra <[email protected]>
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0
+#include "androidplugin.h"
+
#include "androidconfigurations.h"
#include "androidbuildapkstep.h"
#include "androidconstants.h"
@@ -9,7 +11,6 @@
#include "androiddevice.h"
#include "androidmanifesteditorfactory.h"
#include "androidpackageinstallationstep.h"
-#include "androidplugin.h"
#include "androidpotentialkit.h"
#include "androidqmlpreviewworker.h"
#include "androidqmltoolingsupport.h"
@@ -48,8 +49,7 @@ using namespace ProjectExplorer::Constants;
const char kSetupAndroidSetting[] = "ConfigureAndroid";
-namespace Android {
-namespace Internal {
+namespace Android::Internal {
class AndroidDeployConfigurationFactory : public DeployConfigurationFactory
{
@@ -89,29 +89,10 @@ public:
AndroidPackageInstallationFactory packackeInstallationFactory;
AndroidManifestEditorFactory manifestEditorFactory;
AndroidRunConfigurationFactory runConfigFactory;
-
- RunWorkerFactory runWorkerFactory{
- RunWorkerFactory::make<AndroidRunSupport>(),
- {NORMAL_RUN_MODE},
- {runConfigFactory.runConfigurationId()}
- };
- RunWorkerFactory debugWorkerFactory{
- RunWorkerFactory::make<AndroidDebugSupport>(),
- {DEBUG_RUN_MODE},
- {runConfigFactory.runConfigurationId()}
- };
- RunWorkerFactory profilerWorkerFactory{
- RunWorkerFactory::make<AndroidQmlToolingSupport>(),
- {QML_PROFILER_RUN_MODE},
- {runConfigFactory.runConfigurationId()}
- };
- RunWorkerFactory qmlPreviewWorkerFactory{
- RunWorkerFactory::make<AndroidQmlPreviewWorker>(),
- {QML_PREVIEW_RUN_MODE},
- {"QmlProjectManager.QmlRunConfiguration.Qml", runConfigFactory.runConfigurationId()},
- {Android::Constants::ANDROID_DEVICE_TYPE}
- };
-
+ AndroidRunWorkerFactory runWorkerFactory;
+ AndroidDebugWorkerFactory debugWorkerFactory;
+ AndroidQmlToolingSupportFactory profilerWorkerFactory;
+ AndroidQmlPreviewWorkerFactory qmlPreviewWorkerFactory;
AndroidBuildApkStepFactory buildApkStepFactory;
AndroidDeviceManager deviceManager;
};
@@ -177,5 +158,4 @@ void AndroidPlugin::askUserAboutAndroidSetup()
Core::ICore::infoBar()->addInfo(info);
}
-} // namespace Internal
-} // namespace Android
+} // Android::Internal