aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/baremetal/idebugserverprovider.h
diff options
context:
space:
mode:
authorhjk <[email protected]>2019-12-12 17:41:43 +0100
committerhjk <[email protected]>2020-01-16 09:44:31 +0000
commit3d7a3b4749abad409663806cadec535fb3a041b6 (patch)
treeb295de8af1cf1f4d6b2ea96b5ed12164e480b4d5 /src/plugins/baremetal/idebugserverprovider.h
parent66371198ecbc47e3eae87f63997eb0c189dc83be (diff)
BareMetal: De-virtualize IDebugServerProvider::createConfigWidget
There is no change in functionality intended. The original version is good in principle, but Creator core has been moving to use this 'setFoo(std::function<>)' pattern during the last year, greatly reducing the need for boilerplate on the "user" side. The effect isn't as significant here, but generally I don't want to use too many different patterns being used. Change-Id: I3ec8c677c19c1ed3f8145e0c3cba337dff7ce1cf Reviewed-by: Christian Stenger <[email protected]> Reviewed-by: Denis Shienkov <[email protected]>
Diffstat (limited to 'src/plugins/baremetal/idebugserverprovider.h')
-rw-r--r--src/plugins/baremetal/idebugserverprovider.h5
1 files changed, 4 insertions, 1 deletions
diff --git a/src/plugins/baremetal/idebugserverprovider.h b/src/plugins/baremetal/idebugserverprovider.h
index 34167772964..f52aa34699f 100644
--- a/src/plugins/baremetal/idebugserverprovider.h
+++ b/src/plugins/baremetal/idebugserverprovider.h
@@ -84,7 +84,9 @@ public:
virtual bool operator==(const IDebugServerProvider &other) const;
- virtual IDebugServerProviderConfigWidget *configurationWidget() = 0;
+ IDebugServerProviderConfigWidget *configurationWidget() const;
+ void setConfigurationWidgetCreator
+ (const std::function<IDebugServerProviderConfigWidget *()> &configurationWidgetCreator);
virtual QVariantMap toMap() const;
virtual bool fromMap(const QVariantMap &data);
@@ -114,6 +116,7 @@ protected:
QUrl m_channel;
Debugger::DebuggerEngineType m_engineType = Debugger::NoEngineType;
QSet<BareMetalDevice *> m_devices;
+ std::function<IDebugServerProviderConfigWidget *()> m_configurationWidgetCreator;
friend class DebugServerProvidersSettingsWidget;
friend class IDebugServerProviderConfigWidget;