diff options
| author | Daniel Teske <[email protected]> | 2012-05-03 16:05:03 +0200 |
|---|---|---|
| committer | Daniel Teske <[email protected]> | 2012-05-03 16:22:13 +0200 |
| commit | ce62c4bf91689a1d0590afc32ea1856d09bd5235 (patch) | |
| tree | 128fa80a1d654334e95c0a5494c888fcf6358063 /src/plugins/cmakeprojectmanager/makestep.cpp | |
| parent | 3d9150075bb0ee7f958a21d59187548fd17cbf07 (diff) | |
CMakeProjectManager: Remove outdated todos
Most of them are done, or are not really todos but just notes on
the code.
Change-Id: Idc4836844ee7bc1444e1251f97118bd9103a6019
Reviewed-by: Daniel Teske <[email protected]>
Diffstat (limited to 'src/plugins/cmakeprojectmanager/makestep.cpp')
| -rw-r--r-- | src/plugins/cmakeprojectmanager/makestep.cpp | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/src/plugins/cmakeprojectmanager/makestep.cpp b/src/plugins/cmakeprojectmanager/makestep.cpp index cec1683dfcf..2bf6121daa9 100644 --- a/src/plugins/cmakeprojectmanager/makestep.cpp +++ b/src/plugins/cmakeprojectmanager/makestep.cpp @@ -63,8 +63,6 @@ const char * const BUILD_TARGETS_KEY("CMakeProjectManager.MakeStep.BuildTargets" const char * const ADDITIONAL_ARGUMENTS_KEY("CMakeProjectManager.MakeStep.AdditionalArguments"); } -// TODO: Move progress information into an IOutputParser! - MakeStep::MakeStep(BuildStepList *bsl) : AbstractProcessStep(bsl, Core::Id(MS_ID)), m_clean(false), m_futureInterface(0) @@ -248,7 +246,6 @@ MakeStepConfigWidget::MakeStepConfigWidget(MakeStep *makeStep) fl->addRow(tr("Targets:"), m_buildTargetsList); // TODO update this list also on rescans of the CMakeLists.txt - // TODO shouldn't be accessing project CMakeProject *pro = static_cast<CMakeProject *>(m_makeStep->target()->project()); foreach (const QString& buildTarget, pro->buildTargetTitles()) { QListWidgetItem *item = new QListWidgetItem(buildTarget, m_buildTargetsList); @@ -305,7 +302,7 @@ void MakeStepConfigWidget::updateDetails() bc = static_cast<CMakeBuildConfiguration *>(m_makeStep->target()->activeBuildConfiguration()); ProjectExplorer::ToolChain *tc = bc->toolChain(); if (tc) { - QString arguments = Utils::QtcProcess::joinArgs(m_makeStep->m_buildTargets); + QString arguments = Utils::QtcProcess::joinArgs(m_makeStep->buildTargets()); Utils::QtcProcess::addArgs(&arguments, m_makeStep->additionalArguments()); ProcessParameters param; |