aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/cppcheck
diff options
context:
space:
mode:
authorChristian Kandeler <[email protected]>2021-08-20 11:21:06 +0200
committerChristian Kandeler <[email protected]>2021-08-27 10:53:54 +0000
commita952500e902eb0a0fe5b5dbcdafb6cb66fb88141 (patch)
tree744dfbbf969359a3cb147b6bbc8ee47fe361a7ab /src/plugins/cppcheck
parent5d8551559af2300a67815582198b4ce580a7bba2 (diff)
CppTools: Use only const pointers for ProjectInfo and ProjectPart
All members were already const, but this makes it clear at all points of use that these data structures are immutable. Change-Id: Iea615c090bde462c445d15223caccc561b0c713d Reviewed-by: Jarek Kobus <[email protected]>
Diffstat (limited to 'src/plugins/cppcheck')
-rw-r--r--src/plugins/cppcheck/cppchecktool.cpp10
-rw-r--r--src/plugins/cppcheck/cppchecktool.h2
-rw-r--r--src/plugins/cppcheck/cppchecktrigger.cpp2
3 files changed, 7 insertions, 7 deletions
diff --git a/src/plugins/cppcheck/cppchecktool.cpp b/src/plugins/cppcheck/cppchecktool.cpp
index a0cd174c2e6..d0495d1adf8 100644
--- a/src/plugins/cppcheck/cppchecktool.cpp
+++ b/src/plugins/cppcheck/cppchecktool.cpp
@@ -204,21 +204,21 @@ void CppcheckTool::check(const Utils::FilePaths &files)
if (filtered.isEmpty())
return;
- const CppTools::ProjectInfo::Ptr info
+ const CppTools::ProjectInfo::ConstPtr info
= CppTools::CppModelManager::instance()->projectInfo(m_project);
if (!info)
return;
- const QVector<CppTools::ProjectPart::Ptr> parts = info->projectParts();
+ const QVector<CppTools::ProjectPart::ConstPtr> parts = info->projectParts();
if (parts.size() == 1) {
QTC_ASSERT(parts.first(), return);
addToQueue(filtered, *parts.first());
return;
}
- std::map<CppTools::ProjectPart::Ptr, Utils::FilePaths> groups;
+ std::map<CppTools::ProjectPart::ConstPtr, Utils::FilePaths> groups;
for (const Utils::FilePath &file : qAsConst(filtered)) {
const QString stringed = file.toString();
- for (const CppTools::ProjectPart::Ptr &part : parts) {
+ for (const CppTools::ProjectPart::ConstPtr &part : parts) {
using CppTools::ProjectFile;
QTC_ASSERT(part, continue);
const auto match = [stringed](const ProjectFile &pFile){return pFile.path == stringed;};
@@ -231,7 +231,7 @@ void CppcheckTool::check(const Utils::FilePaths &files)
addToQueue(group.second, *group.first);
}
-void CppcheckTool::addToQueue(const Utils::FilePaths &files, CppTools::ProjectPart &part)
+void CppcheckTool::addToQueue(const Utils::FilePaths &files, const CppTools::ProjectPart &part)
{
const QString key = part.id();
if (!m_cachedAdditionalArguments.contains(key))
diff --git a/src/plugins/cppcheck/cppchecktool.h b/src/plugins/cppcheck/cppchecktool.h
index c10c2516e2f..2951234683c 100644
--- a/src/plugins/cppcheck/cppchecktool.h
+++ b/src/plugins/cppcheck/cppchecktool.h
@@ -75,7 +75,7 @@ public:
private:
void updateArguments();
- void addToQueue(const Utils::FilePaths &files, CppTools::ProjectPart &part);
+ void addToQueue(const Utils::FilePaths &files, const CppTools::ProjectPart &part);
QStringList additionalArguments(const CppTools::ProjectPart &part) const;
CppcheckDiagnosticManager &m_manager;
diff --git a/src/plugins/cppcheck/cppchecktrigger.cpp b/src/plugins/cppcheck/cppchecktrigger.cpp
index 93a36596a64..47370c2cd5b 100644
--- a/src/plugins/cppcheck/cppchecktrigger.cpp
+++ b/src/plugins/cppcheck/cppchecktrigger.cpp
@@ -76,7 +76,7 @@ void CppcheckTrigger::checkEditors(const QList<Core::IEditor *> &editors)
return;
using CppModelManager = CppTools::CppModelManager;
- const CppTools::ProjectInfo::Ptr info
+ const CppTools::ProjectInfo::ConstPtr info
= CppModelManager::instance()->projectInfo(m_currentProject);
if (!info)
return;