diff options
author | Jarek Kobus <[email protected]> | 2023-09-27 19:36:19 +0200 |
---|---|---|
committer | Jarek Kobus <[email protected]> | 2023-10-02 12:43:33 +0000 |
commit | bc5a2dbf143d62276c9bae5b08d0defed98d4506 (patch) | |
tree | 65e1d0b4a79ab5ab6d9134348d767bdb8d3305f4 /src/plugins/ctfvisualizer/ctftracemanager.cpp | |
parent | 5c52bdd0e9142905881e28808c70d8ebae09a494 (diff) |
CtfVisualizer: Do some cleanup
Remove unused headers.
Use using namespace and drop unneeded namespace scopes.
Replace QVector with QList.
Return default constructed objects in default return statements.
Avoid empty arg brackets in some lambdas.
Use default member initializers.
Change-Id: I11e62a291be3fa5bde4156e7a316765ee697b852
Reviewed-by: <[email protected]>
Reviewed-by: Alessandro Portale <[email protected]>
Diffstat (limited to 'src/plugins/ctfvisualizer/ctftracemanager.cpp')
-rw-r--r-- | src/plugins/ctfvisualizer/ctftracemanager.cpp | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/src/plugins/ctfvisualizer/ctftracemanager.cpp b/src/plugins/ctfvisualizer/ctftracemanager.cpp index c9fe7f2b351..5a83a2f6c17 100644 --- a/src/plugins/ctfvisualizer/ctftracemanager.cpp +++ b/src/plugins/ctfvisualizer/ctftracemanager.cpp @@ -13,11 +13,9 @@ #include <QMessageBox> -namespace CtfVisualizer { -namespace Internal { +namespace CtfVisualizer::Internal { using json = nlohmann::json; - using namespace Constants; CtfTraceManager::CtfTraceManager(QObject *parent, @@ -152,7 +150,7 @@ QList<CtfTimelineModel *> CtfTraceManager::getSortedThreads() const QList<CtfTimelineModel *> models = m_threadModels.values(); std::sort(models.begin(), models.end(), - [](const CtfTimelineModel *a, const CtfTimelineModel *b) -> bool { + [](const CtfTimelineModel *a, const CtfTimelineModel *b) { return (a->m_processId != b->m_processId) ? (a->m_processId < b->m_processId) : (a->m_threadId < b->m_threadId); }); @@ -238,5 +236,4 @@ QString CtfTraceManager::errorString() const return m_errorString; } -} // namespace Internal -} // namespace CtfVisualizer +} // namespace CtfVisualizer::Internal |