Don't allocate unneeded temporary containers

Fix clazy warnings: allocating an unneeded temporary container
[clazy-container-anti-pattern]

Change-Id: I4b4c2c634eea650bbdf3c12d982a17f899fc94ec
Reviewed-by: Alessandro Portale <[email protected]>
Reviewed-by: David Schulz <[email protected]>
Reviewed-by: hjk <[email protected]>

1 files changed, 7 insertions, 4 deletions

diff --git a/src/plugins/ctfvisualizer/ctftracemanager.cpp b/src/plugins/ctfvisualizer/ctftracemanager.cpp
index ba0976dbec5..651e6c6f8e3 100644
--- a/src/plugins/ctfvisualizer/ctftracemanager.cpp
+++ b/src/plugins/ctfvisualizer/ctftracemanager.cpp
@@ -176,8 +176,9 @@ void CtfTraceManager::load(const QString &filename)
 void CtfTraceManager::finalize()
 {
     bool userConsentToIgnoreDeepTraces = false;
-    for (qint64 tid: m_threadModels.keys()) {
-        if (m_threadModels[tid]->m_maxStackSize > 512) {
+    auto it = m_threadModels.begin();
+    while (it != m_threadModels.end()) {
+        if (it.value()->m_maxStackSize > 512) {
             if (!userConsentToIgnoreDeepTraces) {
                 QMessageBox::StandardButton answer
                     = QMessageBox::question(Core::ICore::dialogParent(),
@@ -192,8 +193,10 @@ void CtfTraceManager::finalize()
                     break;
                 }
             }
-            m_threadModels.remove(tid);
-            m_threadRestrictions.remove(tid);
+            m_threadRestrictions.remove(it.key());
+            it = m_threadModels.erase(it);
+        } else {
+            ++it;
         }
     }
     for (CtfTimelineModel *model: m_threadModels) {