Reduce usage of app_version header

Most information is available via Q(Core|Gui)Application.
Add an AppInfo structure for the things that are not.

This avoids that the information ends up duplicated and
hardcoded in the plugins, which is not needed or desired.

Change-Id: I4d565e75c42a7b8facafa90c27096ea49359215d
Reviewed-by: Alessandro Portale <[email protected]>
Reviewed-by: Qt CI Bot <[email protected]>

1 files changed, 5 insertions, 6 deletions

diff --git a/src/plugins/debugger/debuggerplugin.cpp b/src/plugins/debugger/debuggerplugin.cpp
index 4aa0f1b33c6..14dfbdfac3c 100644
--- a/src/plugins/debugger/debuggerplugin.cpp
+++ b/src/plugins/debugger/debuggerplugin.cpp
@@ -31,8 +31,6 @@
 #include "analyzer/analyzerconstants.h"
 #include "analyzer/analyzermanager.h"
 
-#include <app/app_version.h>
-
 #include <coreplugin/actionmanager/actioncontainer.h>
 #include <coreplugin/actionmanager/actionmanager.h>
 #include <coreplugin/actionmanager/command.h>
@@ -1671,10 +1669,11 @@ RunControl *DebuggerPluginPrivate::attachToRunningProcess(Kit *kit,
     const bool isWindows = (tcAbi.os() == Abi::WindowsOS);
     if (isWindows && isWinProcessBeingDebugged(processInfo.processId)) {
         AsynchronousMessageBox::warning(
-                    Tr::tr("Process Already Under Debugger Control"),
-                    Tr::tr("The process %1 is already under the control of a debugger.\n"
-                       "%2 cannot attach to it.").arg(processInfo.processId)
-                    .arg(Core::Constants::IDE_DISPLAY_NAME));
+            Tr::tr("Process Already Under Debugger Control"),
+            Tr::tr("The process %1 is already under the control of a debugger.\n"
+                   "%2 cannot attach to it.")
+                .arg(processInfo.processId)
+                .arg(QGuiApplication::applicationDisplayName()));
         return nullptr;
     }