aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/extensionmanager/extensionmanagerwidget.cpp
diff options
context:
space:
mode:
authorAlessandro Portale <[email protected]>2024-11-13 23:34:11 +0000
committerAlessandro Portale <[email protected]>2024-11-13 23:34:24 +0000
commit4e0babff8f2ef55bf7ead2961b6378fd37158dab (patch)
tree0118cfded54ba25ab8f8dcfa8731eb29946750c8 /src/plugins/extensionmanager/extensionmanagerwidget.cpp
parentae59ed0e4abd3e5f6504466cdae84d6e3ce2cd3a (diff)
Revert "ExtensionsManager: Omit reloading for softloadable plugins"
This reverts commit ae59ed0e4abd3e5f6504466cdae84d6e3ce2cd3a. Reason for revert: Breaks build Change-Id: I4dc5bdcb4bf30e2ebf3478ba7e480a9032b800f7 Reviewed-by: Alessandro Portale <[email protected]>
Diffstat (limited to 'src/plugins/extensionmanager/extensionmanagerwidget.cpp')
-rw-r--r--src/plugins/extensionmanager/extensionmanagerwidget.cpp25
1 files changed, 11 insertions, 14 deletions
diff --git a/src/plugins/extensionmanager/extensionmanagerwidget.cpp b/src/plugins/extensionmanager/extensionmanagerwidget.cpp
index d6f0ddf3de6..0c367adc5ea 100644
--- a/src/plugins/extensionmanager/extensionmanagerwidget.cpp
+++ b/src/plugins/extensionmanager/extensionmanagerwidget.cpp
@@ -9,7 +9,6 @@
#include "extensionsmodel.h"
#include <coreplugin/coreconstants.h>
-#include <coreplugin/coreplugin.h>
#include <coreplugin/coreplugintr.h>
#include <coreplugin/icontext.h>
#include <coreplugin/icore.h>
@@ -267,19 +266,17 @@ public:
return;
const bool doIt = m_pluginView.data().setPluginsEnabled({spec}, checked);
if (doIt) {
- if (checked && spec->isEffectivelySoftloadable()) {
- ExtensionSystem::PluginManager::loadPluginsAtRuntime({spec});
- Core::Internal::CorePlugin::loadMimeFromPlugin(spec);
- } else if (ICore::infoBar()->canInfoBeAdded(kRestartSetting)) {
- Utils::InfoBarEntry info(
- kRestartSetting,
- Core::Tr::tr("Plugin changes will take effect after restart."));
- info.addCustomButton(Tr::tr("Restart Now"), [] {
- ICore::infoBar()->removeInfo(kRestartSetting);
- QTimer::singleShot(0, ICore::instance(), &ICore::restart);
- });
- ICore::infoBar()->addInfo(info);
- }
+ if (!ICore::infoBar()->canInfoBeAdded(kRestartSetting))
+ return;
+
+ Utils::InfoBarEntry info(
+ kRestartSetting,
+ Core::Tr::tr("Plugin changes will take effect after restart."));
+ info.addCustomButton(Tr::tr("Restart Now"), [] {
+ ICore::infoBar()->removeInfo(kRestartSetting);
+ QTimer::singleShot(0, ICore::instance(), &ICore::restart);
+ });
+ ICore::infoBar()->addInfo(info);
ExtensionSystem::PluginManager::writeSettings();
} else {