Always pass Core::Id by value.

Currently we pass in some places by value, elsewhere by const ref and
for some weird reason also by const value in a lot of places. The latter
is particularly annoying, as it is also used in interfaces and therefore
forces all implementors to do the same, since leaving the "const" off is
causing compiler warnings with MSVC.

Change-Id: I65b87dc3cce0986b8a55ff6119cb752361027803
Reviewed-by: hjk <[email protected]>

1 files changed, 5 insertions, 5 deletions

diff --git a/src/plugins/fakevim/fakevimplugin.cpp b/src/plugins/fakevim/fakevimplugin.cpp
index 1440f17fc5f..a9457a9a33d 100644
--- a/src/plugins/fakevim/fakevimplugin.cpp
+++ b/src/plugins/fakevim/fakevimplugin.cpp
@@ -831,7 +831,7 @@ void FakeVimUserCommandsPage::apply()
 class FakeVimCompletionAssistProvider : public CompletionAssistProvider
 {
 public:
-    bool supportsEditor(const Id &) const
+    bool supportsEditor(Id ) const
     {
         return false;
     }
@@ -1058,8 +1058,8 @@ private:
     FakeVimUserCommandsPage *m_fakeVimUserCommandsPage;
     QHash<IEditor *, FakeVimHandler *> m_editorToHandler;
 
-    void triggerAction(const Id &id);
-    void setActionChecked(const Id &id, bool check);
+    void triggerAction(Id id);
+    void setActionChecked(Id id, bool check);
 
     typedef int (*DistFunction)(const QRect &cursor, const QRect &other);
     void moveSomewhere(DistFunction f, int count);
@@ -1386,7 +1386,7 @@ void FakeVimPluginPrivate::showSettingsDialog()
     ICore::showOptionsDialog(SETTINGS_CATEGORY, SETTINGS_ID);
 }
 
-void FakeVimPluginPrivate::triggerAction(const Id &id)
+void FakeVimPluginPrivate::triggerAction(Id id)
 {
     Core::Command *cmd = ActionManager::command(id);
     QTC_ASSERT(cmd, qDebug() << "UNKNOWN CODE: " << id.name(); return);
@@ -1395,7 +1395,7 @@ void FakeVimPluginPrivate::triggerAction(const Id &id)
     action->trigger();
 }
 
-void FakeVimPluginPrivate::setActionChecked(const Id &id, bool check)
+void FakeVimPluginPrivate::setActionChecked(Id id, bool check)
 {
     Core::Command *cmd = ActionManager::command(id);
     QTC_ASSERT(cmd, return);