Vcs: Move createVcsEditor into VcsBaseClientImpl

... and use that in Git as well.

Change-Id: I81c85fcf5a7da7e9f756f117ea6c38c15294a401
Reviewed-by: Orgad Shaneh <[email protected]>

1 files changed, 4 insertions, 10 deletions

diff --git a/src/plugins/git/gitclient.h b/src/plugins/git/gitclient.h
index efc2127f061..8a2bb35bf91 100644
--- a/src/plugins/git/gitclient.h
+++ b/src/plugins/git/gitclient.h
@@ -349,8 +349,6 @@ public slots:
               const QString &name = QString());
 
 private slots:
-    void slotBlameRevisionRequested(const QString &workingDirectory, const QString &file,
-                                    QString change, int lineNumber);
     void finishSubmoduleUpdate();
     void fetchFinished(const QVariant &cookie);
     void slotChunkActionsRequested(QMenu *menu, bool isValid);
@@ -359,19 +357,15 @@ private slots:
     void branchesForCommit(const QString &revision);
 
 private:
+    void annotateRevisionRequested(const QString &workingDirectory, const QString &file,
+                                   const QString &change, int lineNumber) override;
+
     void stage(const QString &patch, bool revert);
-    QTextCodec *getSourceCodec(const QString &file) const;
     VcsBase::VcsBaseEditorWidget *findExistingVCSEditor(const char *registerDynamicProperty,
                                                         const QString &dynamicPropertyValue) const;
 
     enum CodecType { CodecSource, CodecLogOutput, CodecNone };
-
-    VcsBase::VcsBaseEditorWidget *createVcsEditor(Core::Id kind,
-                                                  QString title,
-                                                  const QString &source,
-                                                  CodecType codecType,
-                                                  const char *registerDynamicProperty,
-                                                  const QString &dynamicPropertyValue) const;
+    QTextCodec *codecFor(CodecType codecType, const QString &source = QString()) const;
 
     void requestReload(const QString &documentId, const QString &source, const QString &title,
                        std::function<DiffEditor::DiffEditorController *(Core::IDocument *)> factory) const;