diff options
| author | Eike Ziller <[email protected]> | 2016-11-21 10:58:19 +0100 |
|---|---|---|
| committer | Eike Ziller <[email protected]> | 2016-11-25 08:42:53 +0000 |
| commit | 57ca90b8460765df3e1518ff24a0549a9d3fb059 (patch) | |
| tree | 3ee7bba1b4ec33c1ab63fd57caa71ec2de27da67 /src/plugins/git/gitgrep.cpp | |
| parent | 62a842e447a834f0f800f147f4cf499c9de3724d (diff) | |
BaseFileFind/FindInFiles: Clean up enabled / valid state handling
IFindFilter: Separate enabledChanged and validChanged
SearchEngine: Add enabledChanged
GitGrep: Enable widget based on enabled state
FindInFiles: Update validity on search engine enabledChanged instead of
hardcoding it to when the search path changed
Change-Id: I0c684423b871a3a4f1f164574f42e23b64cf9da0
Reviewed-by: David Schulz <[email protected]>
Diffstat (limited to 'src/plugins/git/gitgrep.cpp')
| -rw-r--r-- | src/plugins/git/gitgrep.cpp | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/src/plugins/git/gitgrep.cpp b/src/plugins/git/gitgrep.cpp index 07e51399afe..cf961487d6b 100644 --- a/src/plugins/git/gitgrep.cpp +++ b/src/plugins/git/gitgrep.cpp @@ -198,7 +198,7 @@ private: } // namespace -static bool validateDirectory(const QString &path) +static bool isGitDirectory(const QString &path) { static IVersionControl *gitVc = VcsManager::versionControl(VcsBase::Constants::VCS_ID_GIT); QTC_ASSERT(gitVc, return false); @@ -221,8 +221,9 @@ GitGrep::GitGrep() QTC_ASSERT(findInFiles, return); connect(findInFiles, &TextEditor::FindInFiles::pathChanged, m_widget, [this](const QString &path) { - m_widget->setEnabled(validateDirectory(path)); + setEnabled(isGitDirectory(path)); }); + connect(this, &SearchEngine::enabledChanged, m_widget, &QWidget::setEnabled); findInFiles->addSearchEngine(this); } @@ -249,11 +250,6 @@ QWidget *GitGrep::widget() const return m_widget; } -bool GitGrep::isEnabled() const -{ - return m_widget->isEnabled(); -} - QVariant GitGrep::parameters() const { GitGrepParameters params; |
