aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/git/gitplugin.cpp
diff options
context:
space:
mode:
authorOrgad Shaneh <[email protected]>2017-01-30 09:12:47 +0200
committerOrgad Shaneh <[email protected]>2017-01-30 08:41:04 +0000
commit2def95374d018898a484e34eca2e66effe0ac7f6 (patch)
tree538baf959a5233d27cfe67d5c2a64731e5a8e53d /src/plugins/git/gitplugin.cpp
parentb805639776ef45392a09f40ca8cf6fc9d9439e24 (diff)
Git: Fix crash on Commit + Push to Gerrit
Task-number: QTCREATORBUG-17634 Change-Id: I60d8067fe9cfc23acb688e06506363bca67ec0a5 Reviewed-by: Tobias Hunger <[email protected]>
Diffstat (limited to 'src/plugins/git/gitplugin.cpp')
-rw-r--r--src/plugins/git/gitplugin.cpp8
1 files changed, 5 insertions, 3 deletions
diff --git a/src/plugins/git/gitplugin.cpp b/src/plugins/git/gitplugin.cpp
index 90498282351..8d664496a4a 100644
--- a/src/plugins/git/gitplugin.cpp
+++ b/src/plugins/git/gitplugin.cpp
@@ -1051,10 +1051,12 @@ bool GitPlugin::submitEditorAboutToClose()
m_gitClient->interactiveRebase(m_submitRepository, amendSHA1, true);
} else {
m_gitClient->continueCommandIfNeeded(m_submitRepository);
- if (editor->panelData().pushAction == NormalPush)
+ if (editor->panelData().pushAction == NormalPush) {
m_gitClient->push(m_submitRepository);
- else if (editor->panelData().pushAction == PushToGerrit)
- connect(editor, &QObject::destroyed, this, &GitPlugin::delayedPushToGerrit);
+ } else if (editor->panelData().pushAction == PushToGerrit) {
+ connect(editor, &QObject::destroyed, this, &GitPlugin::delayedPushToGerrit,
+ Qt::QueuedConnection);
+ }
}
return true;