diff options
author | Friedemann Kleint <[email protected]> | 2009-12-08 14:26:41 +0100 |
---|---|---|
committer | Friedemann Kleint <[email protected]> | 2009-12-08 14:26:41 +0100 |
commit | 8097879d6d98ce304f742823ccb9bddfcec44839 (patch) | |
tree | f4d54d94f4ef9b88dc3bafebdb02d52a178c8b2d /src/plugins/git/gitversioncontrol.cpp | |
parent | 8d6b4e51ab9b8cc2b6642e7de8a644fdec82c07b (diff) |
VCS: Introduce Base class for VCS plugins, use in git.
Fixes:
- Cannot diff a file that does not belong to a project
- Cannot commit when a temporary diff/log view is open
due to the current file pointing to a temporary directory
- git's project-related actions not passing the correct
relative path.
Implementation:
- Centralize code to listen for Qt Creator's relevant state changes
in VCSBasePlugin, dispatching the changes to the instances affected.
(avoiding multiple invocations of searches/QFileInfo on current).
- Do the same for the corelistener catching closing SubmitEditors.
- Introduce VCSBasePluginState representing the relevant state
(current file/project).
- Call git with working directory set and relative arguments
- Remove setEnabled/isEnabled() logic of IVersionControl
- Pass toplevel from VCSManager to avoid duplicate searches.
Diffstat (limited to 'src/plugins/git/gitversioncontrol.cpp')
-rw-r--r-- | src/plugins/git/gitversioncontrol.cpp | 13 |
1 files changed, 0 insertions, 13 deletions
diff --git a/src/plugins/git/gitversioncontrol.cpp b/src/plugins/git/gitversioncontrol.cpp index c64a683bea0..e9e8ec96026 100644 --- a/src/plugins/git/gitversioncontrol.cpp +++ b/src/plugins/git/gitversioncontrol.cpp @@ -44,19 +44,6 @@ QString GitVersionControl::name() const return QLatin1String("git"); } -bool GitVersionControl::isEnabled() const -{ - return m_enabled; -} - -void GitVersionControl::setEnabled(bool enabled) -{ - if (m_enabled != enabled) { - m_enabled = enabled; - emit enabledChanged(m_enabled); - } -} - bool GitVersionControl::supportsOperation(Operation operation) const { bool rc = false; |