TaskTree: Unify TaskInterface::done(DoneResult) signal

Change the argument of TaskInterface::done() signal
from bool into DoneResult. Make it consistent with
other TaskTree API.

Introduce toDoneResult(bool success) helper.

Change-Id: I7b3041d7c1ed0317c76adbc1fd37448231e85f82
Reviewed-by: Qt CI Bot <[email protected]>
Reviewed-by: hjk <[email protected]>

3 files changed, 7 insertions, 5 deletions

diff --git a/src/plugins/languageclient/clientrequest.cpp b/src/plugins/languageclient/clientrequest.cpp
index 630a1b01940..4e221f1b9d4 100644
--- a/src/plugins/languageclient/clientrequest.cpp
+++ b/src/plugins/languageclient/clientrequest.cpp
@@ -4,13 +4,14 @@
 #include "clientrequest.h"
 
 using namespace LanguageServerProtocol;
+using namespace Tasking;
 
 namespace LanguageClient {
 
 ClientWorkspaceSymbolRequestTaskAdapter::ClientWorkspaceSymbolRequestTaskAdapter()
 {
     task()->setResponseCallback([this](const WorkspaceSymbolRequest::Response &response){
-        emit done(response.result().has_value());
+        emit done(toDoneResult(response.result().has_value()));
     });
 }
 
diff --git a/src/plugins/languageclient/currentdocumentsymbolsrequest.cpp b/src/plugins/languageclient/currentdocumentsymbolsrequest.cpp
index 2d272a72161..15506e0e99d 100644
--- a/src/plugins/languageclient/currentdocumentsymbolsrequest.cpp
+++ b/src/plugins/languageclient/currentdocumentsymbolsrequest.cpp
@@ -10,6 +10,7 @@
 
 using namespace Core;
 using namespace LanguageServerProtocol;
+using namespace Tasking;
 using namespace TextEditor;
 using namespace Utils;
 
@@ -24,7 +25,7 @@ void CurrentDocumentSymbolsRequest::start()
     TextDocument *document = TextDocument::currentTextDocument();
     Client *client = LanguageClientManager::clientForDocument(document);
     if (!client) {
-        emit done(false);
+        emit done(DoneResult::Error);
         return;
     }
 
@@ -34,7 +35,7 @@ void CurrentDocumentSymbolsRequest::start()
 
     const auto reportFailure = [this] {
         clearConnections();
-        emit done(false);
+        emit done(DoneResult::Error);
     };
 
     const auto updateSymbols = [this, currentUri, pathMapper](const DocumentUri &uri,
@@ -46,7 +47,7 @@ void CurrentDocumentSymbolsRequest::start()
         const FilePath filePath = pathMapper ? currentUri.toFilePath(pathMapper) : FilePath();
         m_currentDocumentSymbolsData = {filePath, pathMapper, symbols};
         clearConnections();
-        emit done(true);
+        emit done(DoneResult::Success);
     };
 
     m_connections.append(connect(EditorManager::instance(), &EditorManager::currentEditorChanged,
diff --git a/src/plugins/languageclient/currentdocumentsymbolsrequest.h b/src/plugins/languageclient/currentdocumentsymbolsrequest.h
index ef124154dfd..3ea7ee5f152 100644
--- a/src/plugins/languageclient/currentdocumentsymbolsrequest.h
+++ b/src/plugins/languageclient/currentdocumentsymbolsrequest.h
@@ -30,7 +30,7 @@ public:
     CurrentDocumentSymbolsData currentDocumentSymbolsData() const { return m_currentDocumentSymbolsData; }
 
 signals:
-    void done(bool success);
+    void done(Tasking::DoneResult result);
 
 private:
     void clearConnections();