diff options
| author | Christian Kandeler <[email protected]> | 2014-07-01 11:08:26 +0200 |
|---|---|---|
| committer | hjk <[email protected]> | 2014-07-01 11:52:08 +0200 |
| commit | 93304df0381cbeabf4c8435aec0ad55fbc7f8fe7 (patch) | |
| tree | 7cbe348b1e3f88041b7e159aa335031e2c41bfc8 /src/plugins/qbsprojectmanager/qbsinstallstep.h | |
| parent | 139449239c7cd63ab933d13e20b37cd717a45fe7 (diff) | |
Always pass Core::Id by value.
Currently we pass in some places by value, elsewhere by const ref and
for some weird reason also by const value in a lot of places. The latter
is particularly annoying, as it is also used in interfaces and therefore
forces all implementors to do the same, since leaving the "const" off is
causing compiler warnings with MSVC.
Change-Id: I65b87dc3cce0986b8a55ff6119cb752361027803
Reviewed-by: hjk <[email protected]>
Diffstat (limited to 'src/plugins/qbsprojectmanager/qbsinstallstep.h')
| -rw-r--r-- | src/plugins/qbsprojectmanager/qbsinstallstep.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/plugins/qbsprojectmanager/qbsinstallstep.h b/src/plugins/qbsprojectmanager/qbsinstallstep.h index 04c212969c6..63a802d8190 100644 --- a/src/plugins/qbsprojectmanager/qbsinstallstep.h +++ b/src/plugins/qbsprojectmanager/qbsinstallstep.h @@ -135,10 +135,10 @@ public: // used to show the list of possible additons to a target, returns a list of types QList<Core::Id> availableCreationIds(ProjectExplorer::BuildStepList *parent) const; // used to translate the types to names to display to the user - QString displayNameForId(const Core::Id id) const; + QString displayNameForId(Core::Id id) const; - bool canCreate(ProjectExplorer::BuildStepList *parent, const Core::Id id) const; - ProjectExplorer::BuildStep *create(ProjectExplorer::BuildStepList *parent, const Core::Id id); + bool canCreate(ProjectExplorer::BuildStepList *parent, Core::Id id) const; + ProjectExplorer::BuildStep *create(ProjectExplorer::BuildStepList *parent, Core::Id id); // used to recreate the runConfigurations when restoring settings bool canRestore(ProjectExplorer::BuildStepList *parent, const QVariantMap &map) const; ProjectExplorer::BuildStep *restore(ProjectExplorer::BuildStepList *parent, const QVariantMap &map); |