diff options
| author | hjk <[email protected]> | 2020-02-20 18:13:48 +0100 |
|---|---|---|
| committer | hjk <[email protected]> | 2020-02-21 11:11:18 +0000 |
| commit | 1714ecf8092533eaba196212d4f0feb581449ecf (patch) | |
| tree | ddb46e5f7b350cae39f4ba3c0a9bd00e57093e8e /src/plugins/qmakeprojectmanager/qmakemakestep.cpp | |
| parent | 8b563a63d47b3b09008c28d024ce5c14db954726 (diff) | |
ProjectExplorer: Remove Task::buildConfigurationMissingTask()
It should not be possible to trigger the condition. Except for MakeStep
the function is only called from real BuildSteps, that always live in
a BuildConfiguration.
A MakeStep could live in a DeployConfiguration, but that belongs to
a Target. That target always has a BuildConfiguration in case the
project type requires one. So not having a BuildConfiguration can only
happen when the project type doesn't require one, but then the
situation is not an error that should be notified as a Task.
Change-Id: I2a5d90fdadd3916d3dae6a0fdc6e6ab2010a8111
Reviewed-by: Christian Kandeler <[email protected]>
Diffstat (limited to 'src/plugins/qmakeprojectmanager/qmakemakestep.cpp')
| -rw-r--r-- | src/plugins/qmakeprojectmanager/qmakemakestep.cpp | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/plugins/qmakeprojectmanager/qmakemakestep.cpp b/src/plugins/qmakeprojectmanager/qmakemakestep.cpp index 38e076fc8d9..dbf1ed25691 100644 --- a/src/plugins/qmakeprojectmanager/qmakemakestep.cpp +++ b/src/plugins/qmakeprojectmanager/qmakemakestep.cpp @@ -65,8 +65,6 @@ QmakeMakeStep::QmakeMakeStep(BuildStepList *bsl, Core::Id id) bool QmakeMakeStep::init() { const auto bc = static_cast<QmakeBuildConfiguration *>(buildConfiguration()); - if (!bc) - emit addTask(Task::buildConfigurationMissingTask()); const Utils::CommandLine unmodifiedMake = effectiveMakeCommand(Execution); const Utils::FilePath makeExecutable = unmodifiedMake.executable(); |