QmlJS: Rework FakeMetaObjects to no longer contain pointers.

Having a duplicate prototype chain - once in FakeMetaObjects and once
in QmlObjectValues was unnecessary. Now FMOs don't contain references
which may allow other simplifications.

1 files changed, 2 insertions, 7 deletions

diff --git a/src/plugins/qmljstools/qmljsplugindumper.cpp b/src/plugins/qmljstools/qmljsplugindumper.cpp
index 7ab0d9bcb23..68d70a80869 100644
--- a/src/plugins/qmljstools/qmljsplugindumper.cpp
+++ b/src/plugins/qmljstools/qmljsplugindumper.cpp
@@ -139,16 +139,11 @@ static QString qmldumpFailedMessage(const QString &error)
 static QList<FakeMetaObject::ConstPtr> parseHelper(const QByteArray &qmlTypeDescriptions, QString *error)
 {
     QList<FakeMetaObject::ConstPtr> ret;
-    QHash<QString, FakeMetaObject::Ptr> newObjects;
+    QHash<QString, FakeMetaObject::ConstPtr> newObjects;
     *error = Interpreter::CppQmlTypesLoader::parseQmlTypeDescriptions(qmlTypeDescriptions, &newObjects);
 
     if (error->isEmpty()) {
-        // convert from QList<T *> to QList<const T *>
-        QHashIterator<QString, FakeMetaObject::Ptr> it(newObjects);
-        while (it.hasNext()) {
-            it.next();
-            ret.append(it.value());
-        }
+        ret = newObjects.values();
     }
     return ret;
 }