diff options
| author | Ulf Hermann <[email protected]> | 2013-11-05 11:38:50 +0100 |
|---|---|---|
| committer | Kai Koehne <[email protected]> | 2013-11-05 12:24:56 +0100 |
| commit | ac7fe92efe721fd495cbb71568551267e5de6cdc (patch) | |
| tree | 5d7350a6f1b6bb3acfe72e954d999711044aeaad /src/plugins/qmlprofiler/qmlprofilerclientmanager.cpp | |
| parent | 6bdb402f31084ba996cf5dcc34d1effbcb243d52 (diff) | |
Remove disconnectClientSignals() from ~QmlProfilerClientManager()
disconnectClientSignals only disconnects signals of objects that are
deleted directly afterwards. As deleting a QObject automatically
disconnects its signals it's unnecessary to explicitly do that before.
However, if QmlProfilerClientManager is deleted from the destructor of
QmlProfilerTool, receivers of those signals may have already been
deleted. This can lead to crashes.
Task-number: QTCREATORBUG-10634
Change-Id: I1e5ce7a6ac4b331fa423987e3a8faa3584b991d2
Reviewed-by: Kai Koehne <[email protected]>
Diffstat (limited to 'src/plugins/qmlprofiler/qmlprofilerclientmanager.cpp')
| -rw-r--r-- | src/plugins/qmlprofiler/qmlprofilerclientmanager.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/plugins/qmlprofiler/qmlprofilerclientmanager.cpp b/src/plugins/qmlprofiler/qmlprofilerclientmanager.cpp index d0fd1c77385..4c9c0810e56 100644 --- a/src/plugins/qmlprofiler/qmlprofilerclientmanager.cpp +++ b/src/plugins/qmlprofiler/qmlprofilerclientmanager.cpp @@ -95,7 +95,6 @@ QmlProfilerClientManager::QmlProfilerClientManager(QObject *parent) : QmlProfilerClientManager::~QmlProfilerClientManager() { - disconnectClientSignals(); delete d->connection; delete d->qmlclientplugin.data(); delete d->v8clientplugin.data(); |