diff options
| author | Ulf Hermann <[email protected]> | 2014-04-03 11:15:56 +0200 |
|---|---|---|
| committer | Ulf Hermann <[email protected]> | 2014-04-09 16:36:04 +0200 |
| commit | 9e802e3af1e21ecacc607daf9716f690fe0a73bf (patch) | |
| tree | 1da80b71b2dc07fcdd5ff06c0c8310fc70b7eac2 /src/plugins/qmlprofiler/qmlprofilerviewmanager.cpp | |
| parent | 38220ba4bb53ff5b6e2c8f431f0a76e1204d1b19 (diff) | |
QmlProfiler: Reduce the amount of useless signals on item selection
By passing signals with identification information of varying accurary
between the different views the event being selected could be changed
while it was selected. By checking the current selection against the
information given in the signal and not reselecting when it matches the
situation is improved.
Also, the selection methods are given more appropriate names. We hardly
ever want to select the "next" event, but rather the "best fitting" one.
Task-number: QTCREATORBUG-11945
Change-Id: I659b4929cb88f4c931a0893aa95a3bc92da5a23b
Reviewed-by: Kai Koehne <[email protected]>
Diffstat (limited to 'src/plugins/qmlprofiler/qmlprofilerviewmanager.cpp')
| -rw-r--r-- | src/plugins/qmlprofiler/qmlprofilerviewmanager.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/plugins/qmlprofiler/qmlprofilerviewmanager.cpp b/src/plugins/qmlprofiler/qmlprofilerviewmanager.cpp index 0f937b76911..a81528747b7 100644 --- a/src/plugins/qmlprofiler/qmlprofilerviewmanager.cpp +++ b/src/plugins/qmlprofiler/qmlprofilerviewmanager.cpp @@ -105,8 +105,8 @@ void QmlProfilerViewManager::createViews() d->profilerModelManager); connect(d->eventsView, SIGNAL(gotoSourceLocation(QString,int,int)), this, SIGNAL(gotoSourceLocation(QString,int,int))); - connect(d->eventsView, SIGNAL(eventSelectedByHash(QString)), d->traceView, - SLOT(selectNextEventByHash(QString))); + connect(d->eventsView, SIGNAL(eventSelectedByHash(QString)), + d->traceView, SLOT(selectByHash(QString))); connect(d->traceView, SIGNAL(gotoSourceLocation(QString,int,int)), d->eventsView, SLOT(selectBySourceLocation(QString,int,int))); @@ -117,7 +117,7 @@ void QmlProfilerViewManager::createViews() connect(d->traceView, SIGNAL(gotoSourceLocation(QString,int,int)), d->v8profilerView, SLOT(selectBySourceLocation(QString,int,int))); connect(d->v8profilerView, SIGNAL(gotoSourceLocation(QString,int,int)), - d->traceView, SLOT(selectNextEventByLocation(QString,int,int))); + d->traceView, SLOT(selectBySourceLocation(QString,int,int))); connect(d->v8profilerView, SIGNAL(gotoSourceLocation(QString,int,int)), d->eventsView, SLOT(selectBySourceLocation(QString,int,int))); connect(d->eventsView, SIGNAL(gotoSourceLocation(QString,int,int)), |