diff options
author | hjk <[email protected]> | 2018-04-06 14:55:56 +0200 |
---|---|---|
committer | hjk <[email protected]> | 2018-04-09 08:49:09 +0000 |
commit | 11336fb60458c62f41077318d119910cf1b193a4 (patch) | |
tree | b537e6d390bf6eb5be1f5f2d35b6acf99d3976a9 /src/plugins/qmlprojectmanager | |
parent | ef79078db2360b9f532d1bec5c01763bfa2f21a7 (diff) |
QmlProject: Move RunConfigurationFactory close to RunConfiguration
No need to have a dozen lines of code in a separate translation
unit and more in line with what others do nowadays.
Change-Id: I765535d1484805bc3005fe23bfd4992a96a80e9c
Reviewed-by: hjk <[email protected]>
Diffstat (limited to 'src/plugins/qmlprojectmanager')
4 files changed, 20 insertions, 6 deletions
diff --git a/src/plugins/qmlprojectmanager/qmlprojectmanager.pro b/src/plugins/qmlprojectmanager/qmlprojectmanager.pro index 2a12d7a6313..173e3886dbc 100644 --- a/src/plugins/qmlprojectmanager/qmlprojectmanager.pro +++ b/src/plugins/qmlprojectmanager/qmlprojectmanager.pro @@ -10,7 +10,6 @@ HEADERS += qmlproject.h \ qmlprojectconstants.h \ qmlprojectnodes.h \ qmlprojectrunconfiguration.h \ - qmlprojectrunconfigurationfactory.h \ qmlprojectmanager_global.h \ qmlprojectmanagerconstants.h \ qmlprojectrunconfigurationwidget.h @@ -20,7 +19,6 @@ SOURCES += qmlproject.cpp \ qmlprojectplugin.cpp \ qmlprojectnodes.cpp \ qmlprojectrunconfiguration.cpp \ - qmlprojectrunconfigurationfactory.cpp \ qmlprojectrunconfigurationwidget.cpp RESOURCES += qmlproject.qrc diff --git a/src/plugins/qmlprojectmanager/qmlprojectmanager.qbs b/src/plugins/qmlprojectmanager/qmlprojectmanager.qbs index b6dcdcd5f5a..fcf34e30c8b 100644 --- a/src/plugins/qmlprojectmanager/qmlprojectmanager.qbs +++ b/src/plugins/qmlprojectmanager/qmlprojectmanager.qbs @@ -23,7 +23,6 @@ QtcPlugin { "qmlprojectnodes.cpp", "qmlprojectnodes.h", "qmlprojectplugin.cpp", "qmlprojectplugin.h", "qmlprojectrunconfiguration.cpp", "qmlprojectrunconfiguration.h", - "qmlprojectrunconfigurationfactory.cpp", "qmlprojectrunconfigurationfactory.h", "qmlprojectrunconfigurationwidget.cpp", "qmlprojectrunconfigurationwidget.h" ] } diff --git a/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.cpp b/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.cpp index 6118e7651f4..76cba328238 100644 --- a/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.cpp +++ b/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.cpp @@ -48,8 +48,6 @@ using namespace Core; using namespace ProjectExplorer; using namespace QtSupport; -using namespace QmlProjectManager::Internal; - namespace QmlProjectManager { const char M_CURRENT_FILE[] = "CurrentFile"; @@ -146,7 +144,7 @@ QString QmlProjectRunConfiguration::commandLineArguments() const QWidget *QmlProjectRunConfiguration::createConfigurationWidget() { - return wrapWidget(new QmlProjectRunConfigurationWidget(this)); + return wrapWidget(new Internal::QmlProjectRunConfigurationWidget(this)); } Utils::OutputFormatter *QmlProjectRunConfiguration::createOutputFormatter() const @@ -297,4 +295,14 @@ void QmlProjectRunConfiguration::updateEnabledState() } } +namespace Internal { + +QmlProjectRunConfigurationFactory::QmlProjectRunConfigurationFactory() + : FixedRunConfigurationFactory(QmlProjectRunConfiguration::tr("QML Scene"), false) +{ + registerRunConfiguration<QmlProjectRunConfiguration>(Constants::QML_SCENE_RC_ID); + addSupportedProjectType(QmlProjectManager::Constants::QML_PROJECT_ID); +} + +} // namespace Internal } // namespace QmlProjectManager diff --git a/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.h b/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.h index 78a8cfbbc22..dc89200222b 100644 --- a/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.h +++ b/src/plugins/qmlprojectmanager/qmlprojectrunconfiguration.h @@ -86,4 +86,13 @@ private: QString m_qmlViewerArgs; }; +namespace Internal { + +class QmlProjectRunConfigurationFactory : public ProjectExplorer::FixedRunConfigurationFactory +{ +public: + QmlProjectRunConfigurationFactory(); +}; + +} // namespace Internal } // namespace QmlProjectManager |