aboutsummaryrefslogtreecommitdiffstats
path: root/src/plugins/valgrind/valgrind.qbs
diff options
context:
space:
mode:
authorJarek Kobus <[email protected]>2023-08-09 12:40:40 +0200
committerJarek Kobus <[email protected]>2023-08-14 14:42:16 +0000
commit5bce234986201691839928a0e9a3e5b7bfc023af (patch)
tree11f3419659735f48a1bdcf6b36527e53792db15e /src/plugins/valgrind/valgrind.qbs
parent3ab2da691df5f43b94effc6266c7642df65fdcf0 (diff)
Valgrind: Refactor Parser
Make it implicitly threaded. Get rid of ThreadedParser. Don't move QTcpSocket instances, received by QTcpServer::nextPendingConnection(), into another thread, as docs says it's not safe. Use wait condition for waiting for new data. Don't potentially leak the Parser in loadXmlLogFile(): store a unique pointer to the running parser. Introduce Parser::setData() method and use it with QFile device in loadXmlLogFile(). Pass QAbstractSocket into the parser instead of QIODevice and get rid of downcasting. The QIODevice couldn't really work with non-socket and non-file devices (like e.g. QProcess), as it lacks general error and finished reporting signals (it has only general readyRead() signal). Change-Id: I9352aec694564d4d2a26898841ed964bed470d82 Reviewed-by: <[email protected]> Reviewed-by: hjk <[email protected]>
Diffstat (limited to 'src/plugins/valgrind/valgrind.qbs')
-rw-r--r--src/plugins/valgrind/valgrind.qbs1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/plugins/valgrind/valgrind.qbs b/src/plugins/valgrind/valgrind.qbs
index 378f0a57bb8..065006352e3 100644
--- a/src/plugins/valgrind/valgrind.qbs
+++ b/src/plugins/valgrind/valgrind.qbs
@@ -69,7 +69,6 @@ QtcPlugin {
"stackmodel.cpp", "stackmodel.h",
"status.cpp", "status.h",
"suppression.cpp", "suppression.h",
- "threadedparser.cpp", "threadedparser.h",
]
}