VCS[git]: Make push/pull synchronous commands.

..for timeout handling to take effect. Also,
log window will update continuously.

Task-number: QTCREATORBUG-777

1 files changed, 8 insertions, 4 deletions

diff --git a/src/plugins/vcsbase/vcsbaseplugin.cpp b/src/plugins/vcsbase/vcsbaseplugin.cpp
index 6f5d24c48f1..957395c0074 100644
--- a/src/plugins/vcsbase/vcsbaseplugin.cpp
+++ b/src/plugins/vcsbase/vcsbaseplugin.cpp
@@ -778,10 +778,14 @@ Utils::SynchronousProcessResponse
     // Run!
     const Utils::SynchronousProcessResponse sp_resp = process.run(binary, arguments);
 
-    // Fail message?
-    if (sp_resp.result != Utils::SynchronousProcessResponse::Finished &&
-        (!(flags & SuppressFailMessageInLogWindow)))
-        outputWindow->appendError(sp_resp.exitMessage(binary, timeOutMS));
+    // Success/Fail message in appropriate window?
+    if (sp_resp.result == Utils::SynchronousProcessResponse::Finished) {
+        if (flags & ShowSuccessMessage)
+            outputWindow->append(sp_resp.exitMessage(binary, timeOutMS));
+    } else {
+        if (!(flags & SuppressFailMessageInLogWindow))
+            outputWindow->appendError(sp_resp.exitMessage(binary, timeOutMS));
+    }
 
     return sp_resp;
 }