ProjectExplorer: Fix RunDeviceKitAspect layout again

Commit 8eb1d52e1c2b92ba5f68d3ae5685370dfcd5eeba fixed the target
selector, but broke the kit settings page.

Change-Id: I6364f4ac3b3a201df1e376d863bcd16340e2b14e
Reviewed-by: hjk <[email protected]>

1 files changed, 3 insertions, 4 deletions

diff --git a/src/plugins/projectexplorer/devicesupport/devicekitaspects.cpp b/src/plugins/projectexplorer/devicesupport/devicekitaspects.cpp
index 22f1e918928..1cfc074cfb5 100644
--- a/src/plugins/projectexplorer/devicesupport/devicekitaspects.cpp
+++ b/src/plugins/projectexplorer/devicesupport/devicekitaspects.cpp
@@ -188,10 +188,8 @@ private:
 
     void addToInnerLayout(Layouting::Layout &parentItem) override
     {
-        Layouting::Layout &layout = parentItem;
         if (const QList<KitAspect *> embedded = aspectsToEmbed(); !embedded.isEmpty()) {
-            layout = Layouting::Layout(new QHBoxLayout);
-            parentItem.addItem(layout);
+            Layouting::Layout layout(new QHBoxLayout);
             layout.addItem(Tr::tr("Type:"));
             embedded.first()->addToInnerLayout(layout);
             layout.addItem(Tr::tr("Device:"));
@@ -199,8 +197,9 @@ private:
             QSizePolicy p = comboBoxes().first()->sizePolicy();
             p.setHorizontalStretch(1);
             comboBoxes().first()->setSizePolicy(p);
+            parentItem.addItem(layout);
         } else {
-            KitAspect::addToInnerLayout(layout);
+            KitAspect::addToInnerLayout(parentItem);
         }
     }
 };