diff options
| author | Alessandro Portale <[email protected]> | 2024-09-19 17:50:30 +0200 |
|---|---|---|
| committer | Alessandro Portale <[email protected]> | 2024-09-20 08:03:52 +0000 |
| commit | 2eb97663c72e55195b3b3d7a58777af16069d522 (patch) | |
| tree | e0b24a64c9cc1792f2204cbedb36e9d0c3d132c7 /src | |
| parent | 1dd2a08eac93759f84e58c5cebb49925968981f4 (diff) | |
ExtensionManager: Guard usage of __DATE__
Use __DATE__ only if no reproducible build is required.
Don't show a date in the ExtensionManager if there is none.
Amends: 07000281daf7777293d5236361b7e9a322482ad7
Change-Id: I419ce742c6c7358d7a294ea4d239aca07ef7890e
Reviewed-by: Eike Ziller <[email protected]>
Diffstat (limited to 'src')
| -rw-r--r-- | src/plugins/extensionmanager/extensionmanagerwidget.cpp | 6 | ||||
| -rw-r--r-- | src/plugins/extensionmanager/extensionsmodel.cpp | 2 |
2 files changed, 7 insertions, 1 deletions
diff --git a/src/plugins/extensionmanager/extensionmanagerwidget.cpp b/src/plugins/extensionmanager/extensionmanagerwidget.cpp index dcf065fcd27..34c96de5f0b 100644 --- a/src/plugins/extensionmanager/extensionmanagerwidget.cpp +++ b/src/plugins/extensionmanager/extensionmanagerwidget.cpp @@ -609,7 +609,11 @@ void ExtensionManagerWidget::updateView(const QModelIndex ¤t) }; const QDate dateUpdated = current.data(RoleDateUpdated).toDate(); - m_dateUpdated->setText(dateUpdated.toString()); + const bool hasDateUpdated = dateUpdated.isValid(); + if (hasDateUpdated) + m_dateUpdated->setText(dateUpdated.toString()); + m_dateUpdatedTitle->setVisible(hasDateUpdated); + m_dateUpdated->setVisible(hasDateUpdated); const QStringList tags = current.data(RoleTags).toStringList(); m_tags->setTags(tags); diff --git a/src/plugins/extensionmanager/extensionsmodel.cpp b/src/plugins/extensionmanager/extensionsmodel.cpp index 2c4100f2239..b3d63073f90 100644 --- a/src/plugins/extensionmanager/extensionsmodel.cpp +++ b/src/plugins/extensionmanager/extensionsmodel.cpp @@ -209,8 +209,10 @@ QVariant ExtensionsModelPrivate::dataFromLocalPlugin(int index, int role) const : QStringList(platformsPattern); return platforms; } +#ifdef QTC_SHOW_BUILD_DATE case RoleDateUpdated: return QDate::fromString(QLatin1String(__DATE__), "MMM dd yyyy"); +#endif case RoleVendor: return pluginSpec->vendor(); case RoleVendorId: |