ClearCase: Remove pointless function argument

Change-Id: I5545090a5f28994b126cedd97496678d891f5184
Coverity-Id: 1568460
Reviewed-by: hjk <[email protected]>

2 files changed, 4 insertions, 6 deletions

diff --git a/src/plugins/clearcase/clearcasesync.cpp b/src/plugins/clearcase/clearcasesync.cpp
index a61408e75ac..cc9d837fd2e 100644
--- a/src/plugins/clearcase/clearcasesync.cpp
+++ b/src/plugins/clearcase/clearcasesync.cpp
@@ -118,10 +118,9 @@ void ClearCaseSync::processCleartoolLsLine(const QDir &viewRootDir, const QStrin
         ClearCasePlugin::setStatus(absFile, FileStatus::CheckedIn, true);
 }
 
-void ClearCaseSync::updateTotalFilesCount(const Key &view, ClearCaseSettings settings,
-                                          const int processed)
+void ClearCaseSync::updateTotalFilesCount(const Key &view, const int processed)
 {
-    settings = ClearCasePlugin::settings(); // Might have changed while task was running
+    ClearCaseSettings settings = ClearCasePlugin::settings();
     settings.totalFiles[view] = processed;
     ClearCasePlugin::setSettings(settings);
 }
@@ -180,7 +179,7 @@ void ClearCaseSync::syncSnapshotView(QPromise<void> &promise, QStringList &files
         updateStatusForNotManagedFiles(files);
         promise.setProgressValue(totalFileCount + 1);
         if (!hot)
-            updateTotalFilesCount(view, settings, totalProcessed);
+            updateTotalFilesCount(view, totalProcessed);
     }
 }
 
diff --git a/src/plugins/clearcase/clearcasesync.h b/src/plugins/clearcase/clearcasesync.h
index a93d1852c06..7a303e6593b 100644
--- a/src/plugins/clearcase/clearcasesync.h
+++ b/src/plugins/clearcase/clearcasesync.h
@@ -26,8 +26,7 @@ public:
     void invalidateStatus(const QDir &viewRootDir, const QStringList &files);
     void invalidateStatusAllFiles();
     void processCleartoolLsLine(const QDir &viewRootDir, const QString &buffer);
-    void updateTotalFilesCount(const Utils::Key &view, ClearCaseSettings settings,
-                               const int processed);
+    void updateTotalFilesCount(const Utils::Key &view, const int processed);
     void updateStatusForNotManagedFiles(const QStringList &files);
 
     void syncDynamicView(QPromise<void> &promise, const ClearCaseSettings &settings);