diff options
Diffstat (limited to 'src/plugins/clangtools')
-rw-r--r-- | src/plugins/clangtools/clangtoolrunner.cpp | 8 | ||||
-rw-r--r-- | src/plugins/clangtools/clangtoolrunner.h | 6 | ||||
-rw-r--r-- | src/plugins/clangtools/executableinfo.cpp | 4 |
3 files changed, 11 insertions, 7 deletions
diff --git a/src/plugins/clangtools/clangtoolrunner.cpp b/src/plugins/clangtools/clangtoolrunner.cpp index 9a207a82d48..68ca3b9a8db 100644 --- a/src/plugins/clangtools/clangtoolrunner.cpp +++ b/src/plugins/clangtools/clangtoolrunner.cpp @@ -60,14 +60,14 @@ static QString finishedWithBadExitCode(const QString &name, int exitCode) } ClangToolRunner::ClangToolRunner(QObject *parent) - : QObject(parent), m_process(new Utils::QtcProcess) + : QObject(parent), m_process(new QtcProcess) {} ClangToolRunner::~ClangToolRunner() { if (m_process->state() != QProcess::NotRunning) { // asking politly to terminate costs ~300 ms on windows so skip the courtasy and direct kill the process - if (Utils::HostOsInfo::isWindowsHost()) { + if (HostOsInfo::isWindowsHost()) { m_process->kill(); m_process->waitForFinished(100); } else { @@ -147,10 +147,10 @@ bool ClangToolRunner::run(const QString &fileToAnalyze, const QStringList &compi void ClangToolRunner::onProcessFinished() { - if (m_process->result() == QtcProcess::FinishedWithSuccess) { + if (m_process->result() == ProcessResult::FinishedWithSuccess) { qCDebug(LOG).noquote() << "Output:\n" << m_process->stdOut(); emit finishedWithSuccess(m_fileToAnalyze); - } else if (m_process->result() == QtcProcess::FinishedWithError) { + } else if (m_process->result() == ProcessResult::FinishedWithError) { emit finishedWithFailure(finishedWithBadExitCode(m_name, m_process->exitCode()), commandlineAndOutput()); } else { // == QProcess::CrashExit diff --git a/src/plugins/clangtools/clangtoolrunner.h b/src/plugins/clangtools/clangtoolrunner.h index 45ed11387f4..38bac4378e5 100644 --- a/src/plugins/clangtools/clangtoolrunner.h +++ b/src/plugins/clangtools/clangtoolrunner.h @@ -27,10 +27,14 @@ #include "clangtoolslogfilereader.h" -#include <utils/qtcprocess.h> +#include <utils/commandline.h> + +#include <QProcess> #include <memory> +namespace Utils { class QtcProcess; } + namespace ClangTools { namespace Internal { diff --git a/src/plugins/clangtools/executableinfo.cpp b/src/plugins/clangtools/executableinfo.cpp index 45b2ea8e2cc..9277e54df9f 100644 --- a/src/plugins/clangtools/executableinfo.cpp +++ b/src/plugins/clangtools/executableinfo.cpp @@ -55,9 +55,9 @@ static QString runExecutable(const Utils::CommandLine &commandLine, QueryFailMod cpp.setCommand(commandLine); cpp.runBlocking(); - if (cpp.result() != QtcProcess::FinishedWithSuccess + if (cpp.result() != ProcessResult::FinishedWithSuccess && (queryFailMode == QueryFailMode::Noisy - || cpp.result() != QtcProcess::FinishedWithError)) { + || cpp.result() != ProcessResult::FinishedWithError)) { Core::MessageManager::writeFlashing(cpp.exitMessage()); Core::MessageManager::writeFlashing(QString::fromUtf8(cpp.allRawOutput())); return {}; |