Speed up stack trace generation for the JIT

It turns out that in QML it is not unusual that during early binding
evaluations due to the undefined order, the evaluation tries to look up
properties in objects that aren't initialized yet and thus exceptions are
thrown. Eeach thrown exception saves a stack trace, which is expensive to
generate when using the JIT, as it does full stack unwinding.

This patch implements a more light-weight approach by storing the instruction
pointer in the context before leaving JIT generated code.

Change-Id: I95e1cfd01179247dfc2c1df949828f474a23161b
Reviewed-by: Lars Knoll <[email protected]>

1 files changed, 20 insertions, 0 deletions

diff --git a/src/qml/compiler/qv4isel_masm_p.h b/src/qml/compiler/qv4isel_masm_p.h
index 4d1114e756..02ddd158a9 100644
--- a/src/qml/compiler/qv4isel_masm_p.h
+++ b/src/qml/compiler/qv4isel_masm_p.h
@@ -430,7 +430,25 @@ public:
         V4IR::BasicBlock *block;
     };
 
+    void saveInstructionPointer(RegisterID freeScratchRegister) {
+        Address ipAddr(ContextRegister, qOffsetOf(QV4::ExecutionContext, jitInstructionPointer));
+        RegisterID sourceRegister = freeScratchRegister;
+
+#if CPU(X86_64) || CPU(X86)
+        callToRetrieveIP();
+        peek(sourceRegister);
+        pop();
+#elif CPU(ARM)
+        move(JSC::ARMRegisters::pc, sourceRegister);
+#else
+#error "Port me!"
+#endif
+
+        storePtr(sourceRegister, ipAddr);
+    }
+
     void callAbsolute(const char* functionName, FunctionPtr function) {
+        saveInstructionPointer(ScratchRegister);
         CallToLink ctl;
         ctl.call = call();
         ctl.externalFunction = function;
@@ -439,11 +457,13 @@ public:
     }
 
     void callAbsolute(const char* /*functionName*/, Address addr) {
+        saveInstructionPointer(ScratchRegister);
         call(addr);
     }
 
     void callAbsolute(const char* /*functionName*/, const RelativeCall &relativeCall)
     {
+        saveInstructionPointer(ScratchRegister);
         call(relativeCall.addr);
     }