aboutsummaryrefslogtreecommitdiffstats
path: root/src/quick/items/qquickmousearea_p.h
diff options
context:
space:
mode:
authorShawn Rutledge <[email protected]>2020-11-18 23:55:25 +0100
committerShawn Rutledge <[email protected]>2020-11-19 15:17:39 +0000
commitd68419faf424df2492425baca789742f1a239af3 (patch)
tree2b5aaf3554649f398a27737be0953d87323ecbd2 /src/quick/items/qquickmousearea_p.h
parent2e7330f5797c90b4461d638fc839a7ab92906d30 (diff)
Remove QQuickItem::windowDeactivateEvent(); cancel grabs instead
When a QQuickWindow is deactivated, visiting every item in the entire scene to tell them the news isn't very efficient, especially considering that the only item that overrode this virtual function has been QQMouseArea, throughout the lifetime of Qt 5. If it's important to cancel grabs of MouseAreas, then it's equally important to cancel grabs of MultiPointTouchArea, pointer handlers, etc. It should be OK to delete the virtual function since it was never documented, and marked \internal, so hopefully no users are depending on it. The existing tst_QQuickMouseArea::pressedCanceledOnWindowDeactivate() test continues to pass, which proves that the WindowDeactivate event still has the desired effect on MouseArea. Change-Id: I0109370aba14096fb7777a83cf1b6763ac58013f Reviewed-by: Richard Moe Gustavsen <[email protected]> Reviewed-by: Volker Hilsheimer <[email protected]>
Diffstat (limited to 'src/quick/items/qquickmousearea_p.h')
-rw-r--r--src/quick/items/qquickmousearea_p.h1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/quick/items/qquickmousearea_p.h b/src/quick/items/qquickmousearea_p.h
index c368f43b30..e0f7397f06 100644
--- a/src/quick/items/qquickmousearea_p.h
+++ b/src/quick/items/qquickmousearea_p.h
@@ -180,7 +180,6 @@ protected:
#endif
bool childMouseEventFilter(QQuickItem *i, QEvent *e) override;
void timerEvent(QTimerEvent *event) override;
- void windowDeactivateEvent() override;
void geometryChange(const QRectF &newGeometry, const QRectF &oldGeometry) override;
void itemChange(ItemChange change, const ItemChangeData& value) override;