aboutsummaryrefslogtreecommitdiffstats
path: root/tests/auto/quickdialogs/qquickfolderdialogimpl/tst_qquickfolderdialogimpl.cpp
diff options
context:
space:
mode:
authorOliver Eftevaag <[email protected]>2024-01-25 14:45:04 +0100
committerOliver Eftevaag <[email protected]>2024-05-27 16:12:39 +0200
commit2874586cc848397ab649b49b2d39daf4c86d95fc (patch)
treebd640c17a5b2f050b863437425851a200cb503a3 /tests/auto/quickdialogs/qquickfolderdialogimpl/tst_qquickfolderdialogimpl.cpp
parentbd8d86c341f3791978804446f79adb36cd656b19 (diff)
Give QQuickPopup the ability to create top-level windows
Desktop users typically expect dialogs to be top level windows, but there can also be advantages to having other types of popups, such as Menus, and ToolTips, be top level windows as well. Currently the QQuickPopup class is tightly coupled with the QQuickPopupItem which it creates, and forwards a bunch of properties to. But we want Popup to seamlessly create a new window, which renders the popup item. This should serve as a new feature, which is primarily targeted for desktop users, and should not replace the old behavior, since having the popup item in the same window will likely be preferred for mobile and embedded users. The default behavior will now be to create a popup window, when the QML application is running on a desktop system (determined by the platformIntegrations capabilities). It's also possible to opt out of this new behavior, by setting the AA_DontUsePopupWindows application attribute flag. The dialogs in QtQuick.Dialogs should now also appear in their own dedicated window, since they were using QQuickDialog behind the scenes. The combobox popup, will also appear in its own window. Some changes, such as modality, won't take effect until the window is reopened, since the window is destroyed/recreated on visibility changes. Done-with: Ed Cooke <[email protected]> Task-number: QTBUG-121363 Change-Id: I21f4fd1f922219359d3258854bdcdc9be6980f4f Reviewed-by: Richard Moe Gustavsen <[email protected]>
Diffstat (limited to 'tests/auto/quickdialogs/qquickfolderdialogimpl/tst_qquickfolderdialogimpl.cpp')
-rw-r--r--tests/auto/quickdialogs/qquickfolderdialogimpl/tst_qquickfolderdialogimpl.cpp1
1 files changed, 0 insertions, 1 deletions
diff --git a/tests/auto/quickdialogs/qquickfolderdialogimpl/tst_qquickfolderdialogimpl.cpp b/tests/auto/quickdialogs/qquickfolderdialogimpl/tst_qquickfolderdialogimpl.cpp
index 2afcd81a44..f4e35a37bf 100644
--- a/tests/auto/quickdialogs/qquickfolderdialogimpl/tst_qquickfolderdialogimpl.cpp
+++ b/tests/auto/quickdialogs/qquickfolderdialogimpl/tst_qquickfolderdialogimpl.cpp
@@ -814,7 +814,6 @@ void tst_QQuickFolderDialogImpl::itemsDisabledWhenNecessary()
QVERIFY(breadcrumbBar->textField()->isVisible());
QCOMPARE(openButton->isEnabled(), false);
#endif
-
// Hide it with the escape key. The Open button should now be enabled.
QTest::keyClick(dialogHelper.window(), Qt::Key_Escape);
QVERIFY(!breadcrumbBar->textField()->isVisible());