1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
|
// Copyright (C) 2019 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0
#include <QCoreApplication>
#include <QFile>
#include <QTextStream>
#include <QtQml/private/qqmljslexer_p.h>
#include <QtQml/private/qqmljsparser_p.h>
#include <QtQml/private/qqmljsengine_p.h>
#include <QtQml/private/qqmljsastvisitor_p.h>
#include <QtQml/private/qqmljsast_p.h>
#include <QtQmlDom/private/qqmldomitem_p.h>
#include <QtQmlDom/private/qqmldomexternalitems_p.h>
#include <QtQmlDom/private/qqmldomtop_p.h>
#include <QtQmlDom/private/qqmldomoutwriter_p.h>
#if QT_CONFIG(commandlineparser)
# include <QCommandLineParser>
#endif
#include <QtQmlToolingSettings/private/qqmltoolingsettings_p.h>
#include <QtQmlFormat/private/qqmlformatsettings_p.h>
#include <QtQmlFormat/private/qqmlformatoptions_p.h>
using namespace QQmlJS::Dom;
static void logParsingErrors(const DomItem &fileItem, const QString &filename)
{
fileItem.iterateErrors(
[](const DomItem &, const ErrorMessage &msg) {
errorToQDebug(msg);
return true;
},
true);
qWarning().noquote() << "Failed to parse" << filename;
}
// TODO
// refactor this workaround. ExternalOWningItem is not recognized as an owning type
// in ownerAs.
static std::shared_ptr<ExternalOwningItem> getFileItemOwner(const DomItem &fileItem)
{
std::shared_ptr<ExternalOwningItem> filePtr = nullptr;
switch (fileItem.internalKind()) {
case DomType::JsFile:
filePtr = fileItem.ownerAs<JsFile>();
break;
default:
filePtr = fileItem.ownerAs<QmlFile>();
break;
}
return filePtr;
}
// TODO refactor
// Introduce better encapsulation and separation of concerns and move to DOM API
// returns a DomItem corresponding to the loaded file and bool indicating the validity of the file
static std::pair<DomItem, bool> parse(const QString &filename)
{
auto envPtr =
DomEnvironment::create(QStringList(),
QQmlJS::Dom::DomEnvironment::Option::SingleThreaded
| QQmlJS::Dom::DomEnvironment::Option::NoDependencies);
// placeholder for a node
// containing metadata (ExternalItemInfo) about the loaded file
DomItem fMetadataItem;
envPtr->loadFile(FileToLoad::fromFileSystem(envPtr, filename),
// callback called when everything is loaded that receives the
// loaded external file pair (path, oldValue, newValue)
[&fMetadataItem](Path, const DomItem &, const DomItem &extItemInfo) {
fMetadataItem = extItemInfo;
});
auto fItem = fMetadataItem.fileObject();
auto filePtr = getFileItemOwner(fItem);
return { fItem, filePtr && filePtr->isValid() };
}
static bool parseFile(const QString &filename, const QQmlFormatOptions &options)
{
const auto [fileItem, validFile] = parse(filename);
if (!validFile) {
logParsingErrors(fileItem, filename);
return false;
}
// Turn AST back into source code
if (options.isVerbose())
qWarning().noquote() << "Dumping" << filename;
const auto &code = getFileItemOwner(fileItem)->code();
auto lwOptions = options.optionsForCode(code);
WriteOutChecks checks = WriteOutCheck::Default;
//Disable writeOutChecks for some usecases
if (options.forceEnabled() ||
code.size() > 32000 ||
fileItem.internalKind() == DomType::JsFile) {
checks = WriteOutCheck::None;
}
bool res = false;
if (options.isInplace()) {
if (options.isVerbose())
qWarning().noquote() << "Writing to file" << filename;
FileWriter fw;
const unsigned numberOfBackupFiles = 0;
res = fileItem.writeOut(filename, numberOfBackupFiles, lwOptions, &fw, checks);
} else {
QFile out;
if (out.open(stdout, QIODevice::WriteOnly)) {
LineWriter lw([&out](QStringView s) { out.write(s.toUtf8()); }, filename, lwOptions);
OutWriter ow(lw);
res = fileItem.writeOutForFile(ow, checks);
ow.flush();
} else {
res = false;
}
}
return res;
}
QQmlFormatOptions buildCommandLineOptions(const QCoreApplication &app)
{
#if QT_CONFIG(commandlineparser)
QCommandLineParser parser;
parser.setApplicationDescription("Formats QML files according to the QML Coding Conventions.");
parser.addHelpOption();
parser.addVersionOption();
parser.addOption(
QCommandLineOption({ "V", "verbose" },
QStringLiteral("Verbose mode. Outputs more detailed information.")));
QCommandLineOption writeDefaultsOption(
QStringList() << "write-defaults",
QLatin1String("Writes defaults settings to .qmlformat.ini and exits (Warning: This "
"will overwrite any existing settings and comments!)"));
parser.addOption(writeDefaultsOption);
QCommandLineOption ignoreSettings(QStringList() << "ignore-settings",
QLatin1String("Ignores all settings files and only takes "
"command line options into consideration"));
parser.addOption(ignoreSettings);
parser.addOption(QCommandLineOption(
{ "i", "inplace" },
QStringLiteral("Edit file in-place instead of outputting to stdout.")));
parser.addOption(QCommandLineOption({ "f", "force" },
QStringLiteral("Continue even if an error has occurred.")));
parser.addOption(
QCommandLineOption({ "t", "tabs" }, QStringLiteral("Use tabs instead of spaces.")));
parser.addOption(QCommandLineOption({ "w", "indent-width" },
QStringLiteral("How many spaces are used when indenting."),
"width", "4"));
parser.addOption(QCommandLineOption({ "n", "normalize" },
QStringLiteral("Reorders the attributes of the objects "
"according to the QML Coding Guidelines.")));
parser.addOption(QCommandLineOption(
{ "F", "files" }, QStringLiteral("Format all files listed in file, in-place"), "file"));
parser.addOption(QCommandLineOption(
{ "l", "newline" },
QStringLiteral("Override the new line format to use (native macos unix windows)."),
"newline", "native"));
parser.addOption(QCommandLineOption(QStringList() << "objects-spacing", QStringLiteral("Ensure spaces between objects (only works with normalize option).")));
parser.addOption(QCommandLineOption(QStringList() << "functions-spacing", QStringLiteral("Ensure spaces between functions (only works with normalize option).")));
parser.addPositionalArgument("filenames", "files to be processed by qmlformat");
parser.process(app);
if (parser.isSet(writeDefaultsOption)) {
QQmlFormatOptions options;
options.setWriteDefaultSettingsEnabled(true);
options.setIsValid(true);
return options;
}
bool indentWidthOkay = false;
const int indentWidth = parser.value("indent-width").toInt(&indentWidthOkay);
if (!indentWidthOkay) {
QQmlFormatOptions options;
options.addError("Error: Invalid value passed to -w");
return options;
}
QStringList files;
if (!parser.value("files").isEmpty()) {
QFile file(parser.value("files"));
if (file.open(QIODevice::Text | QIODevice::ReadOnly)) {
QTextStream in(&file);
while (!in.atEnd()) {
QString file = in.readLine();
if (file.isEmpty())
continue;
files.push_back(file);
}
}
}
QQmlFormatOptions options;
options.setIsVerbose(parser.isSet("verbose"));
options.setIsInplace(parser.isSet("inplace"));
options.setForceEnabled(parser.isSet("force"));
options.setTabsEnabled(parser.isSet("tabs"));
options.setIgnoreSettingsEnabled(parser.isSet("ignore-settings"));
options.setNormalizeEnabled(parser.isSet("normalize"));
options.setObjectsSpacing(parser.isSet("objects-spacing"));
options.setFunctionsSpacing(parser.isSet("functions-spacing"));
options.setIsValid(true);
options.setIndentWidth(indentWidth);
options.setIndentWidthSet(parser.isSet("indent-width"));
options.setNewline(QQmlFormatOptions::parseEndings(parser.value("newline"))); // TODO
options.setFiles(files);
options.setArguments(parser.positionalArguments());
return options;
#else
return Options {};
#endif
}
int main(int argc, char *argv[])
{
QCoreApplication app(argc, argv);
QCoreApplication::setApplicationName("qmlformat");
QCoreApplication::setApplicationVersion(QT_VERSION_STR);
QQmlFormatSettings settings(QLatin1String("qmlformat"));
const auto options = buildCommandLineOptions(app);
if (!options.isValid()) {
for (const auto &error : options.errors()) {
qWarning().noquote() << error;
}
return -1;
}
if (options.writeDefaultSettingsEnabled())
return settings.writeDefaults() ? 0 : -1;
auto getSettings = [&](const QString &file, QQmlFormatOptions options) {
// Perform formatting inplace if --files option is set.
if (!options.files().isEmpty())
options.setIsInplace(true);
if (options.ignoreSettingsEnabled() || !settings.search(file))
return options;
QQmlFormatOptions perFileOptions = options;
perFileOptions.applySettings(settings);
return perFileOptions;
};
bool success = true;
if (!options.files().isEmpty()) {
if (!options.arguments().isEmpty())
qWarning() << "Warning: Positional arguments are ignored when -F is used";
for (const QString &file : options.files()) {
Q_ASSERT(!file.isEmpty());
if (!parseFile(file, getSettings(file, options)))
success = false;
}
} else {
for (const QString &file : options.arguments()) {
if (!parseFile(file, getSettings(file, options)))
success = false;
}
}
return success ? 0 : 1;
}
|