diff options
| author | Tom Lane | 2008-04-14 17:05:34 +0000 |
|---|---|---|
| committer | Tom Lane | 2008-04-14 17:05:34 +0000 |
| commit | 9b5c8d45f62bd3d243a40cc84deb93893f2f5122 (patch) | |
| tree | 2d75607f7bdb96cfa1d73a3a36a4b3328118ff08 /contrib/btree_gist/btree_bit.c | |
| parent | 10be77c173211a75718f50fe6061862f6a0cb4a2 (diff) | |
Push index operator lossiness determination down to GIST/GIN opclass
"consistent" functions, and remove pg_amop.opreqcheck, as per recent
discussion. The main immediate benefit of this is that we no longer need
8.3's ugly hack of requiring @@@ rather than @@ to test weight-using tsquery
searches on GIN indexes. In future it should be possible to optimize some
other queries better than is done now, by detecting at runtime whether the
index match is exact or not.
Tom Lane, after an idea of Heikki's, and with some help from Teodor.
Diffstat (limited to 'contrib/btree_gist/btree_bit.c')
| -rw-r--r-- | contrib/btree_gist/btree_bit.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/contrib/btree_gist/btree_bit.c b/contrib/btree_gist/btree_bit.c index 534c9af8131..d86034fd6ff 100644 --- a/contrib/btree_gist/btree_bit.c +++ b/contrib/btree_gist/btree_bit.c @@ -126,12 +126,17 @@ Datum gbt_bit_consistent(PG_FUNCTION_ARGS) { GISTENTRY *entry = (GISTENTRY *) PG_GETARG_POINTER(0); - GBT_VARKEY *key = (GBT_VARKEY *) DatumGetPointer(entry->key); void *query = (void *) DatumGetByteaP(PG_GETARG_DATUM(1)); StrategyNumber strategy = (StrategyNumber) PG_GETARG_UINT16(2); + /* Oid subtype = PG_GETARG_OID(3); */ + bool *recheck = (bool *) PG_GETARG_POINTER(4); bool retval = FALSE; + GBT_VARKEY *key = (GBT_VARKEY *) DatumGetPointer(entry->key); GBT_VARKEY_R r = gbt_var_key_readable(key); + /* All cases served by this function are exact */ + *recheck = false; + if (GIST_LEAF(entry)) retval = gbt_var_consistent(&r, query, &strategy, TRUE, &tinfo); else |